Bug 2375216 - Review-Request: python-pyrankvote - Library for different ranked voting methods
Summary: Review-Request: python-pyrankvote - Library for different ranked voting methods
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-06-27 14:17 UTC by Benson Muite
Modified: 2026-02-10 10:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-02-10 10:54:33 UTC
Type: ---
Embargoed:
gwync: fedora-review+


Attachments (Terms of Use)

Description Benson Muite 2025-06-27 14:17:33 UTC
spec: https://fed500.fedorapeople.org/python-pyrankvote.spec
srpm: https://fed500.fedorapeople.org/python-pyrankvote-2.0.6-1.fc41.src.rpm

description:
PyRankVote is a python library for different ranked-choice voting systems
(sometimes called preferential voting systems) created by Jon Tingvold in June
2019.

The following ranking methods are implemented for electing one person/
alternative (e.g. electing the chairman to a board):

Instant-runoff voting (IRV)—often known as the alternative vote
The following ranking methods are implemented for electing multiple
people/alternatives (e.g. electing board members):

- Single transferable vote (STV)—generally preferred
- Preferential block voting (PBV)
- Different ranking methods
- Instant runoff voting (IRV) is a single candidate election method that elects
  the candidate that can obtain majority support (more than 50%).

Voters rank candidates and are granted one vote. The candidate with fewest
votes is removed and this candidate's votes are transferred according to the
voters 2nd preference (or 3rd etc).

Preferential block voting (PBV) is a multiple candidate election method that
elects candidates that can obtain majority support (more than 50%). PBV tends
to elect uncontroversial candidates that agree with each other. Minority group
often lose their representation.

Voters rank candidates and are granted as many votes as there are people that
should be elected. The candidate with fewest votes are removed and this
candidate's votes are transferred according to the voters 2nd preference
(or 3rd etc).

Single transferable vote (STV) is a multiple candidate election method that
elects candidates based on proportional representation. Minority (and extreme)
groups get representation if they have enough votes to elect a candidate. STV
is therefore the preferred ranked-choice voting method for parliament elections
and most multiple seat elections, but it's more complex than PBV, so it
explained last.

Voters rank candidates and are granted as one vote each. If a candidate gets
more votes than the threshold for being elected, the candidate is proclaimed as
winner. This function uses the Droop quota, where

  droop_quota = votes/(seats+1) + 1

If one candidate gets more votes than the threshold the excess votes are
transferred to voters that voted for this candidate's 2nd (or 3rd, 4th, etc)
alternative. If no candidate gets over the threshold, the candidate with fewest
votes is removed. Votes for this candidate is then transferred to voters 2nd
(or 3rd, 4th, etc) alternative.

Preferential block voting and Single transferable vote are the same as
Instant-runoff voting when only one candidate is elected.

Instant-runoff voting and Preferential block voting are basically the same as
exhaustive ballot, the preferred method in Rober's rules of order. The only
difference is that in exhaustive ballot voters can adjust their preferences
between each round (elimination or election of one candidate).

fas: fed500

Reproducible: Always

Comment 1 Gwyn Ciesla 2025-07-04 18:39:05 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "*No copyright* Creative Commons Attribution". 21 files have
     unknown license. Detailed output of licensecheck in
     /home/gwyn/2375216-python-pyrankvote/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.14,
     /usr/lib/python3.14/site-packages
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
     Note: Macros in: python3-pyrankvote (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 11077 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-pyrankvote-2.0.6-1.fc43.noarch.rpm
          python-pyrankvote-2.0.6-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpm00jmglr')]
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 1.0 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/jontingvold/pyrankvote/archive/v2.0.6/pyrankvote-2.0.6.tar.gz :
  CHECKSUM(SHA256) this package     : e8a6c71035755a135c6baa150b523d497a9b5d0679cbf08d2f7facfdaee03103
  CHECKSUM(SHA256) upstream package : e8a6c71035755a135c6baa150b523d497a9b5d0679cbf08d2f7facfdaee03103


Requires
--------
python3-pyrankvote (rpmlib, GLIBC filtered):
    python(abi)
    python3.14dist(tabulate)



Provides
--------
python3-pyrankvote:
    python-pyrankvote
    python3-pyrankvote
    python3.14-pyrankvote
    python3.14dist(pyrankvote)
    python3dist(pyrankvote)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2375216
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Ruby, Java, C/C++, Perl, PHP, SugarActivity, Ocaml, Haskell, fonts, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


APPROVED

Comment 2 Fedora Admin user for bugzilla script actions 2025-07-09 17:43:47 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyrankvote

Comment 3 Fedora Admin user for bugzilla script actions 2025-07-13 22:15:51 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyrankvote

Comment 4 Benson Muite 2026-02-10 10:54:33 UTC
https://release-monitoring.org/project/90112/


Note You need to log in before you can comment on or make changes to this bug.