Bug 2376351 - akmods: check_default_kernel is never called, wrong calls to check_kernel_devel
Summary: akmods: check_default_kernel is never called, wrong calls to check_kernel_devel
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: akmods
Version: 43
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nicolas Chauvet (kwizart)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-07-04 12:37 UTC by Francis Montagnac
Modified: 2025-10-01 00:41 UTC (History)
7 users (show)

Fixed In Version: akmods-0.6.1-2.fc44 akmods-0.6.1-2.fc43 akmods-0.6.1-2.fc42 akmods-0.6.1-2.el10_2 akmods-0.6.1-2.el10_1 akmods-0.6.1-2.el10_0
Clone Of:
Environment:
Last Closed: 2025-09-22 13:23:19 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
akmods-fix-default-kernel.patch (851 bytes, patch)
2025-07-04 12:41 UTC, Francis Montagnac
no flags Details | Diff

Description Francis Montagnac 2025-07-04 12:37:52 UTC
When using akmods without specifying a kernel, the check_default_kernel function is not called
because the init function initializes the kernels variable to the current kernel beforehand.

Related lines in akmods:

  185:init ()

  197:    # fall back to current kernel if user didn't provide one
  198:    if [[ ! -n "${kernels}" ]] ; then
  199:            kernels="$(uname -r)"
  200:    fi

  681:init
  683:# only check for default_kernel if no value have been parsed
  684:if  [ -z "${kernels}" ] ; then
  685:    check_default_kernel
  686:fi

In addition, the calls to check_kernel_devel are wrong:

  315:                if [[ $(check_kernel_devel "${_kernel}" == 0) ]] ; then
  602:                        if [[ $(check_kernel_devel "${1}" != 0) ]] ; then

they should be:

  315:                if check_kernel_devel "${_kernel}" ; then
  602:                        if ! check_kernel_devel "${1}" ; then


Version used:
  https://kojipkgs.fedoraproject.org//packages/akmods/0.6.0/13.fc43/noarch/akmods-0.6.0-13.fc43.noarch.rpm

The attached patch fixes that I think.


Reproducible: Always

Comment 1 Francis Montagnac 2025-07-04 12:41:24 UTC
Created attachment 2096096 [details]
akmods-fix-default-kernel.patch

Comment 2 Nicolas Chauvet (kwizart) 2025-09-16 20:09:16 UTC
Thanks for the patches, I've finally had room for tests (actually I haven't but hey! )

I've added the change you have suggested. make sense.
I've also spotted another issue where grubby can be a symlink on upgraded system f42+ with unmerged-bin taint (in systemctl status)

There is also the rhbz#2379766 that is little different, I will check this situation...

Hopefully I will push the changes real soon.

Comment 3 Francis Montagnac 2025-09-18 07:13:05 UTC
Hi

(In reply to Nicolas Chauvet (kwizart) from comment #2)
> Thanks for the patches,
> I've added the change you have suggested. make sense.

Thanks.

> I've also spotted another issue where grubby can be a symlink on upgraded system f42+ with unmerged-bin
> taint (in systemctl status)

Oups. Sorry, I missed that you found that also before commenting in rhbz#2379766

Comment 4 Fedora Update System 2025-09-22 13:20:07 UTC
FEDORA-2025-37e985b13a (akmods-0.6.1-2.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-37e985b13a

Comment 5 Fedora Update System 2025-09-22 13:23:19 UTC
FEDORA-2025-37e985b13a (akmods-0.6.1-2.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2025-09-22 13:46:15 UTC
FEDORA-EPEL-2025-33ea68b80b (akmods-0.6.1-2.el10_2) has been submitted as an update to Fedora EPEL 10.2.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-33ea68b80b

Comment 7 Fedora Update System 2025-09-22 13:46:16 UTC
FEDORA-EPEL-2025-08996c0ee3 (akmods-0.6.1-2.el10_1) has been submitted as an update to Fedora EPEL 10.1.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-08996c0ee3

Comment 8 Fedora Update System 2025-09-22 13:46:16 UTC
FEDORA-EPEL-2025-b5c526537e (akmods-0.6.1-2.el10_0) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b5c526537e

Comment 9 Fedora Update System 2025-09-22 13:46:17 UTC
FEDORA-2025-d5be7c00c4 (akmods-0.6.1-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d5be7c00c4

Comment 10 Fedora Update System 2025-09-23 01:44:38 UTC
FEDORA-2025-d5be7c00c4 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-d5be7c00c4`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-d5be7c00c4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2025-09-23 01:57:41 UTC
FEDORA-EPEL-2025-08996c0ee3 has been pushed to the Fedora EPEL 10.1 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-08996c0ee3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-09-23 02:04:31 UTC
FEDORA-EPEL-2025-33ea68b80b has been pushed to the Fedora EPEL 10.2 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-33ea68b80b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-09-23 02:19:29 UTC
FEDORA-EPEL-2025-b5c526537e has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-b5c526537e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-09-23 02:46:02 UTC
FEDORA-2025-b18a85b925 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b18a85b925`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b18a85b925

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-09-26 00:20:03 UTC
FEDORA-2025-d5be7c00c4 (akmods-0.6.1-2.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2025-09-26 01:09:53 UTC
FEDORA-2025-b18a85b925 (akmods-0.6.1-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2025-10-01 00:27:30 UTC
FEDORA-EPEL-2025-33ea68b80b (akmods-0.6.1-2.el10_2) has been pushed to the Fedora EPEL 10.2 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2025-10-01 00:30:41 UTC
FEDORA-EPEL-2025-08996c0ee3 (akmods-0.6.1-2.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2025-10-01 00:41:49 UTC
FEDORA-EPEL-2025-b5c526537e (akmods-0.6.1-2.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.