Bug 237687 - convmv fails to build from sources
Summary: convmv fails to build from sources
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: convmv   
(Show other bugs)
Version: 5.0
Hardware: i386 Linux
Target Milestone: ---
: ---
Assignee: Nils Philippsen
QA Contact: QE Internationalization Bugs
Depends On:
TreeView+ depends on / blocked
Reported: 2007-04-24 19:27 UTC by giuseppe bonacci
Modified: 2010-10-18 16:57 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-09-27 14:56:27 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
proposed patch for (testsuite.tar)suite/dotests.sh (2.89 KB, patch)
2007-04-26 13:36 UTC, giuseppe bonacci
no flags Details | Diff

Description giuseppe bonacci 2007-04-24 19:27:35 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20070310 Iceweasel/ (Debian-

Description of problem:
when rpmbuild-ing the source rpm, the test suite fails. 

the reason is that the output from a "find" is compared to the output taken on a reference system.  the output lines are fine, except that usually the ordering differs, and that's ok.  before comparing, the test script should sort both the reference output and the observerd results, because find does not guarantee a fixed order. 

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. rpmbuild --rebuild convmv-1.10-1.el5.src.rpm

Actual Results:

Expected Results:

Additional info:

Comment 1 giuseppe bonacci 2007-04-26 13:36:58 UTC
Created attachment 153510 [details]
proposed patch for (testsuite.tar)suite/dotests.sh

Comment 3 Jens Petersen 2007-08-23 02:09:42 UTC
I think "LANG=C make test" should fix this.

Also it should be moved to %check.

Comment 4 giuseppe bonacci 2007-08-23 10:16:47 UTC
I tried to prepend LANG=C.  "make test" was already in '%check'. 

however, it did not work.  (BTW, I already build with LANG=C).

as far as I can tell, the locale does not matter.  the problem is due to the
assumption in dotests.sh that the list of filenames output by find is ordered 
exactly like in testsuite.tar.  generally, this is not the case: the order from 
find is unspecified.

is there any reason against the patch I submitted?  does it break something else?

Comment 5 Nils Philippsen 2007-09-27 14:56:27 UTC
I've applied your patch and moved "make test" to %check in the current Rawhide
version. I don't think we'd get the buy-in needed to warrant pushing a new
package version through for RHEL5 though.

Note You need to log in before you can comment on or make changes to this bug.