Red Hat Bugzilla – Bug 237687
convmv fails to build from sources
Last modified: 2010-10-18 12:57:44 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:188.8.131.52) Gecko/20070310 Iceweasel/184.108.40.206 (Debian-220.127.116.11-1)
Description of problem:
when rpmbuild-ing the source rpm, the test suite fails.
the reason is that the output from a "find" is compared to the output taken on a reference system. the output lines are fine, except that usually the ordering differs, and that's ok. before comparing, the test script should sort both the reference output and the observerd results, because find does not guarantee a fixed order.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. rpmbuild --rebuild convmv-1.10-1.el5.src.rpm
Created attachment 153510 [details]
proposed patch for (testsuite.tar)suite/dotests.sh
I think "LANG=C make test" should fix this.
Also it should be moved to %check.
I tried to prepend LANG=C. "make test" was already in '%check'.
however, it did not work. (BTW, I already build with LANG=C).
as far as I can tell, the locale does not matter. the problem is due to the
assumption in dotests.sh that the list of filenames output by find is ordered
exactly like in testsuite.tar. generally, this is not the case: the order from
find is unspecified.
is there any reason against the patch I submitted? does it break something else?
I've applied your patch and moved "make test" to %check in the current Rawhide
version. I don't think we'd get the buy-in needed to warrant pushing a new
package version through for RHEL5 though.