Bug 237800 - Wrong init script
Summary: Wrong init script
Keywords:
Status: CLOSED DUPLICATE of bug 246875
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: avahi
Version: 5.0
Hardware: All
OS: Linux
low
low
Target Milestone: ---
: ---
Assignee: Lennart Poettering
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 237789 237801 237802
TreeView+ depends on / blocked
 
Reported: 2007-04-25 14:50 UTC by Michal Marciniszyn
Modified: 2014-02-10 23:01 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-03-27 18:11:59 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Michal Marciniszyn 2007-04-25 14:50:32 UTC
Description of problem:
Following code ends up with error code 0 when networking is not presented even
though the service is not started. It also forbids the correct run of status
command of the script.
[ ${NETWORKING} = "no" ] && exit 0

AVAHI_BIN=/usr/sbin/avahi-daemon
test -x $AVAHI_BIN || exit 5
It appears in both avahi-daemon and avahi-dnsconfd. Also incorrect return codes
through the code are present.

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. service netowrk stop
2. service avahi-daemon start/status
3. echo $?
  
Actual results:
0

Expected results:
non-zero result with respect to our guidelines.

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 RHEL Program Management 2007-12-03 20:42:13 UTC
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release.  This request will
be reviewed for a future Red Hat Enterprise Linux release.

Comment 2 Lennart Poettering 2008-03-27 18:11:59 UTC
This has been fixed a while back upstream r1532, and in Fedora
avahi-0.6.21-3.fc8 and is a duplicate of 246875.

*** This bug has been marked as a duplicate of 246875 ***


Note You need to log in before you can comment on or make changes to this bug.