Bug 237814
| Summary: | Wrong init script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Michal Marciniszyn <mmarcini> | ||||
| Component: | bootparamd | Assignee: | Ondrej Dvoracek <odvorace> | ||||
| Status: | CLOSED DEFERRED | QA Contact: | |||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 5.0 | CC: | tvujec | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-06-05 20:29:47 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 237789, 237822, 237824 | ||||||
| Attachments: |
|
||||||
Created attachment 154895 [details]
Porposed patch
Please, try this patch and let me know.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Since this bugzilla is in a component that is not approved for the current release, it has been closed with resolution deferred. You may reopen this bugzilla for consideration in the next release. |
Description of problem: Following code returns 0 when the script is run even when the service is not started. [ -f /etc/bootparams ] || exit 0 # Check that networking is up. if [ ${NETWORKING} = "no" ] then exit 0 fi It also forbids the correct invocation of the status parameter. Also the return code for unknown request to the script is not 1 but 3... Version-Release number of selected component (if applicable): all How reproducible: always Steps to Reproduce: 1. service network stop 2. service bootparamd status 3. echo $? Actual results: 0 Expected results: status of the service Additional info: When fixing this bug, please obbey our init script guidelines and be sure that status command is run correctly. Our guidelines are on following two pages: http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html For an example of the script that returns the error codes correctly and always runs status see: http://devserv.devel.redhat.com/~mmarcini/amd This bug is tracked by 237789.