Bug 237814 - Wrong init script
Summary: Wrong init script
Status: CLOSED DEFERRED
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: bootparamd
Version: 5.0
Hardware: All
OS: Linux
low
low
Target Milestone: ---
: ---
Assignee: Ondrej Dvoracek
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 237789 237822 237824
TreeView+ depends on / blocked
 
Reported: 2007-04-25 15:10 UTC by Michal Marciniszyn
Modified: 2014-02-10 23:02 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-06-05 20:29:47 UTC


Attachments (Terms of Use)
Porposed patch (717 bytes, patch)
2007-05-17 07:46 UTC, Ondrej Dvoracek
no flags Details | Diff

Description Michal Marciniszyn 2007-04-25 15:10:45 UTC
Description of problem:
Following code returns 0 when the script is run even when the service is not
started.
[ -f /etc/bootparams ] || exit 0

# Check that networking is up.
if [ ${NETWORKING} = "no" ]
then
        exit 0
fi
It also forbids the correct invocation of the status parameter. Also the return
code for unknown request to the script is not 1 but 3...


Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. service network stop
2. service bootparamd status
3. echo $?
  
Actual results:
0

Expected results:
status of the service

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 Ondrej Dvoracek 2007-05-17 07:46:20 UTC
Created attachment 154895 [details]
Porposed patch

Please, try this patch and let me know.

Comment 2 RHEL Product and Program Management 2007-06-05 20:29:47 UTC
This request was evaluated by Red Hat Product Management for
inclusion in a Red Hat Enterprise Linux release.  Since this
bugzilla is in a component that is not approved for the current
release, it has been closed with resolution deferred.  You may
reopen this bugzilla for consideration in the next release.


Note You need to log in before you can comment on or make changes to this bug.