Bug 2378536 - cryptlib: Stop using deprecated python setup.py build/install command in the spec
Summary: cryptlib: Stop using deprecated python setup.py build/install command in the ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cryptlib
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralf Senderek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2376118
TreeView+ depends on / blocked
 
Reported: 2025-07-08 15:32 UTC by Miro Hrončok
Modified: 2025-07-17 15:56 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-07-17 15:56:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2025-07-08 15:32:45 UTC
Dear package maintainer,

this bugzilla is automated becasue the number of impacted packages it too high to go trough manually.


It appears that your package uses the deprecated setup.py build and/or install command in the spec file.

This is essentially the same as using the deprecated %py3_build/%py3_install macros.

See https://fedoraproject.org/wiki/Changes/DeprecateSetuppyMacros for why the macros are deprecated.

Th python setup.py build/install commands have been deprecated commands for 5 years and will likely stop working in Fedora 45.



Please migrate to %pyproject_buildrequires + %pyproject_wheel + %pyproject_install macros instead.

See https://fedoraproject.org/wiki/Changes/DeprecateSetuppyMacros#Migrating_to_%pyproject_macros for migration guide.

See https://github.com/hroncok/pyprojectize/ for a tool that can help you automate the migration.


Thank you. Let me know if you need help.

Comment 1 Ralf Senderek 2025-07-16 13:23:22 UTC
Hello Miro,

I have removed the call to setup.py build in the spec file.

The shared library cryptlib_py.so is now build with %pyproject_wheel.

This issue is resolved with the rawhide build https://koji.fedoraproject.org/koji/buildinfo?buildID=2745097

Ralf Senderek

Comment 3 Ralf Senderek 2025-07-16 15:43:39 UTC
(In reply to Miro Hrončok from comment #2)
> Thanks, please also read
> https://lists.fedoraproject.org/archives/list/python-devel@lists.
> fedoraproject.org/thread/NMAI7IKK7ZK4VT2SRZCCUK4LLKJGZZ5D/

I have %pyproject_buildrequires in line 157 of the spec file.
So all mandatory requirements are met.

Ralf Senderek

Comment 4 Miro Hrončok 2025-07-17 09:45:42 UTC
It needs to be in the %genearte_buildrequires section:

https://src.fedoraproject.org/rpms/cryptlib/pull-request/8

Comment 5 Ralf Senderek 2025-07-17 15:56:27 UTC
(In reply to Miro Hrončok from comment #4)
> It needs to be in the %genearte_buildrequires section:
> 
> https://src.fedoraproject.org/rpms/cryptlib/pull-request/8


Thank you for your help. Full migration has been completed with rawhide build https://koji.fedoraproject.org/koji/taskinfo?taskID=134896022.


Note You need to log in before you can comment on or make changes to this bug.