Copr build:
https://copr.fedorainfracloud.org/coprs/build/9257058
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2379003-rust-visibility/fedora-rawhide-x86_64/09257058-rust-visibility/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> # cargo package doesn't include "downstream_crate":
> # https://github.com/danielhenrymantilla/visibility.rs/issues/13
> %bcond check 0

This is expected - "downstream_crate" is a workspace member (i.e. a separate *crate*) that's not published.
In this case I would just say "test input data is not included in published crates".

It might also be good to drop the "LICENSE" file that says "No license.", as was done upstream here:
https://github.com/danielhenrymantilla/visibility.rs/commit/35326d6

(Removing the `%license LICENSE` line and adding a link to this commit should be enough, I think.)

Hmm, something new when building this with fedpkg local:

/usr/bin/cargo2rpm --path Cargo.toml buildrequires

Traceback (most recent call last):
  File "/usr/bin/cargo2rpm", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/usr/lib/python3.13/site-packages/cargo2rpm/__main__.py", line 115, in main
    action_buildrequires(args)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/usr/lib/python3.13/site-packages/cargo2rpm/__main__.py", line 52, in action_buildrequires
    brs = buildrequires(metadata.packages[0], flags, args.with_check)
  File "/usr/lib/python3.13/site-packages/cargo2rpm/rpm.py", line 136, in buildrequires
    if msrv := package.rust_version:
               ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/cargo2rpm/metadata.py", line 200, in rust_version
    return self._data["rust_version"]
           ~~~~~~~~~~^^^^^^^^^^^^^^^^
KeyError: 'rust_version'

Don't use `fedpkg local`.

It looks like you have rustup-installed "cargo" in your $PATH, which causes download and usage of the Rust 1.56 toolchain due to the presence of the "rust-toolchain" file, and that apparently didn't (yet) contain the "rust_version" field in the JSON output for "cargo metadata".

Don't use `fedpkg local`. -> what instead?

right, I have rustup-installed version on my host, and it's still used when I go in a toolbox... it might be worth to add some extra checks in cargo2rpm.

> Don't use `fedpkg local`. -> what instead?

... mock? (or `fedpkg mockbuild`?)

Building Rust stuff outside of mock isn't something officially supported by the toolchain for building Rust packages.

> it might be worth to add some extra checks in cargo2rpm.

What kind of checks?

cargo2rpm intentionally uses `cargo` from $PATH because that's in almost all cases the correct thing to do.

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-visibility/rust-visibility.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/09356647/rust-visibility-0.1.1-1.src.rpm
Description: Attribute to override the visibility of items
Fedora Account System Username: elmarco

Thanks, looks good to me now.

Hopefully there will be a new upstream release soon so the downstream workarounds can be dropped.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (test input data - un-published workspace members - are not available)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-visibility

FEDORA-2025-2a842af470 (rust-visibility-0.1.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-2a842af470

FEDORA-2025-2a842af470 (rust-visibility-0.1.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.