Bug 237921 - Hal cannot clean up the /media directory after mounting a disk named with characters that need escaping
Summary: Hal cannot clean up the /media directory after mounting a disk named with cha...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: hal
Version: 6
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Zeuthen
QA Contact:
URL:
Whiteboard: bzcl34nup
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-04-26 03:36 UTC by Daphne Shaw
Modified: 2013-03-06 03:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-06 19:32:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch for the escaping problem (1.14 KB, patch)
2007-04-27 03:33 UTC, Daphne Shaw
no flags Details | Diff
A better fix for the escaped characters problem (582 bytes, patch)
2007-04-27 18:06 UTC, Daphne Shaw
no flags Details | Diff

Description Daphne Shaw 2007-04-26 03:36:08 UTC
Description of problem:

Hal cannot clean up the /media directory after mounting a disk named with
characters that need escaping.  The directory under /media is created correctly
(i.e. unescaped), but the copy of the directory name in /media/.hal-mtab is
stored escaped.  When it comes time to delete the directory, hal tries to remove
the escaped name and not the unescaped name, which will fail.

Version-Release number of selected component (if applicable):

hal-0.5.8.1-6.fc6

How reproducible:

Arrange for hal to automount a disk with characters that it wants to escape. 
hal-storage-mount calls g_strescape() so that includes any character that
g_strescape() will escape.

Steps to Reproduce:
1. mkfs.vfat /some/device -n "badcharacter&"
2. Have HAL automount the disk
3. Try to unmount it and see HAL throw a "Cannot unmount volume" error with the
reason "Cannot remove directory".

Comment 1 Daphne Shaw 2007-04-27 03:33:26 UTC
Created attachment 153575 [details]
Patch for the escaping problem

Patch.

Comment 2 Daphne Shaw 2007-04-27 18:06:10 UTC
Created attachment 153652 [details]
A better fix for the escaped characters problem

A better patch

Comment 3 Bug Zapper 2008-04-04 07:06:43 UTC
Fedora apologizes that these issues have not been resolved yet. We're
sorry it's taken so long for your bug to be properly triaged and acted
on. We appreciate the time you took to report this issue and want to
make sure no important bugs slip through the cracks.

If you're currently running a version of Fedora Core between 1 and 6,
please note that Fedora no longer maintains these releases. We strongly
encourage you to upgrade to a current Fedora release. In order to
refocus our efforts as a project we are flagging all of the open bugs
for releases which are no longer maintained and closing them.
http://fedoraproject.org/wiki/LifeCycle/EOL

If this bug is still open against Fedora Core 1 through 6, thirty days
from now, it will be closed 'WONTFIX'. If you can reporduce this bug in
the latest Fedora version, please change to the respective version. If
you are unable to do this, please add a comment to this bug requesting
the change.

Thanks for your help, and we apologize again that we haven't handled
these issues to this point.

The process we are following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

And if you'd like to join the bug triage team to help make things
better, check out http://fedoraproject.org/wiki/BugZappers

Comment 4 Bug Zapper 2008-05-06 19:32:20 UTC
This bug is open for a Fedora version that is no longer maintained and
will not be fixed by Fedora. Therefore we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen thus bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.