Bug 237942 - Wrong init script
Wrong init script
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: cpuspeed (Show other bugs)
rawhide
All Linux
low Severity low
: ---
: ---
Assigned To: Jarod Wilson
:
Depends On: 237940
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-26 05:06 EDT by Michal Marciniszyn
Modified: 2014-02-10 18:02 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-26 12:04:14 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Michal Marciniszyn 2007-04-26 05:06:00 EDT
+++ This bug was initially created as a clone of Bug #237940 +++

Description of problem:
Following code ends the script with error code 0 when the binary does not exist
even though the service was not started.
[ -f /usr/sbin/cpuspeed ] || exit 0
There are also minor errors in wrong error codes (unimplemented feature
(reload/start_again or something) has error code 3 and not one.

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. rename the binary
2. service cpuspeed start/status
3. echo $?
  
Actual results:
0

Expected results:
correct error code/status of the service

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.
Comment 1 Jarod Wilson 2007-04-26 12:04:14 EDT
Corrected exit codes for case where binary isn't present and when user tries an
unimplemented feature.

Note You need to log in before you can comment on or make changes to this bug.