Bug 237973 - Wrong init script
Wrong init script
Product: Fedora
Classification: Fedora
Component: dhcpv6 (Show other bugs)
All Linux
low Severity low
: ---
: ---
Assigned To: David Cantrell
Depends On: 237970
  Show dependency treegraph
Reported: 2007-04-26 08:34 EDT by Michal Marciniszyn
Modified: 2014-02-10 18:02 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-04-26 14:29:36 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Michal Marciniszyn 2007-04-26 08:34:38 EDT
+++ This bug was initially created as a clone of Bug #237970 +++

Description of problem:
In both init scripts (dhcp6r/dhcp6s) there are several constructions that end
the script with error code 0 when the service is not started. For example:
# Check that networking is up.
[ ${NETWORKING} = "no" ] && exit 0

# Check that files exist
[ -f /usr/sbin/dhcp6r ] || exit 0
[ -f /etc/sysconfig/dhcp6r ] || exit 0
Also there is at least one place with wrong error code (1 if script function is
not implemented (refresh/start_again :-) ) instead of 3) at the end of each script.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. service network stop
2. service dhcp6r/s start/status
3. echo $?
Actual results:

Expected results:
non-zero exit code/status of the service

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:

For an example of the script that returns the error codes correctly and always
runs status see:

This bug is tracked by 237789.
Comment 1 David Cantrell 2007-04-26 14:29:36 EDT
Fixed in rawhide in dhcpv6-0.10-42.  Thanks.

Note You need to log in before you can comment on or make changes to this bug.