Bug 2381104 - prusa-slicer: FTBFS with change proposal CMake: Use ninja generator by default
Summary: prusa-slicer: FTBFS with change proposal CMake: Use ninja generator by default
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: prusa-slicer
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Pazdziora
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2376112
TreeView+ depends on / blocked
 
Reported: 2025-07-16 15:21 UTC by Cristian Le
Modified: 2025-08-02 11:16 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-08-02 11:16:18 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Cristian Le 2025-07-16 15:21:49 UTC
Dear package maintainer,

This is an automated bug created due to a FTBFS when rebuilding this package for the change proposal CMake: Use ninja generator by default.

The rebuild is being tracked in https://copr.fedorainfracloud.org/coprs/lecris/cmake-ninja/package/prusa-slicer.

See https://fedoraproject.org/wiki/Changes/CMake_ninja_default for more information on how to make the package compatible.

More specifically, make sure you are using standard %cmake_* macros. If you find that there are hard dependencies on
the generator even after such transition, please ping me for closer investigation.

You can check the build locally following the instructions in the change proposal, or submit your build to the tracking
copr project.

Let me know if you encounter any issues, or need any other help.

Comment 1 Jan Pazdziora 2025-07-16 15:46:22 UTC
Hello,

I assume the failing build in question is https://copr.fedorainfracloud.org/coprs/lecris/cmake-ninja/build/9277003/, with log in https://download.copr.fedorainfracloud.org/results/lecris/cmake-ninja/fedora-rawhide-x86_64/09277003-prusa-slicer/builder-live.log.gz.

Looking at https://src.fedoraproject.org/rpms/prusa-slicer/blob/rawhide/f/prusa-slicer.spec we use the %cmake_* macros as needed, and the failure comes from the line

  %cmake_build -- test ARGS=-V

leading to

  Run Build Command(s): /usr/bin/ninja-build -v -j 4 test ARGS=-V
  ninja: error: unknown target 'ARGS=-V'

How should that line be changed?

Comment 2 Cristian Le 2025-07-16 15:54:09 UTC
Thanks for looking into it. Changing it to `%ctest` macro should do the trick. Just change that line with `%ctest`

Comment 3 Jan Pazdziora 2025-08-01 13:46:04 UTC
Filed https://src.fedoraproject.org/rpms/prusa-slicer/pull-request/54 with this change.

Scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=135570679 passed.

What is the best way to try that build with the ninja generator settings?

Comment 4 Cristian Le 2025-08-01 18:55:43 UTC
Best option would be to ping me and I can do the rebuild or close the issue with a merge and it will rebuild it in the next round. If you want to do locally, here's one way
```
$ copr mock-config lecris/cmake-ninja fedora-rawhide-x86_64 > ~/.config/mock/cmake-ninja.cfg
$ mock -r cmake-ninja ./prusa-slicer-*.src.rpm
```

Comment 5 Jan Pazdziora 2025-08-02 11:16:18 UTC
The PR merged, prusa-slicer-2.9.2-5.fc43 built in https://koji.fedoraproject.org/koji/taskinfo?taskID=135599595, https://bodhi.fedoraproject.org/updates/FEDORA-2025-d892f1a8d8 got auto-filed.


Note You need to log in before you can comment on or make changes to this bug.