Spec URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings.spec SRPM URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings-0.2.1-1.fc43.src.rpm Description: Homey Rust bindings for the tree-sitter C library. Fedora Account System Username: blinxen
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=134903826
Some things that aren't quite right yet: 1. You adapt the License tag in the spec file, but not in Cargo.toml. This will only have a local effect and not propagate to dependent packages that use the `%cargo_license*` macros. You need to patch Cargo.toml for it to have a global effect. 2. It looks like not all of icu is bundled (as you mentioned) - looking at the files that are included, they all seem to have a Unicode license header, and none with BSD-2/3-Clause or Public Domain dedications. Can you double-check whether you can drop those SPDX identifiers from the License tag? It would simplify things.
> 1. You adapt the License tag in the spec file, but not in Cargo.toml. This will only have a local effect and not propagate to dependent packages that use the `%cargo_license*` macros. You need to patch Cargo.toml for it to have a global effect. I added a patch to update the license field in the "Cargo.toml" file. > 2. It looks like not all of icu is bundled (as you mentioned) - looking at the files that are included, they all seem to have a Unicode license header, and none with BSD-2/3-Clause or Public Domain dedications. Can you double-check whether you can drop those SPDX identifiers from the License tag? It would simplify things. You are right, I checked again and it seems tree-sitter is only using "Unicode-DFS-2016" licensed files from the ICU repository. Links to the updated files: Spec URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings.spec SRPM URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings-0.2.1-1.fc43.src.rpm
Thanks, looks pretty good to me now. One last thing: Please exclude the "vendor.sh" file from the package. It will be unused, and it causes a dependency on /usr/bin/bash to get generated. (Preferably with a - potentially upstreamable - patch to Cargo.toml, or alternatively, with a non-upstreamable %exclude item in the %files list of the "devel" subpackage.)
I excluded the file using "%exclude" for now and will try to upstream it later. Links to the updated files: SRPM URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings-0.2.1-1.fc43.src.rpm Spec URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings.spec
Thanks, looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ bundled content is correctly declared ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-house-bindings
FEDORA-2025-e1919d75bc (rust-tree-house-bindings-0.2.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e1919d75bc
FEDORA-2025-e1919d75bc (rust-tree-house-bindings-0.2.1-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.