Spec URL: https://dreua.fedorapeople.org/mwparserfromhell/python-mwparserfromhell.spec SRPM URL: https://dreua.fedorapeople.org/mwparserfromhell/python-mwparserfromhell-0.7.2-4.fc42.src.rpm Description: mwparserfromhell (the MediaWiki Parser from Hell) is a Python package that provides an easy-to-use and outrageously powerful parser for MediaWiki wikicode. Fedora Account System Username: dreua I needed this patch and a few additional instructions in the spec because upstream's pyproject.toml is not compatible with Fedora 42's older version of setuptools. Patch URL: https://dreua.fedorapeople.org/mwparserfromhell/setuptools-version-relax.patch
Scratch build against rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=134911600 (Mock build against f42 was successful locally.)
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/avl_tree.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/common.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/contexts.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/definitions.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/tag_data.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/textbuffer.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/tok_parse.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/tok_support.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/tokenizer.h python3-mwparserfromhell : /usr/lib64/python3.14/site- packages/mwparserfromhell/parser/ctokenizer/tokens.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 40 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-mwparserfromhell/2381850-python- mwparserfromhell/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.14/site- packages, /usr/lib64/python3.14 [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8893 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-mwparserfromhell-0.7.2-4.fc43.x86_64.rpm python-mwparserfromhell-0.7.2-4.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpq2uay_o_')] checks: 32, packages: 2 python-mwparserfromhell.src: E: spelling-error ('wikicode', 'Summary(en_US) wikicode -> wiki code, wiki-code, microcode') python-mwparserfromhell.src: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', 'Summary(en_US) wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/avl_tree.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/avl_tree.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/common.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/contexts.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/definitions.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/definitions.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tag_data.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tag_data.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/textbuffer.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/textbuffer.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_parse.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_parse.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_support.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_support.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokenizer.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokenizer.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokens.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokens.h 2 packages and 0 specfiles checked; 4 errors, 18 warnings, 7 filtered, 4 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', 'Summary(en_US) wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/avl_tree.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/avl_tree.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/common.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/contexts.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/definitions.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/definitions.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tag_data.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tag_data.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/textbuffer.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/textbuffer.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_parse.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_parse.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_support.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tok_support.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokenizer.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokenizer.h python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokens.c python3-mwparserfromhell.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/ctokenizer/tokens.h 1 packages and 0 specfiles checked; 2 errors, 18 warnings, 3 filtered, 2 badness; has taken 0.5 s Unversioned so-files -------------------- python3-mwparserfromhell: /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/_tokenizer.cpython-314-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/earwig/mwparserfromhell/archive/v0.7.2/mwparserfromhell-0.7.2.tar.gz : CHECKSUM(SHA256) this package : 4ade2085d75f5ffd4faf3e9100b934e3a470b560dbcc1d716a8fb6764f8775e4 CHECKSUM(SHA256) upstream package : 4ade2085d75f5ffd4faf3e9100b934e3a470b560dbcc1d716a8fb6764f8775e4 Requires -------- python3-mwparserfromhell (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH) Provides -------- python3-mwparserfromhell: python-mwparserfromhell python3-mwparserfromhell python3-mwparserfromhell(x86-64) python3.14-mwparserfromhell python3.14dist(mwparserfromhell) python3dist(mwparserfromhell) Diff spec file in url and in SRPM --------------------------------- --- /home/fedora-packaging/reviews/python-mwparserfromhell/2381850-python-mwparserfromhell/srpm/python-mwparserfromhell.spec 2025-07-18 08:50:24.161159594 +0300 +++ /home/fedora-packaging/reviews/python-mwparserfromhell/2381850-python-mwparserfromhell/srpm-unpacked/python-mwparserfromhell.spec 2025-07-18 03:00:00.000000000 +0300 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 4; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global modname mwparserfromhell @@ -63,3 +73,15 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Fri Jul 18 2025 David Auer <dreua> - 0.7.2-4 +- Add workarounds for older setuptools + +* Thu Jul 17 2025 David Auer <dreua> - 0.7.2-3 +- Build c extension, disable pytest + +* Thu Jul 17 2025 David Auer <dreua> - 0.7.2-2 +- Fix typo, more gitignore + +* Thu Jul 17 2025 David Auer <dreua> - 0.7.2-1 +- Start packaging mwparserfromhell +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2381850 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic, Python Disabled plugins: Ocaml, PHP, fonts, Haskell, Perl, Java, SugarActivity, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Can tests be run? Would need to add pytest as a dependency.
Thanks for the super fast feedback and good catch with the extension sources! Regarding the C extension I haven't found any packaging guidelines for this specifically, but I believe I found a good solution following the general guidelines and looking at some other spec files with python-*-devel subpackages. I'm not sure the -devel package is very useful (everyone who'll develop with that will probably just clone the source and go from there) but for the sake of following the rules as good as possible there is now the -devel package. The unversioned so file should be alright because it is only for internal use and not in any searchpath. Tests are now enabled and passing. Spec URL: https://dreua.fedorapeople.org/mwparserfromhell/python-mwparserfromhell.spec SRPM URL: https://dreua.fedorapeople.org/mwparserfromhell/python-mwparserfromhell-0.7.2-6.fc42.src.rpm
Forgot the %{?_isa} extension in the subpackage requires, I've added that locally so it won't be forgotten. Fixed line: Requires: python3-%{modname}%{?_isa} = %{version}-%{release}
Uploaded another rebuild for the missing isa part, no more mention of it in my local fedora-review run. Benson, could you have another look and maybe approve the package is everything is alright? Thanks, David Spec URL: https://dreua.fedorapeople.org/mwparserfromhell/python-mwparserfromhell.spec SRPM URL: https://dreua.fedorapeople.org/mwparserfromhell/python-mwparserfromhell-0.7.2-7.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9436570 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2381850-python-mwparserfromhell/fedora-rawhide-x86_64/09436570-python-mwparserfromhell/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 40 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python- mwparserfromhell/2381850-python-mwparserfromhell/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.14, /usr/lib64/python3.14/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8893 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-mwparserfromhell , python3-mwparserfromhell-devel [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-mwparserfromhell-0.7.2-7.fc43.x86_64.rpm python3-mwparserfromhell-devel-0.7.2-7.fc43.x86_64.rpm python-mwparserfromhell-0.7.2-7.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpl2wqvxvo')] checks: 32, packages: 3 python-mwparserfromhell.src: E: spelling-error ('wikicode', 'Summary(en_US) wikicode -> wiki code, wiki-code, microcode') python-mwparserfromhell.src: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', 'Summary(en_US) wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell-devel.x86_64: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 5 errors, 1 warnings, 12 filtered, 5 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', 'Summary(en_US) wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell.x86_64: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell-devel.x86_64: E: spelling-error ('wikicode', '%description -l en_US wikicode -> wiki code, wiki-code, microcode') python3-mwparserfromhell-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 3 errors, 1 warnings, 8 filtered, 3 badness; has taken 0.4 s Unversioned so-files -------------------- python3-mwparserfromhell: /usr/lib64/python3.14/site-packages/mwparserfromhell/parser/_tokenizer.cpython-314-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/earwig/mwparserfromhell/archive/v0.7.2/mwparserfromhell-0.7.2.tar.gz : CHECKSUM(SHA256) this package : 4ade2085d75f5ffd4faf3e9100b934e3a470b560dbcc1d716a8fb6764f8775e4 CHECKSUM(SHA256) upstream package : 4ade2085d75f5ffd4faf3e9100b934e3a470b560dbcc1d716a8fb6764f8775e4 Requires -------- python3-mwparserfromhell (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH) python3-mwparserfromhell-devel (rpmlib, GLIBC filtered): python3-mwparserfromhell(x86-64) Provides -------- python3-mwparserfromhell: python-mwparserfromhell python3-mwparserfromhell python3-mwparserfromhell(x86-64) python3.14-mwparserfromhell python3.14dist(mwparserfromhell) python3dist(mwparserfromhell) python3-mwparserfromhell-devel: python-mwparserfromhell-devel python3-mwparserfromhell-devel python3-mwparserfromhell-devel(x86-64) python3.14-mwparserfromhell-devel Diff spec file in url and in SRPM --------------------------------- --- /home/fedora-packaging/reviews/python-mwparserfromhell/2381850-python-mwparserfromhell/srpm/python-mwparserfromhell.spec 2025-08-17 07:10:50.309199879 +0300 +++ /home/fedora-packaging/reviews/python-mwparserfromhell/2381850-python-mwparserfromhell/srpm-unpacked/python-mwparserfromhell.spec 2025-08-16 03:00:00.000000000 +0300 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 7; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global modname mwparserfromhell @@ -72,3 +82,24 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sat Aug 16 2025 David Auer <dreua> - 0.7.2-7 +- Add isa to requires + +* Fri Jul 18 2025 David Auer <dreua> - 0.7.2-6 +- Enable pytest + +* Fri Jul 18 2025 David Auer <dreua> - 0.7.2-5 +- Move C extension source files to subpackage + +* Fri Jul 18 2025 David Auer <dreua> - 0.7.2-4 +- Add workarounds for older setuptools + +* Thu Jul 17 2025 David Auer <dreua> - 0.7.2-3 +- Build c extension, disable pytest + +* Thu Jul 17 2025 David Auer <dreua> - 0.7.2-2 +- Fix typo, more gitignore + +* Thu Jul 17 2025 David Auer <dreua> - 0.7.2-1 +- Start packaging mwparserfromhell +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2381850 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, C/C++, Generic Disabled plugins: Haskell, Perl, fonts, R, Ocaml, Java, SugarActivity, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Just use the patch for Fedora 42 and 41, rawhide and 43 builds do not need it. b) Koji build without patch: https://koji.fedoraproject.org/koji/taskinfo?taskID=136165498 c) Am not sure the C source needs to be packaged once the extension has been built, can indicate it also pyprovides a devel package, see for example https://src.fedoraproject.org/rpms/python-nanobind/blob/rawhide/f/python-nanobind.spec What you have done seems fine though. d) Approved. Please fix a upon importing for rawhide and f42. e) Review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2385917 https://bugzilla.redhat.com/show_bug.cgi?id=2386164 https://bugzilla.redhat.com/show_bug.cgi?id=2366188 would be appreciated if time and expertise allow.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mwparserfromhell
FEDORA-2025-e20891a144 (python-mwparserfromhell-0.7.2-2.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e20891a144
FEDORA-2025-504abfba98 (python-mwparserfromhell-0.7.2-2.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-504abfba98
a/b) Absolutely right, thanks for the heads up! c) I think the pyprovides (and deprecates) in this cases were added because a previously existing -devel packages was removed. (Confirmed that in the git history.) So I'm not sure if I'm missing the point or there was a misunderstanding on your side in this case. Regarding the C files, yes the are usually excluded I guess. But its just a handfull of bytes in a packages that no one is likely to install anyway. d) Thanks a lot for the review! Builds are underway and a is fixed for f43 and later. e) I'll look into it :)
FEDORA-2025-04f1c3c02b (python-mwparserfromhell-0.7.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-04f1c3c02b
FEDORA-2025-e20891a144 (python-mwparserfromhell-0.7.2-2.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-504abfba98 (python-mwparserfromhell-0.7.2-2.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-04f1c3c02b has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-04f1c3c02b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-04f1c3c02b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-04f1c3c02b (python-mwparserfromhell-0.7.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.