Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://jjames.fedorapeople.org/ocaml-patch/ocaml-patch.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-patch/ocaml-patch-3.0.0-1.fc43.src.rpm Fedora Account System Username: jjames Description: The patch module lets you apply your unified diffs in pure OCaml. The loosely specified `diff` file format is widely used for transmitting differences of line-based information. The motivating example is opam, which is able to validate updates being cryptographically signed by providing a unified diff. In addition, some support for the git diff format is available. I am willing to swap reviews.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "ISC License", "*No copyright* ISC License", "*No copyright* BSD 2-Clause License", "*No copyright* BSD 3-Clause License and/or MIT License". 52 files have unknown license. Detailed output of licensecheck in /var/tmp/2381957-ocaml- patch/licensecheck.txt Upstream don't really "do" license statements in their source files, but the intent is clearly ISC. The upstream license is: https://github.com/hannesm/patch/blob/main/LICENSE.md [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. Applied by dune macros. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. Uses autochangelog. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6613 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. Did not test, but we'll be using it to build other packages soon. [x]: Latest version is packaged. Latest upstream is 3.0.0, same as the packaged version. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. No upstream signatures as far as I can tell. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. Only on x86-64, because of the dependencies. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-patch-3.0.0-1.fc43.x86_64.rpm ocaml-patch-devel-3.0.0-1.fc43.x86_64.rpm ocaml-patch-3.0.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6iaizlvt')] checks: 32, packages: 3 ocaml-patch-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/patch/patch.a ocaml-patch.src: E: spelling-error ('opam', '%description -l en_US opam -> spam, opal, Spam') ocaml-patch.src: E: spelling-error ('cryptographically', '%description -l en_US cryptographically -> photographically, typographically, topographically') ocaml-patch.x86_64: E: spelling-error ('opam', '%description -l en_US opam -> spam, opal, Spam') ocaml-patch.x86_64: E: spelling-error ('cryptographically', '%description -l en_US cryptographically -> photographically, typographically, topographically') ocaml-patch-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 5 errors, 1 warnings, 11 filtered, 5 badness; has taken 0.2 s Rpmlint (debuginfo) ------------------- Checking: ocaml-patch-debuginfo-3.0.0-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcs2xdgfo')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_equal (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_int_of_string (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_exn_Not_found (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_notequal (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Format.anon_fn$5bformat.ml$3a1453$2c27$2d$2d33$5d_5500_closure (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_exn_Invalid_argument (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_exn_Assert_failure (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_call_gc (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Format.pp_print_text_4816 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_ml_array_bound_error (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Char.chr_26 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.rev_append_366 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.tl_258 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Buffer.add_string_705 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Bytes.blit_string_538 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.rev_381 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib.max_390 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__String.split_on_char_1098 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.find_all_1554 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib.failwith_326 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_c_call (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_initialize (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_fresh_oo_id (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Buffer.resize_347 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_reraise_exn (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Buffer.add_substring_581 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Bytes.sub_332 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__String.trim_538 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_call_realloc_stack (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Buffer.create_122 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.hd_242 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_raise_exn (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib.invalid_arg_337 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.length_224 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_blit_string (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.fold_left_788 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__String.index_619 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib.$5e_459 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__List.iter_740 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Buffer.add_char_427 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Format.kfprintf_5429 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Format.pp_print_string_1827 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__String.concat_355 (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs caml_string_equal (/usr/lib64/ocaml/patch/patch.cmxs) ocaml-patch.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/patch/patch.cmxs camlStdlib__Printf.bprintf_132 (/usr/lib64/ocaml/patch/patch.cmxs) I'm not sure what undefined-non-weak-symbol is caused by. May be a problem with rpmlint and/or OCaml. ocaml-patch-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/patch/patch.a ocaml-patch.x86_64: E: spelling-error ('opam', '%description -l en_US opam -> spam, opal, Spam') ocaml-patch.x86_64: E: spelling-error ('cryptographically', '%description -l en_US cryptographically -> photographically, typographically, topographically') ocaml-patch-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 3 errors, 46 warnings, 13 filtered, 3 badness; has taken 0.2 s Source checksums ---------------- https://codeberg.org/kit-ty-kate/ocaml-patch-tests/archive/main.tar.gz#/ocaml-patch-tests.tar.gz : CHECKSUM(SHA256) this package : 65ea13b23fb23481b4d34c5adf6754d517924cd687f752fcc3ecb1c3cc76a334 CHECKSUM(SHA256) upstream package : 65ea13b23fb23481b4d34c5adf6754d517924cd687f752fcc3ecb1c3cc76a334 https://github.com/hannesm/patch/archive/v3.0.0/patch-3.0.0.tar.gz : CHECKSUM(SHA256) this package : b5e0dfb6de145de58ec325109b4f7eef69ff40471eff8e76c42c0733f72ffbe5 CHECKSUM(SHA256) upstream package : b5e0dfb6de145de58ec325109b4f7eef69ff40471eff8e76c42c0733f72ffbe5 Requires -------- ocaml-patch (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Patch__) ocaml(Patch__Fname) ocaml(Patch__Lib) ocaml(Stdlib) ocaml(Stdlib__Buffer) ocaml(Stdlib__Char) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__List) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__String) ocaml(Stdlib__Uchar) rtld(GNU_HASH) ocaml-patch-devel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Patch__) ocaml(Patch__Fname) ocaml(Patch__Lib) ocaml(Stdlib) ocaml(Stdlib__Buffer) ocaml(Stdlib__Char) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__List) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__String) ocaml(Stdlib__Uchar) ocaml-patch(x86-64) ocamlx(CamlinternalFormat) ocamlx(Patch__Fname) ocamlx(Patch__Lib) ocamlx(Stdlib) ocamlx(Stdlib__Buffer) ocamlx(Stdlib__Bytes) ocamlx(Stdlib__Char) ocamlx(Stdlib__Format) ocamlx(Stdlib__List) ocamlx(Stdlib__Printf) ocamlx(Stdlib__String) Provides -------- ocaml-patch: ocaml(Patch) ocaml(Patch__) ocaml(Patch__Fname) ocaml(Patch__Lib) ocaml-patch ocaml-patch(x86-64) ocaml-patch-devel: ocaml(Patch) ocaml(Patch__) ocaml(Patch__Fname) ocaml(Patch__Lib) ocaml-patch-devel ocaml-patch-devel(x86-64) ocamlx(Patch) ocamlx(Patch__) ocamlx(Patch__Fname) ocamlx(Patch__Lib) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2381957 -L /var/tmp/2381956-ocaml-crowbar/results/ Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Ocaml, Generic, Shell-api Disabled plugins: fonts, R, Python, Haskell, SugarActivity, Perl, Java, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Built with local dependencies: /var/tmp/2381956-ocaml-crowbar/results/ocaml-crowbar-debugsource-0.2.1-1.fc43.x86_64.rpm /var/tmp/2381956-ocaml-crowbar/results/ocaml-crowbar-devel-0.2.1-1.fc43.x86_64.rpm /var/tmp/2381956-ocaml-crowbar/results/ocaml-crowbar-0.2.1-1.fc43.src.rpm /var/tmp/2381956-ocaml-crowbar/results/ocaml-crowbar-0.2.1-1.fc43.x86_64.rpm /var/tmp/2381956-ocaml-crowbar/results/ocaml-crowbar-debuginfo-0.2.1-1.fc43.x86_64.rpm
*** This package is APPROVED for Fedora by rjones ***
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-patch
FEDORA-2025-91befcbe9d (ocaml-patch-3.0.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-91befcbe9d
FEDORA-2025-91befcbe9d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-91befcbe9d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-91befcbe9d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-91befcbe9d (ocaml-patch-3.0.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.