Bug 2382067 - Review Request: rust-rand_regex - Generates random strings and byte strings matching a regex
Summary: Review Request: rust-rand_regex - Generates random strings and byte strings m...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2382068
TreeView+ depends on / blocked
 
Reported: 2025-07-19 16:00 UTC by Fabio Valentini
Modified: 2025-09-18 22:11 UTC (History)
2 users (show)

Fixed In Version: rust-rand_regex-0.18.1-1.fc44
Clone Of:
Environment:
Last Closed: 2025-09-18 22:11:32 UTC
Type: ---
Embargoed:
lukasz.wojnilowicz: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2025-07-19 16:00:55 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-rand_regex.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-rand_regex-0.18.1-1.fc42.src.rpm

Description:
Generates random strings and byte strings matching a regex.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2025-07-19 16:00:58 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=134982015

Comment 2 wojnilowicz 2025-08-30 19:42:33 UTC
Package was generated with rust2rpm, simplifying the review.

Patches are justified.

Fedora review returns:
rust-rand_regex.src: W: strange-permission rand_regex-0.18.1.crate 666
rust-rand_regex.src: W: strange-permission rand_regex-fix-metadata.diff 666
rust-rand_regex.src: W: strange-permission rust-rand_regex.spec 666
but for me those files have 644 and not 666 permissions, so maybe something is wrong with the tooling.

===

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (disabled with explanation)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

===

If you have time then please review https://bugzilla.redhat.com/show_bug.cgi?id=2392155 in return.

Comment 3 Fabio Valentini 2025-09-18 20:57:11 UTC
Thank you for the review!

I think the messed up file permissions are a COPR / fedora-review environment problem, the files have normal modes locally.

Comment 4 Fedora Admin user for bugzilla script actions 2025-09-18 20:58:19 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rand_regex

Comment 5 Fabio Valentini 2025-09-18 22:11:32 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-378723a924


Note You need to log in before you can comment on or make changes to this bug.