Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard.spec SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard-1.0~20250722.093515.cb34dee-1.fc42.src.rpm Description: The plasma-keyboard is a virtual keyboard based on Qt Virtual Keyboard designed to integrate in Plasma. Fedora Account System Username: farchord
Taking this review.
Spec review notes: > %find_lang kcm_plasmakeyboard This should be in %install, not %check > %files -f kcm_plasmakeyboard.lang [..] > %{_kf6_qtplugindir}/plasma/kcms/systemsettings/kcm_plasmakeyboard.so [..] > %{_datadir}/applications/kcm_plasmakeyboard.desktop Can we split the KCM out into its own subpackage?
Spec URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard.spec SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard-1.0~20250722.093515.cb34dee-1.fc42.src.rpm - Initial
On that last version, I split the KCM in a subpackage and moved %find_lang as suggested.
> %files -f kcm_plasmakeyboard.lang The "-f kcm_plasmakeyboard.lang" belongs with the kcm subpackage.
The subpackage name for the kcm should be "kcm-%{name}" rather than "%{name}-kcm", so you'll need to do "-n kcm-%{name}" for %package, %description, and %files sections for the subpackage.
Spec URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard.spec SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard-1.0~20250722.093515.cb34dee-1.fc42.src.rpm Moved the lang file over to the kcm subpackage
Spec URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard.spec SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard-1.0~20250722.093515.cb34dee-1.fc42.src.rpm Renamed Subpackage
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9393752 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2383247-plasma-keyboard/fedora-rawhide-x86_64/09393752-plasma-keyboard/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
usr/share/applications/kcm_plasmakeyboard.desktop should be in the kcm subpackage
Spec URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard.spec SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-keyboard/plasma-keyboard-1.0~20250824.094649.6bf37e5-1.fc42.src.rpm Updated to latest commit, moved .desktop file, added new files
Review notes: * Package follows Fedora packaging guidelines * Package licensing is correct and license data is installed correctly * Package builds and installs * No serious rpmlint issues PACKAGE APPROVED.
Thank you for the review, Neal
The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-keyboard