spec: https://fed500.fedorapeople.org/inkscape-silhouette.spec srpm: https://fed500.fedorapeople.org/inkscape-silhouette-1.29-1.fc42.src.rpm description: An application for controlling 2D plotters, cutters, engravers, and CNC machines. fas: fed500 Reproducible: Always
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1971568 bytes in 25 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "Creative Commons Attribution-ShareAlike 3.0", "*No copyright* GNU General Public License, Version 2". 124 files have unknown license. Detailed output of licensecheck in /home/luya/Documents/fedora- review/2383783-inkscape-silhouette/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev/rules.d [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/udev(systemd-udev) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: inkscape-silhouette-1.29-1.fc43.noarch.rpm inkscape-silhouette-1.29-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpaywow16j')] checks: 32, packages: 2 inkscape-silhouette.noarch: W: package-with-huge-docs 86% inkscape-silhouette.noarch: W: only-non-binary-in-usr-lib inkscape-silhouette.noarch: E: non-executable-script /usr/lib/udev/silhouette-udev-notify.sh 644 /bin/sh inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/inkscape/extensions/render_silhouette_regmarks.py inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/inkscape/extensions/silhouette/silhouette/convert2dashes.py inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/licenses/inkscape-silhouette/LICENSE inkscape-silhouette.noarch: E: env-script-interpreter /usr/share/doc/inkscape-silhouette/examples/testcut_sq_tr.py /bin/env python3 2 packages and 0 specfiles checked; 5 errors, 2 warnings, 14 filtered, 5 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 inkscape-silhouette.noarch: W: package-with-huge-docs 86% inkscape-silhouette.noarch: W: only-non-binary-in-usr-lib inkscape-silhouette.noarch: E: non-executable-script /usr/lib/udev/silhouette-udev-notify.sh 644 /bin/sh inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/inkscape/extensions/render_silhouette_regmarks.py inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/inkscape/extensions/silhouette/silhouette/convert2dashes.py inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/licenses/inkscape-silhouette/LICENSE inkscape-silhouette.noarch: E: env-script-interpreter /usr/share/doc/inkscape-silhouette/examples/testcut_sq_tr.py /bin/env python3 1 packages and 0 specfiles checked; 5 errors, 2 warnings, 3 filtered, 5 badness; has taken 0.1 s Source checksums ---------------- https://github.com/fablabnbg/inkscape-silhouette/archive/v1.29/inkscape-silhouette-1.29.tar.gz : CHECKSUM(SHA256) this package : 2fbdf9c8fedff331a87eb4d774359094d9d8628e9b5b3de6a68f25287b532f35 CHECKSUM(SHA256) upstream package : 2fbdf9c8fedff331a87eb4d774359094d9d8628e9b5b3de6a68f25287b532f35 Requires -------- inkscape-silhouette (rpmlib, GLIBC filtered): /usr/bin/python3 inkscape python3dist(cssselect) python3dist(lxml) python3dist(matplotlib) python3dist(numpy) python3dist(pyusb) python3dist(tinycss2) python3dist(xmltodict) Provides -------- inkscape-silhouette: inkscape-silhouette a) Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1971568 bytes in 25 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation b) Rpmlint showed the following error messages: inkscape-silhouette.noarch: E: non-executable-script /usr/lib/udev/silhouette-udev-notify.sh 644 /bin/sh inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/inkscape/extensions/render_silhouette_regmarks.py inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/inkscape/extensions/silhouette/silhouette/convert2dashes.py inkscape-silhouette.noarch: E: incorrect-fsf-address /usr/share/licenses/inkscape-silhouette/LICENSE inkscape-silhouette.noarch: E: env-script-interpreter /usr/share/doc/inkscape-silhouette/examples/testcut_sq_tr.py /bin/env python3 Please fix them.
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9820235 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2383783-inkscape-silhouette/fedora-rawhide-x86_64/09820235-inkscape-silhouette/fedora-review/review.txt Found issues: - Documentation size is 1971568 bytes in 25 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
See comment #1 for fix to do.
Updated. Raised issue for license addresses: https://github.com/fablabnbg/inkscape-silhouette/issues/355 spec: https://fed500.fedorapeople.org/inkscape-silhouette.spec srpm: https://fed500.fedorapeople.org/inkscape-silhouette-1.29-1.fc44.src.rpm
Created attachment 2115794 [details] The .spec file difference from Copr build 9820235 to 9829843
Copr build: https://copr.fedorainfracloud.org/coprs/build/9829843 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2383783-inkscape-silhouette/fedora-rawhide-x86_64/09829843-inkscape-silhouette/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Almost there. python3.patch is unnecessary by replacing it by "sed -i "s|env python|env python3|g" beutil.py convert2dashes.py considering one line. Skipping other lines from review. [x]: License field in the package spec file matches the actual license. Note Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "Creative Commons Attribution-ShareAlike 3.0", "*No copyright* GNU General Public License, Version 2". 124 files have unknown license. Detailed output of licensecheck in /home/luya/Documents/fedora- review/2383783-inkscape-silhouette/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Add "Creative Commons Attribution-ShareAlike 3.0" and mention "sendto_silhouette.py" file.
The file is under either GPL-2.0 or Creative Commons Attribution ShareAlike 3.0 https://github.com/fablabnbg/inkscape-silhouette/blob/main/sendto_silhouette.py#L5 Creative commons licenses are not allowed for code https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ Patches are preferred to sed since if they cannot be applied to later versions, the build will fail. Can use sed if preferred though.
Fair enough. After reviews, we can consider this package as APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/inkscape-silhouette
FEDORA-2025-526739eab5 (inkscape-silhouette-1.29-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-526739eab5
FEDORA-2025-35ea524460 (inkscape-silhouette-1.29-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-35ea524460
Thanks for the review. https://release-monitoring.org/project/387364/
FEDORA-2025-35ea524460 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-35ea524460 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-35ea524460 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-526739eab5 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-526739eab5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-526739eab5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-35ea524460 (inkscape-silhouette-1.29-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-526739eab5 (inkscape-silhouette-1.29-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.