Spec URL: https://mikel.olasagasti.info/tmp/fedora/prometheus.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/prometheus-2.55.1-1.fc42.src.rpm Description: The Prometheus monitoring system and time series database. Fedora Account System Username: mikelo2
It seems to me we already have prometheus in Fedora. Is this package somehow different? https://packages.fedoraproject.org/pkgs/golang-github-prometheus/golang-github-prometheus/
Yes, and I'm currently the maintainer of it. This is an attempt to rename the package, as we (Go-SIG) would like to get rid of the `golang-*` naming schema for vendored packages. The problem with the spec is that it doesn't report bundled npm dependencies (https://matrix.to/#/!IlnthjWRTBDOeOcAVI:fedoraproject.org/$fohVJU2wIIJHdRR8MUVkfBGT1tJmBSNjo2tqGqA1G8g?via=fedoraproject.org&via=fedora.im&via=matrix.org)
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9820237 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2383787-prometheus/fedora-rawhide-x86_64/09820237-prometheus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://mikel.olasagasti.info/tmp/fedora/prometheus.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/prometheus-2.55.1-1.fc43.src.rpm I created a small bash script that would be added to the git repo that reads packages.json and prints the bundled npm modules. The script: https://mikel.olasagasti.info/tmp/fedora/npm-prometheus.sh $ ./npm-prometheus.sh prometheus-2.55.1/web/ui/package.json prometheus-2.55.1/web/ui/react-app/package.json Provides: bundled(nodejs-bootstrap) = 4.6.2 Provides: bundled(nodejs-codemirror-autocomplete) = 6.17.0 Provides: bundled(nodejs-codemirror-commands) = 6.6.0 Provides: bundled(nodejs-codemirror-language) = 6.10.2 Provides: bundled(nodejs-codemirror-lint) = 6.8.1 Provides: bundled(nodejs-codemirror-search) = 6.5.6 Provides: bundled(nodejs-codemirror-state) = 6.3.3 Provides: bundled(nodejs-codemirror-view) = 6.29.1 Provides: bundled(nodejs-css.escape) = 1.5.1 Provides: bundled(nodejs-downshift) = 9.0.6 Provides: bundled(nodejs-forevolve-bootstrap-dark) = 4.0.2 Provides: bundled(nodejs-fortawesome-fontawesome-svg-core) = 6.5.2 Provides: bundled(nodejs-fortawesome-free-solid-svg-icons) = 6.5.2 Provides: bundled(nodejs-fortawesome-react-fontawesome) = 0.2.0 Provides: bundled(nodejs-fsevents) = 2.3.3 Provides: bundled(nodejs-http-proxy-middleware) = 3.0.0 Provides: bundled(nodejs-jquery) = 3.7.1 Provides: bundled(nodejs-jquery.flot.tooltip) = 0.9.0 Provides: bundled(nodejs-lezer-common) = 1.2.1 Provides: bundled(nodejs-lezer-highlight) = 1.2.0 Provides: bundled(nodejs-lezer-lr) = 1.4.2 Provides: bundled(nodejs-moment) = 2.30.1 Provides: bundled(nodejs-moment-timezone) = 0.5.45 Provides: bundled(nodejs-nexucis-fuzzy) = 0.4.1 Provides: bundled(nodejs-nexucis-kvsearch) = 0.8.1 Provides: bundled(nodejs-popper.js) = 1.14.3 Provides: bundled(nodejs-prometheus-io-codemirror-promql) = 0.55.1 Provides: bundled(nodejs-react) = 17.0.2 Provides: bundled(nodejs-react-copy-to-clipboard) = 5.1.0 Provides: bundled(nodejs-react-dom) = 17.0.2 Provides: bundled(nodejs-react-infinite-scroll-component) = 6.1.0 Provides: bundled(nodejs-react-resize-detector) = 7.1.2 Provides: bundled(nodejs-react-router-dom) = 5.3.4 Provides: bundled(nodejs-reactstrap) = 8.10.1 Provides: bundled(nodejs-react-test-renderer) = 17.0.2 Provides: bundled(nodejs-sanitize-html) = 2.13.0 Provides: bundled(nodejs-sass) = 1.77.6 Provides: bundled(nodejs-tempusdominus-bootstrap-4) = 5.39.2 Provides: bundled(nodejs-tempusdominus-core) = 5.19.3 Provides: npm(prometheus-io) = 0.55.1 Provides: npm(prometheus-io-app) = 0.55.1 The script is inspired from /usr/lib/rpm/nodejs.prov As npm modules are not bundled I didn't manage to make nodejs-packaging work autodetecting the used modules.
Created attachment 2117463 [details] The .spec file difference from Copr build 9820237 to 9872726
Copr build: https://copr.fedorainfracloud.org/coprs/build/9872726 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2383787-prometheus/fedora-rawhide-x86_64/09872726-prometheus/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'm pretty sure there's a dependency generator for bundled node dependencies. Is it possible to use that so it doesn't need to be manually updated?
I tried to use it, but was not working for this use case. The script I propose to use is based on /usr/lib/rpm/nodejs.prov that is the script that generates it automatically.
Package was generated with go2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (modulo excluded ones) ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Go Packaging Guidelines ✅ package complies with Nodejs/JavaScript Packaging Guidelines Package APPROVED. === Recommended post-import tasks: - set up package on release-monitoring.org: https://release-monitoring.org/project/6527/ - add @go-sig with "commit" access as package co-maintainer - track package in koschei for all built branches (should happen automatically once go-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/prometheus
FEDORA-2026-ab0cb67c43 (prometheus-2.55.1-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-ab0cb67c43
FEDORA-2026-ab0cb67c43 (prometheus-2.55.1-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.