Spec URL: http://crystalsanctuary.rpgsource.net/packages/specs/kio_p7zip.spec SRPM URL: http://crystalsanctuary.rpgsource.net/packages/source/kio_p7zip-0.3.1-1fc6.src.rpm Description: This is a kioslave for KDE to handle 7zip files.
Just a couple of really minor issues with this package: rpmlint says: W: kio_p7zip wrong-file-end-of-line-encoding /usr/share/doc/kio_p7zip-0.3.1/ChangeLog W: kio_p7zip wrong-file-end-of-line-encoding /usr/share/doc/kio_p7zip-0.3.1/README E: kio_p7zip zero-length /usr/share/doc/kio_p7zip-0.3.1/NEWS Basically, you don't need to package the empty NEWS file. Also, you'll want to use iconv to fix those file encodings: (add this to %install) # Fix file encoding recode() { iconv -f "$2" -t utf-8 < "$1" > "${1}_" mv -f "${1}_" "$1" } recode ChangeLog iso-8859-1 recode README iso-8859-1 Last but not least, I assume the .la files are really needed for KDE? I'm not a KDE user, but if they can be avoided, that would be ideal. Adding Rex to the CC for this, as he'll know. Fix those minor items, show me a new spec/SRPM, and I'll do the rest of the review.
Actually, the files are encoded properly, its just the line endings which are incorrect. You can fix it with just: # Fix end-of-line-encoding sed -i 's/\r//' ChangeLog sed -i 's/\r//' README
Okay, I updated both the spec and source files. Spec URL: http://crystalsanctuary.rpgsource.net/packages/specs/kio_p7zip.spec SRPM URL: http://crystalsanctuary.rpgsource.net/packages/source/kio_p7zip-0.3.1-2fc6.src.rpm
- rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime APPROVED. If your other sponsorship doesn't happen for any reason, lemme know.
> I assume the .la files are really needed for KDE? In most cases, yes.
I didn't notice any problems, but I've taken the line removing the .la files out of the spec just in case. Spec URL: http://crystalsanctuary.rpgsource.net/packages/specs/kio_p7zip.spec SRPM URL: http://crystalsanctuary.rpgsource.net/packages/source/kio_p7zip-0.3.1-3fc6.src.rpm
New Package CVS Request ======================= Package Name: kio_p7zip Short Description: Kio-slave for reading 7zip files Owners: lightsolphoenix Branches: FC-6 InitialCC: lightsolphoenix
cvs done
Package Change Request ====================== Package Name: kio_p7zip New Branches: FC-7
Closing until next release.