Spec URL: https://solomoncyj.fedorapeople.org/reviews/svt-av1-psyex/svt-av1-psyex.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/svt-av1-psyex/svt-av1-psyex-3.0.2~A-1.fc43.src.rpm Description: SVT-AV1-PSY is the Scalable Video Technology for AV1 (SVT-AV1 Encoder and Decoder) with perceptual enhancements for psychovisually optimal AV1 encoding. The goal is to create the best encoding implementation for perceptual quality with AV1. Fedora Account System Username: solomoncyj
> abidiff ./libSvtAv1Enc.so.3 /home/solomoncyj/Downloads/svt-av1-psyex/Bin/Release/libSvtAv1Enc.so.3 --verbose --harmless Compute diff ... diff computed!:0s Computing net changes ... Applying suppressions ... suppressions applied!:0s Marking leaf nodes ... leaf nodes marked!:0s Applying filters and computing diff stats ... in apply_filters_and_compute_diff_stats:applying filters to 0 changed fns ... in apply_filters_and_compute_diff_stats:filters to changed fn applied!:0s in apply_filters_and_compute_diff_stats:applying filters to 0 changed vars ... in apply_filters_and_compute_diff_stats:filters to changed vars applied!:0s in apply_filters_and_compute_diff_stats:applying filters to unreachable types ... in apply_filters_and_compute_diff_stats:filters to unreachable types applied!:0s in apply_filters_and_compute_diff_stats:categorizing redundant changed sub nodes ... in apply_filters_and_compute_diff_stats:redundant changed sub nodes categorized!:0s in apply_filters_and_compute_diff_stats:count changed fns ... in apply_filters_and_compute_diff_stats:changed fn counted!:0s in apply_filters_and_compute_diff_stats:count changed vars ... in apply_filters_and_compute_diff_stats:changed vars counted!:0s in apply_filters_and_compute_diff_stats:count leaf changed types ... in apply_filters_and_compute_diff_stats:changed leaf types counted!:0s in apply_filters_and_compute_diff_stats:count leaf changed artefacts ... in apply_filters_and_compute_diff_stats:changed leaf artefacts counted!:0s in apply_filters_and_compute_diff_stats:count unreachable types ... in apply_filters_and_compute_diff_stats:unreachable types counted!:0s Filters applied and diff stats computed!: 0s net changes computed!: 0s Computing incompatible changes ... Computing changes ... changes computed!: 0s Computing report ... Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable Function symbols changes summary: 0 Removed, 1 Added function symbol not referenced by debug info Variable symbols changes summary: 0 Removed, 0 Added variable symbol not referenced by debug info 1 Added function symbol not referenced by debug info: [A] svt_psy_get_version Report computed!:0s > abidiff ./SvtAv1EncApp /home/solomoncyj/Downloads/svt-av1-psyex/Bin/Release/\SvtAv1EncApp --verbose --harmless Compute diff ... diff computed!:0s Computing net changes ... Applying suppressions ... suppressions applied!:0s Marking leaf nodes ... leaf nodes marked!:0s Applying filters and computing diff stats ... in apply_filters_and_compute_diff_stats:applying filters to 0 changed fns ... in apply_filters_and_compute_diff_stats:filters to changed fn applied!:0s in apply_filters_and_compute_diff_stats:applying filters to 0 changed vars ... in apply_filters_and_compute_diff_stats:filters to changed vars applied!:0s in apply_filters_and_compute_diff_stats:applying filters to unreachable types ... in apply_filters_and_compute_diff_stats:filters to unreachable types applied!:0s in apply_filters_and_compute_diff_stats:categorizing redundant changed sub nodes ... in apply_filters_and_compute_diff_stats:redundant changed sub nodes categorized!:0s in apply_filters_and_compute_diff_stats:count changed fns ... in apply_filters_and_compute_diff_stats:changed fn counted!:0s in apply_filters_and_compute_diff_stats:count changed vars ... in apply_filters_and_compute_diff_stats:changed vars counted!:0s in apply_filters_and_compute_diff_stats:count leaf changed types ... in apply_filters_and_compute_diff_stats:changed leaf types counted!:0s in apply_filters_and_compute_diff_stats:count leaf changed artefacts ... in apply_filters_and_compute_diff_stats:changed leaf artefacts counted!:0s in apply_filters_and_compute_diff_stats:count unreachable types ... in apply_filters_and_compute_diff_stats:unreachable types counted!:0s Filters applied and diff stats computed!: 0s Computing incompatible changes ... Computing changes ...
Why are the devel files not packaged? Is it worth packaging some of the documentation?
Devel files are not pa kage as the base svt-av1 devel files can be used. This package mantains ABI compatibility with the base pavkage and only aims to provide a superset of fetures that can be invoked with exsisting ABI interfaces
There will be a conflicts for %{_bindir}/SvtAv1EncApp %{_mandir}/man1/SvtAv1EncApp.1* https://src.fedoraproject.org/rpms/svt-av1/blob/rawhide/f/svt-av1.spec Maybe environment modules are a solution: https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/
user is expected to use `dnf swap`, like for ffmpeg in rpmfusion and ffmpeg-free
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9820248 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386111-svt-av1-psyex/fedora-rawhide-x86_64/09820248-svt-av1-psyex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.