Spec URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon.spec SRPM URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon-1.15-1.fc42.src.rpm Description: Aeidon is a library for reading, writing and manipulating text-based subtitle files. Fedora Account System Username: sshil Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=135724564
Spec URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon.spec SRPM URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon-1.15-2.fc42.src.rpm - Switched to pyproject macros and Stopped deleting the gaupol.dist-info directory to ensure metadata is preserved Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=135734832
Copr build: https://copr.fedorainfracloud.org/coprs/build/9379755 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386523-python-aeidon/fedora-rawhide-x86_64/09379755-python-aeidon/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2102768 [details] The .spec file difference from Copr build 9379755 to 9379766
Copr build: https://copr.fedorainfracloud.org/coprs/build/9379766 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386523-python-aeidon/fedora-rawhide-x86_64/09379766-python-aeidon/fedora-review/review.txt Found issues: - License file AUTHORS.md is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This package is already provided by gaupol package so we cannot add this as a separate package. Or explain here why new package is need to be created here?
To work with subtitles, translate-toolkit need aeidon library and aeidon is only available as part of the gaupol package, installing translate-toolkit forced the system to also install the full gaupol package and all gui dependencies like gtk. gaupol was an orphaned package in Fedora. I took it now for little time. after creating aeidon as new fedora package, i'll orphan the gaupol again.
we need to update gaupol package as well to remove python3-aeidon subpackage. Can you first prepare PR against gaupol package to remove it? Once you prepare PR, we can review this package and once this package is reviewed and built in rawhide, at same time merge that PR and build gaupol package in rawhide. Otherwise both packages will keep providing same binary package python3-aeidon.
Here is what I worked on gaupol.spec as https://pnemade.fedorapeople.org/fedora-work/SPECS/gaupol.spec
This package needs some fixes 1) rpmlint complains python-aeidon.noarch: E: description-line-too-long Aeidon is a library for reading, writing and manipulating text-based subtitle files. 2) As you are splitting this package from gaupol, let's use release tag as 23 instead of 2 Release: 23%{?dist} 3) subpackage name should be python3-aeidon not python-aeidon 4) I think we don't need below line in %files %{python3_sitelib}/gaupol-%{version}.dist-info/
created mr for gaupol to remove aeidon subpackage and updated pyproject https://src.fedoraproject.org/rpms/gaupol/pull-request/4 after mr is merged, I'll proceed creating new fedora package for python3-aeidon
upstream aeidon tarball has gaupol. should we still use that tarball from pypi ? sshil@fedora:~/sudip/python-aeidon$ ls aeidon-1.15 aeidon AUTHORS.md COPYING doc gaupol manifests PKG-INFO README.aeidon.md setup-aeidon.py setup.py aeidon.egg-info bin data flatpak Makefile NEWS.md po README.md setup.cfg tools also about removing %{python3_sitelib}/gaupol-%{version}.dist-info/ causing an error. upstream setup.py script from this tarball actually creates the metadata directory with the name gaupol-%{version}.dist-info during the %install ``` error: Installed (but unpackaged) file(s) found: /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/INSTALLER /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/METADATA /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/WHEEL /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/licenses/AUTHORS.md /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/licenses/COPYING /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/top_level.txt Installed (but unpackaged) file(s) found: /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/INSTALLER /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/METADATA /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/WHEEL /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/licenses/AUTHORS.md /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/licenses/COPYING /usr/lib/python3.14/site-packages/gaupol-1.15.dist-info/top_level.txt ```
(In reply to Sudip Shil from comment #11) > upstream aeidon tarball has gaupol. should we still use that tarball from > pypi ? which other tarball we can use here?
means if we could modify this tarball.
Spec URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon.spec SRPM URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon-1.15-23.fc42.src.rpm - Initial packaging from official PyPI source
Created attachment 2104168 [details] The .spec file difference from Copr build 9379766 to 9450234
Copr build: https://copr.fedorainfracloud.org/coprs/build/9450234 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386523-python-aeidon/fedora-rawhide-x86_64/09450234-python-aeidon/fedora-review/review.txt Found issues: - License file AUTHORS.md is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Still missing few things 1) in %prep section add rm -rf .egg-info 2) add in SPEC above %prep line generate_buildrequires %pyproject_buildrequires 3) Remove any BuildRequires: and Requires: line first and add only BuildRequires: pyproject-rpm-macros BuildRequires: gettext 4) I suggest adding below BuildRequires line Obsoletes: python3-aeidon < 1.15-23 5) in %install section before removal lines add explanation why removing installed files like # As this package is split from gaupol, we don't # need gaupol package related files to be installed Update the SPEC and SRPM
Spec URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon.spec SRPM URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon-1.15-23.fc42.src.rpm - Initial packaging from official PyPI source Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=136451758
Created attachment 2104855 [details] The .spec file difference from Copr build 9450234 to 9491629
Copr build: https://copr.fedorainfracloud.org/coprs/build/9491629 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386523-python-aeidon/fedora-rawhide-x86_64/09491629-python-aeidon/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good now. One thing I found after running fedora-review on latest SRPM 1) I got confused by this guideline https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_time_dependency_on_python3_devel but looks like you need to change below line in SPEC BuildRequires: pyproject-rpm-macros to BuildRequires: python3-devel APPROVED.
Spec URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon.spec SRPM URL: https://sshil.fedorapeople.org/reviews/python-aeidon/python-aeidon-1.15-23.fc42.src.rpm - Initial packaging from official PyPI source Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=136507221
Thank you for the update. You can build gaupol first and then this package in rawhide now.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aeidon
FEDORA-2025-194c843ae2 (python-aeidon-1.15-23.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-194c843ae2
FEDORA-2025-9d0d6c2257 (python-aeidon-1.15-23.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-9d0d6c2257
FEDORA-2025-b59a069366 (python-aeidon-1.15-23.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b59a069366
FEDORA-2025-ef096d9145 (gaupol-1.15-23.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ef096d9145
FEDORA-2025-194c843ae2 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-194c843ae2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-194c843ae2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-ef096d9145 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ef096d9145` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ef096d9145 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-eb031e91f9 (gaupol-1.15-24.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-eb031e91f9
FEDORA-2025-eb031e91f9 (gaupol-1.15-24.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-f1f2cf95c2 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f1f2cf95c2` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f1f2cf95c2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.