Spec URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh-26.18.0-1.fc43.src.rpm Description: The most customisable and low-latency cross platform/shell prompt renderer. Fedora Account System Username: solomoncyj
``` # crashing build due to file not found # % license vendor/modules.txt ``` Replace this with `%license src/vendor/modules.txt`.
> %gotest This should be `%gotest ./...`, I think
Spec URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh-26.18.0-1.fc42.src.rpm - Uncommitted changes
Copr build: https://copr.fedorainfracloud.org/coprs/build/9379855 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386724-oh-my-posh/fedora-rawhide-x86_64/09379855-oh-my-posh/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2102769 [details] The .spec file difference from Copr build 9379779 to 9379855
Copr build: https://copr.fedorainfracloud.org/coprs/build/9379779 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386724-oh-my-posh/fedora-rawhide-x86_64/09379779-oh-my-posh/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh-26.18.0-1.fc42.src.rpm fixed tests
Created attachment 2103145 [details] The .spec file difference from Copr build 9379855 to 9395094
Copr build: https://copr.fedorainfracloud.org/coprs/build/9395094 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386724-oh-my-posh/fedora-rawhide-x86_64/09395094-oh-my-posh/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
You're missing the following: -X github.com/jandedobbeleer/oh-my-posh/src/build.Version={{ .Version }} -X github.com/jandedobbeleer/oh-my-posh/src/build.Date={{ .Date }} $ oh-my-posh --version 0.0.0-dev Add this after the gomodulesmode: export GO_LDFLAGS="-X github.com/jandedobbeleer/oh-my-posh/src/build.Version=%{version} \ -X github.com/jandedobbeleer/oh-my-posh/src/build.Date=$(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d) - Remove the following: > # crashing build due to file not found - Is this provide required? Rest of distributions name it `oh-my-posh` and I see no reference for `ohmyposh`. > Provides: ohmyposh = %{version}-%{release} > #alias Extra non-required things: - Do you plan to package Nerd Fonts? - shell completions are disabled after this patch https://github.com/JanDeDobbeleer/oh-my-posh/pull/6122/commits/64bd60dc069caeaf434621dbd680b3d05cdf55e8 but as they're provided by Cobra directly maybe they can be included in the package as downstream feature. - Is there any way to disable the upgrade module with a default config or buildtag? Chezmoi can do this with a `noupgrade` buildtag for example: https://www.chezmoi.io/developer-guide/packaging/
Created attachment 2105073 [details] The .spec file difference from Copr build 9395094 to 9498148
Copr build: https://copr.fedorainfracloud.org/coprs/build/9498148 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2386724-oh-my-posh/fedora-rawhide-x86_64/09498148-oh-my-posh/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.GFEco7 > + umask 022 > + cd /builddir/build/BUILD/oh-my-posh-26.18.0-build > + cd oh-my-posh-26.18.0 > /var/tmp/rpm-tmp.GFEco7: line 54: unexpected EOF while looking for matching `)' > error: Bad exit status from /var/tmp/rpm-tmp.GFEco7 (%build) You need to close GO_LDFLAGS definition, you're missing the last ". export GO_LDFLAGS="-X github.com/jandedobbeleer/oh-my-posh/src/build.Version=%{version} \ -X github.com/jandedobbeleer/oh-my-posh/src/build.Date=$(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d"
Spec URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/oh-my-posh/oh-my-posh-26.18.0-1.fc44.src.rpm - Uncommitted changes
Sorry, didn't realize also that `date` misses the closing parenthesis: export GO_LDFLAGS="-X github.com/jandedobbeleer/oh-my-posh/src/build.Version=%{version} \ -X github.com/jandedobbeleer/oh-my-posh/src/build.Date=$(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d)"
[fedora-review-service-build]
Golang Package Review ============== This package was generated using go2rpm and Go Vendor Tools, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [X] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [X] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance. Check this config as example: https://src.fedoraproject.org/rpms/docker-compose/pull-request/18 Thanks!
Thank you for the review, Mikel
The Pagure repository was created at https://src.fedoraproject.org/rpms/oh-my-posh