Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09396456-greenboot-rs/greenboot-rs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09396456-greenboot-rs/greenboot-rs-0.16.0-0.fc42.src.rpm Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
Copr build: https://copr.fedorainfracloud.org/coprs/build/9396583 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2387553-greenboot-rs/fedora-rawhide-x86_64/09396583-greenboot-rs/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'LGPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09396743-greenboot-rs/greenboot-rs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09396743-greenboot-rs/greenboot-rs-0.16.0-2.fc42.src.rpm Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
Created attachment 2103240 [details] The .spec file difference from Copr build 9396583 to 9396750
Copr build: https://copr.fedorainfracloud.org/coprs/build/9396750 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2387553-greenboot-rs/fedora-rawhide-x86_64/09396750-greenboot-rs/fedora-review/review.txt Found issues: - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
``` Found issues: - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets ``` necessary: %post,%preun, %postuns is used correctly
I'll review this.
Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09404142-greenboot-rs/greenboot-rs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09404142-greenboot-rs/greenboot-rs-0.16.0-2.fc42.src.rpm Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
Created attachment 2103349 [details] The .spec file difference from Copr build 9396750 to 9404787
Copr build: https://copr.fedorainfracloud.org/coprs/build/9404787 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2387553-greenboot-rs/fedora-rawhide-x86_64/09404787-greenboot-rs/fedora-review/review.txt Found issues: - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09440071-greenboot-rs/greenboot-rs-0.16.0-025b6e4.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09440071-greenboot-rs/greenboot-rs-0.16.0-3.fc42.src.rpm Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
Copr build: https://copr.fedorainfracloud.org/coprs/build/9440137 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2387553-greenboot-rs/fedora-rawhide-x86_64/09440137-greenboot-rs/fedora-review/review.txt Found issues: - greenboot-rs-0.16.0-025b6e4.spec should be greenboot-rs.spec Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Reviewing. Looking at the output of the copr bit there's few minor bits that need fixing, the main one is the spec file name, I am presuming that is for review (it should here be the proper one for future reference).
> Found issues: > > - greenboot-rs-0.16.0-025b6e4.spec should be greenboot-rs.spec > Read more: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming > - Systemd service file(s) in greenboot, greenboot-default-health-checks > Read more: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/ > #_scriptlets These two issues ^^^ need to be double checked, else all the rest looks fine.
Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09448067-greenboot-rs/greenboot-rs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedora-42-x86_64/09448067-greenboot-rs/greenboot-rs-0.16.0-3.fc42.src.rpm Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
> > Found issues: > > > > - greenboot-rs-0.16.0-025b6e4.spec should be greenboot-rs.spec > > Read more: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming Fixed in last build:https://bugzilla.redhat.com/show_bug.cgi?id=2387553#c14 > > - Systemd service file(s) in greenboot, greenboot-default-health-checks > > Read more: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/ > > #_scriptlets greenboot has the required scriptlets, greenboot-default-health-checks does not require any scriptlets as it installs only the health check scripts.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9448121 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2387553-greenboot-rs/fedora-rawhide-x86_64/09448121-greenboot-rs/fedora-review/review.txt Found issues: - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
LGTM Approved!
The Pagure repository was created at https://src.fedoraproject.org/rpms/greenboot-rs
There's quite a few things from a Rust packaging POV that aren't really up to date in this spec file, it probably shouldn't have been approved as-is. I offered help with the packaging side of things in the discussion thread for the Change proposal, but I don't think anybody has reached out to the Rust SIG?
discussed and identified the the missing best practices, will push the changes shortly.
Fixes addressed in: 0.16.0-3