Spec URL: https://yselkowitz.fedorapeople.org/mjpegtools.spec SRPM URL: https://yselkowitz.fedorapeople.org/mjpegtools-2.2.1-10.fc43.src.rpm Description: The mjpeg programs are a set of tools that can do recording of videos and playback, simple cut-and-paste editing and the MPEG compression of audio and video under Linux. (This will become a dependency of gstreamer1-plugins-bad-free-extras.) Fedora Account System Username: yselkowitz
Copr build: https://copr.fedorainfracloud.org/coprs/build/9399354 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2387676-mjpegtools/fedora-rawhide-x86_64/09399354-mjpegtools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
1. Is there a good reason to use `-f` in the `rm` calls below? I'm wary of `rm -f` because it hides errors. ... rm -f %{buildroot}%{_infodir}/dir %if 0%{?rhel} && 0%{?rhel} < 10 rm -f %{buildroot}%{_libdir}/*.la %endif # too broken/outdated to be useful in 1.[89].0 (and would come with dep chain) rm -f %{buildroot}%{_bindir}/mpegtranscode # requires mencoder rm -f %{buildroot}%{_bindir}/lav2avi.sh ... 2. You should patch lavtc.sh to avoid pointing to /usr/local/bin and rely on $PATH, like Debian does: https://sources.debian.org/patches/mjpegtools/1:2.1.0+debian-8.1/10_usr_local.patch/ LGTM otherwise.
Apart from the above, which can be fixed upon import, some notes: 3. Debian has a patch for this: ... %configure LIBS="-lpthread" \ ... https://sources.debian.org/patches/mjpegtools/1:2.1.0+debian-8.1/06_link_pthread.patch/ 4. The GUI applications are so ancient it probably makes no sense to require .desktop files for them. 5. Likewise, it's probably not worth the effort to modernize the ancient m4 macros used in configure script. Package APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "FSF All Permissive License", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2 [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License", "GNU General Public License", "*No copyright* GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU General Public License v2.0 or later". 204 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/mjpegtools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 21302 bytes in 7 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mjpegtools-libs , mjpegtools-lav , mjpegtools-devel , mjpegtools-lav- devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mjpegtools-2.2.1-10.fc43.x86_64.rpm mjpegtools-gui-2.2.1-10.fc43.x86_64.rpm mjpegtools-libs-2.2.1-10.fc43.x86_64.rpm mjpegtools-lav-2.2.1-10.fc43.x86_64.rpm mjpegtools-devel-2.2.1-10.fc43.x86_64.rpm mjpegtools-lav-devel-2.2.1-10.fc43.x86_64.rpm mjpegtools-2.2.1-10.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgx7udg5_')] checks: 32, packages: 7 mjpegtools-lav.x86_64: E: spelling-error ('lavpipe', 'Summary(en_US) lavpipe -> lav pipe, lav-pipe, tailpipe') mjpegtools-lav-devel.x86_64: E: spelling-error ('lavpipe', 'Summary(en_US) lavpipe -> lav pipe, lav-pipe, tailpipe') mjpegtools-lav-devel.x86_64: E: spelling-error ('lavpipe', '%description -l en_US lavpipe -> lav pipe, lav-pipe, tailpipe') mjpegtools.x86_64: W: no-manual-page-for-binary anytovcd.sh mjpegtools.x86_64: W: no-manual-page-for-binary lavaddwav mjpegtools.x86_64: W: no-manual-page-for-binary lavinfo mjpegtools.x86_64: W: no-manual-page-for-binary lavtc.sh mjpegtools.x86_64: W: no-manual-page-for-binary matteblend.flt mjpegtools.x86_64: W: no-manual-page-for-binary mjpeg_simd_helper mjpegtools.x86_64: W: no-manual-page-for-binary multiblend.flt mjpegtools.x86_64: W: no-manual-page-for-binary qttoy4m mjpegtools.x86_64: W: no-manual-page-for-binary transist.flt mjpegtools.x86_64: W: no-manual-page-for-binary y4mblack mjpegtools.x86_64: W: no-manual-page-for-binary y4minterlace mjpegtools.x86_64: W: no-manual-page-for-binary y4mivtc mjpegtools.x86_64: W: no-manual-page-for-binary y4mshift mjpegtools.x86_64: W: no-manual-page-for-binary y4mspatialfilter mjpegtools.x86_64: W: no-manual-page-for-binary y4mstabilizer mjpegtools.x86_64: W: no-manual-page-for-binary y4mtoqt mjpegtools.x86_64: W: no-manual-page-for-binary y4mtoyuv mjpegtools.x86_64: W: no-manual-page-for-binary ypipe mjpegtools.x86_64: W: no-manual-page-for-binary yuvcorrect mjpegtools.x86_64: W: no-manual-page-for-binary yuvcorrect_tune mjpegtools.x86_64: W: no-manual-page-for-binary yuvdeinterlace mjpegtools.x86_64: W: no-manual-page-for-binary yuyvtoy4m mjpegtools-gui.x86_64: W: no-manual-page-for-binary glav mjpegtools-gui.x86_64: W: no-manual-page-for-binary y4mhist mjpegtools-devel.x86_64: W: no-documentation mjpegtools-lav.x86_64: W: no-documentation mjpegtools-lav-devel.x86_64: W: no-documentation mjpegtools.spec: W: no-%check-section mjpegtools.x86_64: E: incorrect-fsf-address /usr/bin/anytovcd.sh mjpegtools.x86_64: E: incorrect-fsf-address /usr/bin/lavtc.sh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/audiolib.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/avilib.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/editlist.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/format_codes.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/jpegutils.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mjpeg_logging.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mjpeg_types.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/motionsearch.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/elemstrmwriter.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/encodertypes.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/imageplanes.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/macroblock.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/mpeg2coder.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/mpeg2encoder.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/mpeg2encoptions.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/mpeg2encparams.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/ontheflyratectlpass1.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/ontheflyratectlpass2.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/picture.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/picturereader.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/predict_ref.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/quantize.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/quantize_ref.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/ratectl.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/seqencoder.hh mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/streamstate.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpeg2enc/syntaxconsts.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpegconsts.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mpegtimecode.h mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/audiostrm.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/decodebufmodel.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/inputstrm.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/interact.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/outputstrm.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/padstrm.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/stillsstream.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/stream_params.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/systems.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/mplex/videostrm.hpp mjpegtools-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/yuv4mpeg.h mjpegtools-lav-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/lav_io.h mjpegtools-lav-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/liblavplay.h mjpegtools-lav-devel.x86_64: E: incorrect-fsf-address /usr/include/mjpegtools/liblavrec.h mjpegtools-libs.x86_64: E: incorrect-fsf-address /usr/share/licenses/mjpegtools-libs/COPYING mjpegtools.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/14/c0349b7af26ba1822cf95e49462a20d2c9fb69 ../../../../usr/bin/yuvplay mjpegtools.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/16/b620996c7e8fb018aaafc79c1371673fe8dff1 ../../../../usr/bin/glav mjpegtools.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/1e/760c625efaf42864390cf419692ca12d22f588 ../../../../usr/bin/y4mhist mjpegtools.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/46/9afb6b66409af7b4553a0a00276d1c17e3f5bc ../../../../usr/bin/lavplay 7 packages and 0 specfiles checked; 49 errors, 32 warnings, 59 filtered, 49 badness; has taken 1.6 s Rpmlint (debuginfo) ------------------- Checking: mjpegtools-lav-debuginfo-2.2.1-10.fc43.x86_64.rpm mjpegtools-libs-debuginfo-2.2.1-10.fc43.x86_64.rpm mjpegtools-gui-debuginfo-2.2.1-10.fc43.x86_64.rpm mjpegtools-debuginfo-2.2.1-10.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn80r91o9')] checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 141 filtered, 0 badness; has taken 1.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "mjpegtools-libs-debuginfo". (none): E: there is no installed rpm "mjpegtools-gui-debuginfo". (none): E: there is no installed rpm "mjpegtools-devel". (none): E: there is no installed rpm "mjpegtools-debuginfo". (none): E: there is no installed rpm "mjpegtools-libs". (none): E: there is no installed rpm "mjpegtools-lav-devel". (none): E: there is no installed rpm "mjpegtools". (none): E: there is no installed rpm "mjpegtools-lav". (none): E: there is no installed rpm "mjpegtools-lav-debuginfo". (none): E: there is no installed rpm "mjpegtools-gui". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 10 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://downloads.sourceforge.net/mjpeg/mjpegtools/2.2.1/mjpegtools-2.2.1.tar.gz : CHECKSUM(SHA256) this package : b180536d7d9960b05e0023a197b00dcb100929a49aab71d19d55f4a1b210f49a CHECKSUM(SHA256) upstream package : b180536d7d9960b05e0023a197b00dcb100929a49aab71d19d55f4a1b210f49a Requires -------- mjpegtools (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/sh ffmpeg-free(x86-64) libc.so.6()(64bit) libdv.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblavfile-2.2.so.0()(64bit) liblavjpeg-2.2.so.0()(64bit) libm.so.6()(64bit) libmjpegutils-2.2.so.0()(64bit) libmpeg2encpp-2.2.so.0()(64bit) libmplex2-2.2.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libquicktime.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) mjpegtools-lav(x86-64) mjpegtools-libs(x86-64) rtld(GNU_HASH) which mjpegtools-gui (rpmlib, GLIBC filtered): libSDL-1.2.so.0()(64bit) libSDL_gfx.so.15()(64bit) libc.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) liblavplay-2.2.so.0()(64bit) libm.so.6()(64bit) libmjpegutils-2.2.so.0()(64bit) mjpegtools(x86-64) rtld(GNU_HASH) mjpegtools-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmjpegutils-2.2.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) mjpegtools-lav (rpmlib, GLIBC filtered): libSDL-1.2.so.0()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libdv.so.4()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblavfile-2.2.so.0()(64bit) liblavjpeg-2.2.so.0()(64bit) libm.so.6()(64bit) libmjpegutils-2.2.so.0()(64bit) libquicktime.so.0()(64bit) libz.so.1()(64bit) mjpegtools-libs(x86-64) rtld(GNU_HASH) mjpegtools-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libmjpegutils-2.2.so.0()(64bit) libmpeg2encpp-2.2.so.0()(64bit) libmplex2-2.2.so.0()(64bit) mjpegtools-libs(x86-64) mjpegtools-lav-devel (rpmlib, GLIBC filtered): liblavfile-2.2.so.0()(64bit) liblavjpeg-2.2.so.0()(64bit) liblavplay-2.2.so.0()(64bit) mjpegtools-devel(x86-64) mjpegtools-lav(x86-64) Provides -------- mjpegtools: mjpegtools mjpegtools(x86-64) mjpegtools-gui: mjpegtools-gui mjpegtools-gui(x86-64) mjpegtools-libs: libmjpegutils-2.2.so.0()(64bit) libmpeg2encpp-2.2.so.0()(64bit) libmplex2-2.2.so.0()(64bit) mjpegtools-libs mjpegtools-libs(x86-64) mjpegtools-lav: liblavfile-2.2.so.0()(64bit) liblavjpeg-2.2.so.0()(64bit) liblavplay-2.2.so.0()(64bit) mjpegtools-lav mjpegtools-lav(x86-64) mjpegtools-devel: mjpegtools-devel mjpegtools-devel(x86-64) pkgconfig(mjpegtools) mjpegtools-lav-devel: mjpegtools-lav-devel mjpegtools-lav-devel(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: mjpegtools-2.2.1-build/mjpegtools-2.2.1/configure.ac:73 AM_PROG_CC_STDC found in: mjpegtools-2.2.1-build/mjpegtools-2.2.1/configure.ac:81 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mjpegtools --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: SugarActivity, PHP, Java, Perl, Haskell, fonts, Python, Ocaml, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/mjpegtools
(In reply to Dominik 'Rathann' Mierzejewski from comment #2) > 1. Is there a good reason to use `-f` in the `rm` calls below? I'm wary of `rm -f` because it hides errors. e.g. if a future BRP would automate the removal of %_infodir/dir, there's no reason for that to trigger an error. (TBH I'm surprised such doesn't already exist.) > 2. You should patch lavtc.sh to avoid pointing to /usr/local/bin and rely on > $PATH, like Debian does: > https://sources.debian.org/patches/mjpegtools/1:2.1.0+debian-8.1/ > 10_usr_local.patch/ Added. > 3. Debian has a patch for this: > ... > %configure LIBS="-lpthread" \ > ... > https://sources.debian.org/patches/mjpegtools/1:2.1.0+debian-8.1/ > 06_link_pthread.patch/ This patch doesn't seem to make much sense, particularly nowadays in light of https://developers.redhat.com/articles/2021/12/17/why-glibc-234-removed-libpthread > 4. The GUI applications are so ancient it probably makes no sense to require > .desktop files for them. They are designed to be launched from the command line, so desktop files wouldn't help much. > 5. Likewise, it's probably not worth the effort to modernize the ancient m4 > macros used in configure script. Agreed. > Package APPROVED. Thanks for the review; waiting on branching to complete to add it.