Bug 2387827 - Review Request: perl-Crypt-SysRandom - Perl interface to system randomness
Summary: Review Request: perl-Crypt-SysRandom - Perl interface to system randomness
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL: https://metacpan.org/dist/Crypt-SysRa...
Whiteboard:
Depends On: 2387789
Blocks: 2383699 2383706 2389855
TreeView+ depends on / blocked
 
Reported: 2025-08-12 13:25 UTC by Jitka Plesnikova
Modified: 2025-09-12 19:24 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-09-07 00:51:34 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2025-08-12 13:25:21 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Crypt-SysRandom/perl-Crypt-SysRandom.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Crypt-SysRandom/perl-Crypt-SysRandom-0.007-1.fc43.src.rpm

Description:
This module uses whatever interface is available to procure
cryptographically random data from the system.

Fedora Account System Username: jplesnik

Comment 1 Fedora Review Service 2025-08-12 13:27:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9405009
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2387827-perl-crypt-sysrandom/fedora-rawhide-x86_64/09405009-perl-Crypt-SysRandom/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Petr Pisar 2025-08-29 11:44:06 UTC
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA-512 75d5d89e8d883560f24f4f617afbb57f8953c6f7b96c4934ff8a7d2251ffddffe372ee8b5411011cb4eae0e7d19d4a44dd8414146c50d6bdc9b489ba8a4a23a6) is original. Ok.
Summary and description verified in lib/Crypt/SysRandom.pm. Ok.
License verified from lib/Crypt/SysRandom.pm, LICENSE, and README. Ok.
No XS code, noarch BuildArch is Ok.
Win32::API is not used. Ok.
Build-requires are Ok.

$ rpmlint perl-Crypt-SysRandom.spec ../SRPMS/perl-Crypt-SysRandom-0.007-1.fc44.src.rpm ../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Crypt-SysRandom.noarch: E: spelling-error ('cryptographically', '%description -l en_US cryptographically -> photographically, typographically, topographically')
perl-Crypt-SysRandom.src: E: spelling-error ('cryptographically', '%description -l en_US cryptographically -> photographically, typographically, topographically')
perl-Crypt-SysRandom.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Crypt-SysRandom/LICENSE
=== 2 packages and 1 specfiles checked; 3 errors, 0 warnings, 6 filtered, 3 badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q -lv -p  ../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Aug 11 02:00 /usr/share/doc/perl-Crypt-SysRandom
-rw-r--r--    1 root     root                      745 Feb  5  2025 /usr/share/doc/perl-Crypt-SysRandom/Changes
-rw-r--r--    1 root     root                      375 Feb  5  2025 /usr/share/doc/perl-Crypt-SysRandom/README
drwxr-xr-x    2 root     root                        0 Aug 11 02:00 /usr/share/licenses/perl-Crypt-SysRandom
-rw-r--r--    1 root     root                    19744 Feb  5  2025 /usr/share/licenses/perl-Crypt-SysRandom/LICENSE
-rw-r--r--    1 root     root                     1374 Aug 11 02:00 /usr/share/man/man3/Crypt::SysRandom.3pm.gz
drwxr-xr-x    2 root     root                        0 Aug 11 02:00 /usr/share/perl5/vendor_perl/Crypt
-rw-r--r--    1 root     root                     2388 Feb  5  2025 /usr/share/perl5/vendor_perl/Crypt/SysRandom.pm
File layout and permissions are Ok.

$ rpm -q --requires -p  ../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm | sort -f | uniq -c
      1 perl(Carp)
      1 perl(Crypt::SysRandom::XS)
      1 perl(Errno)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p  ../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm | sort -f | uniq -c
      1 perl(Crypt::SysRandom) = 0.007
      1 perl-Crypt-SysRandom = 0.007-1.fc44
Binary privides are Ok.

$ resolvedeps f44-build ../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 44 (https://koji.fedoraproject.org/koji/taskinfo?taskID=136532156). Ok.

This package is in line with Fedora and Perl packaging guidelines.
This package is APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2025-08-29 12:30:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Crypt-SysRandom

Comment 4 Fedora Update System 2025-08-29 13:20:01 UTC
FEDORA-2025-bc9710b83f (perl-Crypt-SysRandom-0.007-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-bc9710b83f

Comment 5 Fedora Update System 2025-08-30 01:11:12 UTC
FEDORA-2025-4573b22206 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-4573b22206`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-4573b22206

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2025-08-30 02:01:33 UTC
FEDORA-2025-bc9710b83f has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-bc9710b83f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-bc9710b83f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2025-09-07 00:51:34 UTC
FEDORA-2025-bc9710b83f (perl-Crypt-SysRandom-0.007-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-09-12 19:24:03 UTC
FEDORA-2025-4573b22206 (perl-Crypt-SysRandom-0.007-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.