Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://v02460.fedorapeople.org/rust-icu_segmenter.spec SRPM URL: https://v02460.fedorapeople.org/rust-icu_segmenter-2.0.0-1.fc43.src.rpm Description: Unicode line breaking and text segmentation algorithms for text boundaries analysis. Fedora Account System Username: v02460
Copr build: https://copr.fedorainfracloud.org/coprs/build/9406041 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388110-rust-icu_segmenter/fedora-rawhide-x86_64/09406041-rust-icu_segmenter/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Kai, Since I brought in most of the currently-packaged subset of the ICU4X stack in Fedora, I’m planning to help with these reviews – to the extent I have time – and with ongoing maintenance. I’m very happy to have someone else working on ICU4X. I’m curious: what is your end goal? What is rust-icu_segmenter a dependency for? – Ben Beasley (FAS: music)
(In reply to Ben Beasley from comment #2) > I’m curious: what is your end goal? What is rust-icu_segmenter a dependency for? I suspect the answer is that you need it for matrix-synapse due to https://github.com/element-hq/synapse/commit/be4c95baf11f16a6108da5b73f7140d36de6f55d. That makes sense.
Hi Ben, thank you for your time and the reviews! You are correct, I started working on rust-icu_segmenter for matrix-synapse. I’ll make sure to add you as co-maintainer to these packages.
(In reply to Kai A. Hiller from comment #4) > Hi Ben, thank you for your time and the reviews! You’re welcome! ---- As with bug 2388113, the Cargo.toml metadata patch should have an explanatory comment of some sort (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment), even though it is nearly self-explanatory, and it should be possible to run a few of the tests. Also, the Summary is more than 80 characters, so you should override it manually in rust2rpm.toml. Something like the following should work. rust2rpm.toml: [package] summary = "Unicode line breaking and text segmentation algorithms" cargo-toml-patch-comments = [ "Omit benchmark-only dev-dependency on criterion", """\ Restore icu_properties dev-dependency (version 2.0), which was path-based and was therefore removed in Cargo.toml normalization.\ """, ] [tests] comments = [ """\ Very many doctests have circular dependencies on the top-level icu crate, \ enough that it would be very tedious to patch them all out.\ """, ] run = [ "lib", ] icu_segmenter-fix-metadata.diff --- icu_segmenter-2.0.0/Cargo.toml 1970-01-01T00:00:01+00:00 +++ icu_segmenter-2.0.0/Cargo.toml 2025-09-10T20:49:07.870146+00:00 @@ -172,6 +172,10 @@ ] default-features = false +[dev-dependencies.icu_properties] +version = "2.0.0" +features = ["compiled_data"] + [dev-dependencies.itertools] version = "0.14.0" @@ -182,6 +186,3 @@ [dev-dependencies.serde_json] version = "1.0.45" - -[target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies.criterion] -version = "0.5.0"
Spec URL: https://v02460.fedorapeople.org/rust-icu_segmenter.spec SRPM URL: https://v02460.fedorapeople.org/rust-icu_segmenter-2.0.0-1.fc44.src.rpm Here we go :)
Copr build: https://copr.fedorainfracloud.org/coprs/build/9551407 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388110-rust-icu_segmenter/fedora-rawhide-x86_64/09551407-rust-icu_segmenter/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9554333 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388110-rust-icu_segmenter/fedora-rawhide-x86_64/09554333-rust-icu_segmenter/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, this looks great now! The package is APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. The following modifications are noted: - The Summary is correctly and necessarily shortened to fit in 80 columns. -Summary: Unicode line breaking and text segmentation algorithms for text boundaries analysis +Summary: Unicode line breaking and text segmentation algorithms - A reasonable and properly-documented metadata patch is present: +# Manually created patch for downstream crate metadata changes +# * Omit benchmark-only dev-dependency `criterion`. +# * Restore dev-dependency `icu_properties` (version 2.0), which is path-based +# and was therefore removed by Cargo.toml normalization. +Patch: icu_segmenter-fix-metadata.diff - Doctests are omitted to avoid circular dependencies on the (currently unpackaged) top-level icu crate. -%cargo_test +# * Very many doctests have circular dependencies on the top-level icu crate, +# enough that it would be very tedious to patch them all out. +%cargo_test -- --lib All of these look correct and appropriate. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/icu_segmenter-2.0.0/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is not a serious issue, and is due to reasonable design decisions in rust2rpm. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Unicode License Agreement - Data Files and Software (2016)", "*No copyright* MIT License". 40 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2388110-rust- icu_segmenter/20250914/2388110-rust-icu_segmenter/licensecheck.txt The MIT license text in benches/bench.rs is itself an example text string, not a license that applies to anything in the crate. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- icu_segmenter-devel , rust-icu_segmenter+default-devel , rust- icu_segmenter+auto-devel , rust-icu_segmenter+compiled_data-devel , rust-icu_segmenter+datagen-devel , rust-icu_segmenter+lstm-devel , rust-icu_segmenter+serde-devel [x]: Package functions as described. (Tests pass.) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=137100970 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-icu_segmenter-devel-2.0.0-1.fc44.noarch.rpm rust-icu_segmenter+default-devel-2.0.0-1.fc44.noarch.rpm rust-icu_segmenter+auto-devel-2.0.0-1.fc44.noarch.rpm rust-icu_segmenter+compiled_data-devel-2.0.0-1.fc44.noarch.rpm rust-icu_segmenter+datagen-devel-2.0.0-1.fc44.noarch.rpm rust-icu_segmenter+lstm-devel-2.0.0-1.fc44.noarch.rpm rust-icu_segmenter+serde-devel-2.0.0-1.fc44.noarch.rpm rust-icu_segmenter-2.0.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpz_97ex8s')] checks: 32, packages: 8 8 packages and 0 specfiles checked; 0 errors, 0 warnings, 43 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 7 packages and 0 specfiles checked; 0 errors, 0 warnings, 39 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/icu_segmenter/2.0.0/download#/icu_segmenter-2.0.0.crate : CHECKSUM(SHA256) this package : e185fc13b6401c138cf40db12b863b35f5edf31b88192a545857b41aeaf7d3d3 CHECKSUM(SHA256) upstream package : e185fc13b6401c138cf40db12b863b35f5edf31b88192a545857b41aeaf7d3d3 Requires -------- rust-icu_segmenter-devel (rpmlib, GLIBC filtered): (crate(displaydoc) >= 0.2.3 with crate(displaydoc) < 0.3.0~) (crate(icu_collections) >= 2.0.0 with crate(icu_collections) < 2.1.0~) (crate(icu_locale_core) >= 2.0.0 with crate(icu_locale_core) < 3.0.0~) (crate(icu_provider) >= 2.0.0 with crate(icu_provider) < 3.0.0~) (crate(potential_utf) >= 0.1.1 with crate(potential_utf) < 0.2.0~) (crate(potential_utf/alloc) >= 0.1.1 with crate(potential_utf/alloc) < 0.2.0~) (crate(potential_utf/zerovec) >= 0.1.1 with crate(potential_utf/zerovec) < 0.2.0~) (crate(utf8_iter) >= 1.0.2 with crate(utf8_iter) < 2.0.0~) (crate(zerovec) >= 0.11.1 with crate(zerovec) < 0.12.0~) (crate(zerovec/alloc) >= 0.11.1 with crate(zerovec/alloc) < 0.12.0~) (crate(zerovec/yoke) >= 0.11.1 with crate(zerovec/yoke) < 0.12.0~) cargo rust rust-icu_segmenter+default-devel (rpmlib, GLIBC filtered): cargo crate(icu_segmenter) crate(icu_segmenter/auto) crate(icu_segmenter/compiled_data) rust-icu_segmenter+auto-devel (rpmlib, GLIBC filtered): cargo crate(icu_segmenter) crate(icu_segmenter/lstm) rust-icu_segmenter+compiled_data-devel (rpmlib, GLIBC filtered): (crate(icu_locale) >= 2.0.0 with crate(icu_locale) < 2.1.0~) (crate(icu_locale/compiled_data) >= 2.0.0 with crate(icu_locale/compiled_data) < 2.1.0~) (crate(icu_provider/baked) >= 2.0.0 with crate(icu_provider/baked) < 3.0.0~) (crate(icu_segmenter_data) >= 2.0.0 with crate(icu_segmenter_data) < 2.1.0~) cargo crate(icu_segmenter) rust-icu_segmenter+datagen-devel (rpmlib, GLIBC filtered): (crate(databake) >= 0.2.0 with crate(databake) < 0.3.0~) (crate(databake/derive) >= 0.2.0 with crate(databake/derive) < 0.3.0~) (crate(icu_collections/databake) >= 2.0.0 with crate(icu_collections/databake) < 2.1.0~) (crate(icu_provider/export) >= 2.0.0 with crate(icu_provider/export) < 3.0.0~) (crate(potential_utf/databake) >= 0.1.1 with crate(potential_utf/databake) < 0.2.0~) (crate(zerovec/databake) >= 0.11.1 with crate(zerovec/databake) < 0.12.0~) cargo crate(icu_segmenter) crate(icu_segmenter/serde) rust-icu_segmenter+lstm-devel (rpmlib, GLIBC filtered): (crate(core_maths) >= 0.1.0 with crate(core_maths) < 0.2.0~) cargo crate(icu_segmenter) rust-icu_segmenter+serde-devel (rpmlib, GLIBC filtered): (crate(icu_collections/serde) >= 2.0.0 with crate(icu_collections/serde) < 2.1.0~) (crate(icu_provider/serde) >= 2.0.0 with crate(icu_provider/serde) < 3.0.0~) (crate(potential_utf/serde) >= 0.1.1 with crate(potential_utf/serde) < 0.2.0~) (crate(serde) >= 1.0.110 with crate(serde) < 2.0.0~) (crate(serde/alloc) >= 1.0.110 with crate(serde/alloc) < 2.0.0~) (crate(serde/derive) >= 1.0.110 with crate(serde/derive) < 2.0.0~) (crate(zerovec/serde) >= 0.11.1 with crate(zerovec/serde) < 0.12.0~) cargo crate(icu_segmenter) Provides -------- rust-icu_segmenter-devel: crate(icu_segmenter) rust-icu_segmenter-devel rust-icu_segmenter+default-devel: crate(icu_segmenter/default) rust-icu_segmenter+default-devel rust-icu_segmenter+auto-devel: crate(icu_segmenter/auto) rust-icu_segmenter+auto-devel rust-icu_segmenter+compiled_data-devel: crate(icu_segmenter/compiled_data) rust-icu_segmenter+compiled_data-devel rust-icu_segmenter+datagen-devel: crate(icu_segmenter/datagen) rust-icu_segmenter+datagen-devel rust-icu_segmenter+lstm-devel: crate(icu_segmenter/lstm) rust-icu_segmenter+lstm-devel rust-icu_segmenter+serde-devel: crate(icu_segmenter/serde) rust-icu_segmenter+serde-devel Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2388110-rust-icu_segmenter/20250914/2388110-rust-icu_segmenter/srpm/rust-icu_segmenter.spec 2025-09-14 09:15:17.620761763 +0100 +++ /home/ben/fedora/review/2388110-rust-icu_segmenter/20250914/2388110-rust-icu_segmenter/srpm-unpacked/rust-icu_segmenter.spec 2025-09-12 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 %bcond check 1 @@ -134,3 +144,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Fri Sep 12 2025 John Doe <packager> - 2.0.0-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2388110 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: R, C/C++, Perl, Haskell, SugarActivity, Java, Ocaml, Python, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-icu_segmenter
FEDORA-2025-d3fac81b24 (rust-icu_segmenter-2.0.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d3fac81b24
FEDORA-2025-d3fac81b24 (rust-icu_segmenter-2.0.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.