Spec URL: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/27208a0c214af40cb826b2a75cdb4026481b76a5/python-accelerate.spec SRPM URL: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/27208a0c214af40cb826b2a75cdb4026481b76a5/python-accelerate-1.10.0-2.fc42.src.rpm Description: Accelerate is a library that enables the same PyTorch code to be run across any distributed configuration by adding just four lines of code! In short, training and inference at scale made simple, efficient and adaptable. Fedora Account System Username: xanderlent
Copr build: https://copr.fedorainfracloud.org/coprs/build/9406300 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388140-python-accelerate/fedora-rawhide-x86_64/09406300-python-accelerate/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
SRPM: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/c14eebe06c982bab863b7c250673813fb042b69c/python-accelerate-1.10.0-1.fc42.src.rpm Spec: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/c14eebe06c982bab863b7c250673813fb042b69c/python-accelerate.spec Whoops, original submission had a test failure due to lack of internet.
Created attachment 2103383 [details] The .spec file difference from Copr build 9406300 to 9406306
Copr build: https://copr.fedorainfracloud.org/coprs/build/9406306 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388140-python-accelerate/fedora-rawhide-x86_64/09406306-python-accelerate/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/d090a18f2d70f7d09149f87c402bb4849f1dfd32/python-accelerate.spec SRPM: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/d090a18f2d70f7d09149f87c402bb4849f1dfd32/python-accelerate-1.10.0-1.fc43.src.rpm OK, third time is the charm? I think all the test failures should be sorted now.
Created attachment 2103385 [details] The .spec file difference from Copr build 9406306 to 9406368
Copr build: https://copr.fedorainfracloud.org/coprs/build/9406368 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388140-python-accelerate/fedora-rawhide-x86_64/09406368-python-accelerate/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Overall good, some errors flagged in rpmlint need to be addressed. ex/ python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/examples.py 644 /usr/bin/env python python-accelerate.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 14) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /sfs/fedora- review/review-python-accelerate/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 15187 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-accelerate , python3-accelerate+rich [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-accelerate-1.10.0-1.fc44.noarch.rpm python3-accelerate+rich-1.10.0-1.fc44.noarch.rpm python-accelerate-1.10.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb_19wsij')] checks: 32, packages: 3 python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/accelerate_cli.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/__init__.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/cluster.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/config.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/config_args.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/config_utils.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/default.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/sagemaker.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/update.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/env.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/estimate.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/launch.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/merge.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/test.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/to_fsdp2.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/tpu.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/examples.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/test_distributed_data_loop.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/test_ops.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/test_script.py 644 /usr/bin/env python python3-accelerate.noarch: W: no-manual-page-for-binary accelerate python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-config python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-estimate-memory python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-launch python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-merge-weights python-accelerate.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 14) python3-accelerate.noarch: W: files-duplicate /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/__init__.py /usr/lib/python3.14/site-packages/accelerate/commands/__init__.py python3-accelerate.noarch: W: devel-file-in-non-devel-package /usr/bin/accelerate-config 3 packages and 0 specfiles checked; 20 errors, 8 warnings, 31 filtered, 20 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/accelerate_cli.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/__init__.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/cluster.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/config.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/config_args.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/config_utils.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/default.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/sagemaker.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/config/update.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/env.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/estimate.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/launch.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/merge.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/test.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/to_fsdp2.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/commands/tpu.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/examples.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/test_distributed_data_loop.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/test_ops.py 644 /usr/bin/env python python3-accelerate.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/test_script.py 644 /usr/bin/env python python3-accelerate.noarch: W: no-manual-page-for-binary accelerate python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-config python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-estimate-memory python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-launch python3-accelerate.noarch: W: no-manual-page-for-binary accelerate-merge-weights python3-accelerate.noarch: W: files-duplicate /usr/lib/python3.14/site-packages/accelerate/test_utils/scripts/__init__.py /usr/lib/python3.14/site-packages/accelerate/commands/__init__.py python3-accelerate.noarch: W: devel-file-in-non-devel-package /usr/bin/accelerate-config 2 packages and 0 specfiles checked; 20 errors, 7 warnings, 27 filtered, 20 badness; has taken 0.2 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/accelerate/accelerate-1.10.0.tar.gz : CHECKSUM(SHA256) this package : 8270568fda9036b5cccdc09703fef47872abccd56eb5f6d53b54ea5fb7581496 CHECKSUM(SHA256) upstream package : 8270568fda9036b5cccdc09703fef47872abccd56eb5f6d53b54ea5fb7581496 Requires -------- python3-accelerate (rpmlib, GLIBC filtered): (python3.14dist(numpy) < 3~~ with python3.14dist(numpy) >= 1.17) /usr/bin/python3 python(abi) python3.14dist(huggingface-hub) python3.14dist(packaging) python3.14dist(psutil) python3.14dist(pyyaml) python3.14dist(safetensors) python3.14dist(torch) python3-accelerate+rich (rpmlib, GLIBC filtered): python(abi) python3-accelerate python3.14dist(rich) Provides -------- python3-accelerate: python-accelerate python3-accelerate python3.14-accelerate python3.14dist(accelerate) python3dist(accelerate) python3-accelerate+rich: python-accelerate+rich python3-accelerate+rich python3.14-accelerate+rich python3.14dist(accelerate[rich]) python3dist(accelerate[rich]) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n python-accelerate Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: PHP, fonts, Perl, Haskell, R, SugarActivity, C/C++, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/56a37755a6cdcea76e1f64af005a1d61af9433d2/python-accelerate.spec SRPM URL: https://gist.github.com/xanderlent/2ab1005c61cb8c965980066bd1d2ec2e/raw/56a37755a6cdcea76e1f64af005a1d61af9433d2/python-accelerate-1.10.0-1.fc44.src.rpm This addresses all the rpmlint errors. As for the warnings: - It's unfortunately common for small packages in non-C languages to lack manual pages. I put in a TODO. - The duplicate files issue is because both files are empty except for a copyright header, they are __init__.py after all. - The devel file is not a devel file at all, it is just a CLI utility.
Created attachment 2104221 [details] The .spec file difference from Copr build 9406368 to 9452218
Copr build: https://copr.fedorainfracloud.org/coprs/build/9452218 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2388140-python-accelerate/fedora-rawhide-x86_64/09452218-python-accelerate/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
python-accelerate.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 14) I am not sure what you use as an editor, Using emacs' white-space-mode i can see that the BuildRequires use a tab as a separator, and everything else uses spaces. Not a blocker. Thanks for the changes. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-accelerate
FEDORA-2025-b102f1db66 (python-accelerate-1.10.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b102f1db66
FEDORA-2025-b102f1db66 (python-accelerate-1.10.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.