spec: https://fed500.fedorapeople.org/fmedrano-kalnia-glaze-fonts.spec srpm: https://fed500.fedorapeople.org/fmedrano-kalnia-glaze-fonts-0.0%5e20240623git3338853-1.fc42.src.rpm description: Kalnia Glaze is a new typeface that experiments with the new color font technology in variable fonts, inviting you to step into a world of color and add vibrancy and depth to your projects. Inspired by the Victorian era, Kalnia Glaze features high contrast and refined terminals. Much like the Victorian Sash windows that were meticulously glazed to capture a timeless charm, Kalnia Glaze takes the essence of this historical craftsmanship into its letterforms. It incorporate their structural elegance, volume, and lighting nuances, to enhance the original structure of Kalnia typeface with added complexity and decoration. fas: fed500 Comments: a) There is no foundry information. Raised an issue: https://github.com/fridamedrano/Kalnia-Glaze/issues/23 b) These are variable color fonts, application support is still being developed, leading FOSS software includes web browsers, Inkscape, Krita and Gimp. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/9439609 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2389098-fmedrano-kalnia-glaze-fonts/fedora-rawhide-x86_64/09439609-fmedrano-kalnia-glaze-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Foundry is not mandatory. Its upto upstream to choose foundry name. If its not chosen then leave it in font package name. also if you check KalniyaGlaze.glyphs file it contains { key = manufacturerURL; value = "https://www.google.com/fonts"; }, { key = vendorID; value = GOOG; } so, font already embedding vendor as GOOG or google as foundry. Either get confirmation from upstream to use google as foundry or use package name as kalnia-glaze-fonts. - Fix rpmlint issues as given below in review. - The upstream font source already saying version as 1.110 so change to this in SPEC file. - why not use shortcommit as %global shortcommit %(c=%{commit}; echo ${c:0:7}) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "SIL Open Font License 1.1", "*No copyright* SIL Open Font License 1.1". 80 files have unknown license. Detailed output of licensecheck in /home/test/2389098-fmedrano-kalnia- glaze-fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [?]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6611 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run fc-query on all fonts in package. Note: Cannot find fc-query command, install fontconfig package to make a comprehensive font review. See: url: undefined [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: fmedrano-kalnia-glaze-fonts-0.0^20240623git3338853-1.fc43.noarch.rpm fmedrano-kalnia-glaze-fonts-0.0^20240623git3338853-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5hwk1xkq')] checks: 32, packages: 2 fmedrano-kalnia-glaze-fonts.noarch: E: spelling-error ('letterforms', '%description -l en_US letterforms -> letter forms, letter-forms, letterbombs') fmedrano-kalnia-glaze-fonts.src: E: spelling-error ('letterforms', '%description -l en_US letterforms -> letter forms, letter-forms, letterbombs') fmedrano-kalnia-glaze-fonts.spec:15: W: non-break-space line 15, char 21 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 4.9 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 fmedrano-kalnia-glaze-fonts.noarch: E: spelling-error ('letterforms', '%description -l en_US letterforms -> letter forms, letter-forms, letterbombs') 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.1 s Source checksums ---------------- https://github.com/fridamedrano/Kalnia-Glaze/archive/3338853e096724f548386c608d7c42c63c6c33bd/Kalnia-Glaze-3338853e096724f548386c608d7c42c63c6c33bd.tar.gz : CHECKSUM(SHA256) this package : 435a05b46bf766e4b29004661e73746260734b0c3fcbdc42b82323019a20c063 CHECKSUM(SHA256) upstream package : 435a05b46bf766e4b29004661e73746260734b0c3fcbdc42b82323019a20c063 Requires -------- fmedrano-kalnia-glaze-fonts (rpmlib, GLIBC filtered): config(fmedrano-kalnia-glaze-fonts) fontpackages-filesystem Provides -------- fmedrano-kalnia-glaze-fonts: config(fmedrano-kalnia-glaze-fonts) fmedrano-kalnia-glaze-fonts font(kalniaglaze) font(kalniaglazethin) metainfo() metainfo(org.fedoraproject.fmedrano-kalnia-glaze-fonts.metainfo.xml) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2389098 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: fonts, Generic, Shell-api Disabled plugins: C/C++, Java, R, SugarActivity, Ocaml, Python, Perl, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH