spec: https://suve.fedorapeople.org/review/davegnukem-1.0.3-1/davegnukem.spec srpm: https://suve.fedorapeople.org/review/davegnukem-1.0.3-1/davegnukem-1.0.3-1.fc42.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=136210083 Description: Dave Gnukem is a retro-style 2D scrolling platform shooter similar to, and inspired by, Duke Nukem 1 (~1991). The original Duke Nukem 1 had 16-color EGA 320x200 graphics; the aim here is "similar but different" gameplay and "look and feel". It is kind of a parody of the original. Fedora Account System Username: suve
Copr build: https://copr.fedorainfracloud.org/coprs/build/9441385 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2389251-davegnukem/fedora-rawhide-x86_64/09441385-davegnukem/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
1. Is there a particular reason why you can't replace: %setup -q -n dave_gnukem-%{version} %setup -q -n dave_gnukem-%{version} -D -T -a 1 with %setup -q -n dave_gnukem-%{version} -a 1 ? 2. Is there any particular reason to use double hyphen instead of a single one in patch file names? Patch0: gnukem--Makefile.patch Patch1: gnukem--BigEndian.patch 3. %{_mandir}/man6/%{name}.* Shouldn't this be: %{_mandir}/man6/%{name}.6* ?
1. Huh. Didn't know that would work. Thanks for the suggestion. 2. Not really, just personal preference. 3. Yep, it should. Good catch.
Fixed 1) and 3) and backported the AppStream metainfo file. spec: https://suve.fedorapeople.org/review/davegnukem-1.0.3-2/davegnukem.spec srpm: https://suve.fedorapeople.org/review/davegnukem-1.0.3-2/davegnukem-1.0.3-2.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=136603327
Created attachment 2105423 [details] The .spec file difference from Copr build 9441385 to 9509762
Copr build: https://copr.fedorainfracloud.org/coprs/build/9509762 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2389251-davegnukem/fedora-rawhide-x86_64/09509762-davegnukem/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.