Spec URL: https://rathann.fedorapeople.org/review/fdkaac/fdkaac.spec SRPM URL: https://rathann.fedorapeople.org/review/fdkaac/fdkaac-1.0.6-5.fc44.src.rpm Description: fdkaac reads linear PCM audio in either WAV, raw PCM, or CAF format, and encodes it into either M4A / AAC file. If the input file is "-", data is read from stdin. Likewise, if the output file is "-", data is written to stdout if one of streamable AAC transport formats are selected by -f. When CAF input and M4A output is used, tags in CAF file are copied into the resulting M4A. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/9451688 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2389958-fdkaac/fedora-rawhide-x86_64/09451688-fdkaac/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Spec review notes: > %build > autoreconf -fiv > export LDFLAGS="%{?__global_ldflags} -L%{_libdir}/fdk-aac" > %configure This should be in %conf, and instead of messing with "$LDFLAGS", it's better to update %build_ldflags instead.