Spec URL: https://rathann.fedorapeople.org/review/fdkaac/fdkaac.spec SRPM URL: https://rathann.fedorapeople.org/review/fdkaac/fdkaac-1.0.6-5.fc44.src.rpm Description: fdkaac reads linear PCM audio in either WAV, raw PCM, or CAF format, and encodes it into either M4A / AAC file. If the input file is "-", data is read from stdin. Likewise, if the output file is "-", data is written to stdout if one of streamable AAC transport formats are selected by -f. When CAF input and M4A output is used, tags in CAF file are copied into the resulting M4A. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/9451688 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2389958-fdkaac/fedora-rawhide-x86_64/09451688-fdkaac/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Spec review notes: > %build > autoreconf -fiv > export LDFLAGS="%{?__global_ldflags} -L%{_libdir}/fdk-aac" > %configure This should be in %conf, and instead of messing with "$LDFLAGS", it's better to update %build_ldflags instead.
Spec URL: https://rathann.fedorapeople.org/review/fdkaac/fdkaac.spec SRPM URL: https://rathann.fedorapeople.org/review/fdkaac/fdkaac-1.0.6-6.fc44.src.rpm - update build_ldflags instead of messing with LDFLAGS
Created attachment 2128224 [details] The .spec file difference from Copr build 9451688 to 10094561
Copr build: https://copr.fedorainfracloud.org/coprs/build/10094561 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2389958-fdkaac/fedora-rawhide-x86_64/10094561-fdkaac/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Anything else to fix or is this ready to be approved?
Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correctly marked and license data is installed * No serious rpmlint issues PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/fdkaac
FEDORA-2026-b26110ebfd (fdkaac-1.0.6-6.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2026-b26110ebfd
FEDORA-2026-bb32c80cd0 (fdkaac-1.0.6-6.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-bb32c80cd0
FEDORA-2026-aed7714b25 (fdkaac-1.0.6-6.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-aed7714b25
FEDORA-2026-b26110ebfd has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-b26110ebfd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-b26110ebfd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-aed7714b25 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-aed7714b25 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-aed7714b25 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-bb32c80cd0 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bb32c80cd0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bb32c80cd0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-bb32c80cd0 (fdkaac-1.0.6-6.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-b26110ebfd (fdkaac-1.0.6-6.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-aed7714b25 (fdkaac-1.0.6-6.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.