spec: https://suve.fedorapeople.org/review/hypersomnia-1.5.1^20250823.b9bf658-1/hypersomnia.spec srpm: https://suve.fedorapeople.org/review/hypersomnia-1.5.1^20250823.b9bf658-1/hypersomnia-1.5.1^20250823.b9bf658-1.fc42.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=136360627 Description: Hypersomnia is a hardcore arena mixing eSports with pixely nostalgia. Every match will be unforgiving - every duel a psychological battle. Fedora Account System Username: suve
Copr build: https://copr.fedorainfracloud.org/coprs/build/9459483 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2390526-hypersomnia/fedora-rawhide-x86_64/09459483-hypersomnia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v1.5.4 and unbundled one more library. spec: https://suve.fedorapeople.org/review/hypersomnia-1.5.4-1/hypersomnia.spec srpm: https://suve.fedorapeople.org/review/hypersomnia-1.5.4-1/hypersomnia-1.5.4-1.fc42.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=136439703
Created attachment 2104765 [details] The .spec file difference from Copr build 9459483 to 9487279
Copr build: https://copr.fedorainfracloud.org/coprs/build/9487279 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2390526-hypersomnia/fedora-rawhide-x86_64/09487279-hypersomnia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to latest git snapshot. Unfortunately this required re-bundling a library. spec: https://suve.fedorapeople.org/review/hypersomnia-1.6.4^20260201.4f22661-1/hypersomnia.spec srpm: https://suve.fedorapeople.org/review/hypersomnia-1.6.4^20260201.4f22661-1/hypersomnia-1.6.4^20260201.4f22661-1.fc43.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=142473802
Created attachment 2130240 [details] The .spec file difference from Copr build 9487279 to 10154242
Copr build: https://copr.fedorainfracloud.org/coprs/build/10154242 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2390526-hypersomnia/fedora-rawhide-x86_64/10154242-hypersomnia/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v2.0.0~pre3. spec: https://suve.fedorapeople.org/review/hypersomnia-2.0.0~pre3-1/hypersomnia.spec srpm: https://suve.fedorapeople.org/review/hypersomnia-2.0.0~pre3-1/hypersomnia-2.0.0~pre3^20260519.af91b36-1.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=145638398
> Source0: %{name}-%{archive_suffix}.zip The source is quite ambiguous where it comes from. Could maybe use `%forgemeta` instead, openmw is an example for how to define it with git submodules, and the generate-source.sh can just become a scriptlet that updates the git submodule references? If not at least put a comment pointing to the upstream source in the spec file > Patch0: %{name}--system-openal.patch Providence of patches please? > While stb is unbundled, it's a static library, so it's still included in the License tag. Well, so is `nlohmann_json` right? > %files data Same license comment as `davegnukem` > %global httplib_bundled 0 Can make this a %bcond instead? > %global rapidjson_cmake OFF (no longer applies, but fyi) CMake works fine with `0`/`1` from `%with_` macros. You might want to add `:BOOL`, but don't remember if it affects normalization. > -DCMAKE_POLICY_VERSION_MINIMUM=3.5 Can raise the issue to upstream? > sed -e 's|^#include "3rdparty/stb/|#include "stb/|g' -i src/augs/image/image.cpp This looks like something that can be fixed in upstream by moving the `target_include_directories` one layer up. Can propose to upstream? > -DARCHITECTURE=native Oh boy that flag does some vodoo. Can you check [1] to see if you should conditionalize it? > -DBUILD_UNIT_TESTS=OFF Can add a comment on why? > Generate a .desktop file Can make it a static template file like the `wrapper.sh` file? > # %%cmake_install doesn't do anything, so we gotta copy stuff manually. Haha. Can ask them to do something :). Make sure that you do RPATH reset if you install manually. Alternatively, what's the deal with cmake/steam_integration/CMakeLists.txt? > BSD-2-Clause Why it was added is not explained. I did find `src/3rdparty/yojimbo/sodium/sodium_hash_sha512_cp.c` from license-check. Also going through the `src/3rdparty` a few others are not covered or deleted: crc32, glad, glfw, rapidjson (missing similar comment to cpp-httplib) From last rpmlint: > hypersomnia-data.noarch: W: dangling-relative-symlink /usr/share/hypersomnia/content/fonts/Ubuntu-Regular.ttf ../../../fonts/liberation-sans-fonts/LiberationSans-Regular.ttf Need to re-run the fedora-review on the newer one, will do that after the next reply [1]: https://github.com/TeamHypersomnia/Hypersomnia/commit/9cdc28ae2bbf6b5a2b4cddad89feadcbbeed4734
> Providence of patches please? Both patches are original, written for the Fedora package. > > While stb is unbundled, it's a static library, so it's still included in the License tag. > Well, so is `nlohmann_json` right? Good catch, I'll add it to the license tag. > > %global httplib_bundled 0 > Can make this a %bcond instead? Uhh, I guess I could, though I never used bconds, so I'd have to do some reading on those. > > -DCMAKE_POLICY_VERSION_MINIMUM=3.5 > Can raise the issue to upstream? Sure. > > sed -e 's|^#include "3rdparty/stb/|#include "stb/|g' -i src/augs/image/image.cpp > This looks like something that can be fixed in upstream by moving the `target_include_directories` one layer up. Can propose to upstream? I know next to nothing about CMake, but I can check if that works or not. > > -DARCHITECTURE=native > Oh boy that flag does some vodoo. Can you check [1] to see if you should conditionalize it? It does some voodoo, yes. "native" is the non-voodoo option - it should not set any extra compiler switches or perform any other magic. Originally, upstream did not support "native"; I've sent this in a patch. > > -DBUILD_UNIT_TESTS=OFF > Can add a comment on why? Never tried those. I can look into them. > Alternatively, what's the deal with cmake/steam_integration/CMakeLists.txt? This looks like a helper target that upstream uses for generating AppImages for the Steam version: https://store.steampowered.com/app/2660970/Hypersomnia/ > > BSD-2-Clause > Why it was added is not explained. Leftover from previous versions, where it was not possible to build against system-provided LZ4.