Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Nmap-Parser.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Nmap-Parser-1.05-1.fc7.src.rpm Description: This module implements a interface to the information contained in an nmap scan. It is implemented by parsing the xml scan data that is generated by nmap. This will enable anyone who utilizes nmap to quickly create fast and robust security scripts that utilize the powerful port scanning abilities of nmap.
I was typing this in before cweyl took this for review; hopefully the comments will still be useful. Some rpmlint complaints: E: perl-Nmap-Parser no-changelogname-tag The changelog is empty W: perl-Nmap-Parser spurious-executable-perm /usr/share/doc/perl-Nmap-Parser-1.05/README W: perl-Nmap-Parser spurious-executable-perm /usr/share/doc/perl-Nmap-Parser-1.05/LICENSE Executable README and LICENSE files? E: perl-Nmap-Parser wrong-script-end-of-line-encoding /usr/share/doc/perl-Nmap-Parser-1.05/README Perhaps this package came from DOS or something. All of the line endings need to be fixed up with a quick trip through tr or sed. W: perl-Nmap-Parser manifest-in-perl-module /usr/share/doc/perl-Nmap-Parser-1.05/MANIFEST The manifest file isn't to be packaged. W: perl-Nmap-Parser spurious-executable-perm /usr/share/doc/perl-Nmap-Parser-1.05/MANIFEST E: perl-Nmap-Parser wrong-script-end-of-line-encoding /usr/share/doc/perl-Nmap-Parser-1.05/MANIFEST Hmmm.... E: perl-Nmap-Parser script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/Nmap/Parser.pm This shouldn't be executable. Or, if it needs to be executable, it needs to have the usual #!/usr/bin/perl as its first line. E: perl-Nmap-Parser wrong-script-end-of-line-encoding /usr/lib/perl5/vendor_perl/5.8.8/Nmap/Parser.pm tr or sed again. Next, you'll need BuildRequires: perl(ExtUtils::MakeMaker,) perl(Test::More) so that your package will still build and run its tests once the perl-devel split from the main perl package is complete.
Updated: - Don't package Manifest - Fix permissions - Fix end-of-line encoding - Add missing BRs Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Nmap-Parser.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Nmap-Parser-1.05-2.fc7.src.rpm rpmlint is silent here now.
Some remarks: * You are using "dos2unix" to convert files. Please use /usr/bin/dos2unix instead and add BuildRequires: /usr/bin/dos2unix * Please move file conversion and permission fixing to %prep instead of %install and fix the source files instead of the installed files.
Updated: - Move end-of-line fix to %prep - Update dos2unix BR Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Nmap-Parser.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Nmap-Parser-1.05-3.fc7.src.rpm
Now that tibbs and Ralf have done the hard work, I'll post my review :) Note that you can also use sed itself to fix end-of-line-encoding warnings; "sed -i '/\r//' filename" will do it. I'm just pointing this out, it's certainly not a blocker to use dos2unix. + source files match upstream: 5d5f113a9d166b07e041a5dc52f9c3ee Nmap-Parser-1.05.tar.gz 5d5f113a9d166b07e041a5dc52f9c3ee ../Nmap-Parser-1.05.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. (noarch) + %clean is present. + package installs properly + rpmlint is silent. + final provides and requires are sane: ** perl-Nmap-Parser-1.05-3.fc6.noarch.rpm == rpmlint == provides perl(Nmap::Parser) = 1.05 perl(Nmap::Parser::Host) perl(Nmap::Parser::Host::OS) perl(Nmap::Parser::Host::Service) perl(Nmap::Parser::Session) perl-Nmap-Parser = 1.05-3.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Storable) perl(XML::Twig) perl(strict) perl(vars) + %check is present and all tests pass: All tests successful. Files=4, Tests=171, 1 wallclock secs ( 1.07 cusr + 0.28 csys = 1.35 CPU) + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. APPROVED
New Package CVS Request ======================= Package Name: perl-Nmap-Parser Short Description: Parse nmap scan data with perl Owners: foolish Branches: FC-5 FC-6 EL-4 EL-5 InitialCC: jaa
Seems the F7 branch wasn't created during merge, please add it. New Package CVS Request ======================= Package Name: perl-Nmap-Parser Short Description: Parse nmap scan data with perl Owners: foolish Branches: FC-5 FC-6 EL-4 EL-5 F-7
F-7 branch added
Changing state back to how it was before cvs request.
Package Change Request ====================== Package Name: perl-Nmap-Parser InitialCC: perl-sig Please add perl-sig to this package with watchbugzilla and watchcommits bits on all fedora branches.
Done.