Bug 239089 - Review Request: ike-scan - IKE protocol tool to discover, fingerprint and test IPsec VPN se rvers
Summary: Review Request: ike-scan - IKE protocol tool to discover, fingerprint and tes...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: manuel wolfshant
QA Contact: Fedora Package Reviews List
Keywords: Reopened
Depends On:
TreeView+ depends on / blocked
Reported: 2007-05-04 20:30 UTC by Sindre Pedersen Bjørdal
Modified: 2007-11-30 22:12 UTC (History)
0 users

Clone Of:
Last Closed: 2007-05-27 04:33:14 UTC
wolfy: fedora-review+
petersen: fedora-cvs+

Attachments (Terms of Use)
patch to enable usage of the openssl lib (829 bytes, patch)
2007-05-08 21:52 UTC, manuel wolfshant
no flags Details | Diff

Description Sindre Pedersen Bjørdal 2007-05-04 20:30:00 UTC
Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/ike-scan.spec
SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/ike-scan-1.9-1.fc7.src.rpm

ike-scan is a command-line tool that uses the IKE protocol to discover,
fingerprint and test IPsec VPN servers.

Comment 1 manuel wolfshant 2007-05-08 21:51:30 UTC
Package Review

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on:x86_64
 [x] Rpmlint output:
rpmlint of ike-scan-1.9-1.fc7.x86_64.rpm: empty
rpmlint of ike-scan-debuginfo-1.9-1.fc7.x86_64.rpm:W: ike-scan-debuginfo
spurious-executable-perm /usr/src/debug
--> the file should be chmod-ed -x in %prep to make rpmlint happy

 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type:GPL
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of package: e973742c32c7b65fe134233482c94e3e94db3b32
 [x] Package is not known to require ExcludeArch, OR:
     Arches excluded:
 [-] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [!] Permissions on files are set properly. See issue 1
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] Package does not own files or directories owned by other packages.

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: devel/x86_64 and devel/i386
 [x] Package should compile and build into binary rpms on all supported
     Tested on:devel/x86_64 and devel/i386
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.

=== Issues ===
1. one source file (mt19937ar.c) is inherited from upstream with wrong
permissions. fix is so simple that I suggest to do it.
2. Examining the build log, one can notice a warning that during the build an
internal openssl set of functions is used and recommends using the openssl lib
instead (for increased speed). I have tested and adding BR: openssl-devel +
%configure --with-openssl still builds and runs OK. I suggest to use the
attached patch to enable this feature. Not mandatory, of course but recommended.

*** APPROVED ***

Comment 2 manuel wolfshant 2007-05-08 21:52:38 UTC
Created attachment 154363 [details]
patch to enable usage of the openssl lib

Comment 3 Sindre Pedersen Bjørdal 2007-05-08 22:44:52 UTC
Patch applied. 

New Package CVS Request
Package Name: ike-scan
Short Description: IKE protocol tool to discover, fingerprint and test IPsec VPN
Owners: foolish@guezz.net
Branches: FC-5 FC-6 EL-4 EL-5
InitialCC: jaa@redhat.com

Comment 4 Sindre Pedersen Bjørdal 2007-05-23 15:08:07 UTC
Seems the F7 branch wasn't created during merge, please add it.

New Package CVS Request
Package Name: ike-scan
Short Description: IKE protocol tool to discover, fingerprint and test IPsec VPN
Owners: foolish@guezz.net
Branches: FC-5 FC-6 EL-4 EL-5 F-7

Comment 5 Jens Petersen 2007-05-27 04:26:34 UTC
F-7 branch added

Please close if packages have already been built.

Comment 6 Jens Petersen 2007-05-27 04:33:14 UTC
Closing back to state before cvsadmin request.

Note You need to log in before you can comment on or make changes to this bug.