Spec URL: https://rcallicotte.fedorapeople.org/umoci.spec SRPM URL: https://rcallicotte.fedorapeople.org/umoci-0.5.0-1.fc44.src.rpm Description: umoci (pronounced /uːmoˈʨi/ or approximately "oo-mo-tchee") is a reference implementation of the OCI image specification and provides users with the ability to create, manipulate, and otherwise interact with container images. It is designed to be as small and unopinonated as possible, so as to act as a foundation for larger systems to be built on top of. Fedora Account System Username: rcallicotte
Successful scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=136459446
Taking this review.
What's holding up creating man pages? I see you have a build dependency on go-md2man, so I assume that's what it uses for man pages?
Sorry, I was rushing to get the request opened on this... Updated with manpages. The upstream project provides gpg keyring information. I was attempting to add that to the package but nothing I tried seemed to work. I also reviewed OpenSuse Build Service[1], but it looks like that is not really doing a true verification of the keyring, just a sha256sum comparison. So I decided to skip over that for now. Updated SPEC: https://rcallicotte.fedorapeople.org/umoci.spec Updated SRPM: https://rcallicotte.fedorapeople.org/umoci-0.5.0-1.fc44.src.rpm [1] - https://build.opensuse.org/projects/openSUSE:Factory/packages/umoci/files/umoci.spec?expand=1
Created attachment 2105426 [details] The .spec file difference from Copr build 9493539 to 9510007
> export LDFLAGS="-X %{goipath}.version=%{version}" This should probably be "%{version}-%{release}".
Also, isn't the variable GO_LDFLAGS?
(In reply to Neal Gompa from comment #6) > > export LDFLAGS="-X %{goipath}.version=%{version}" > > This should probably be "%{version}-%{release}". After compiled, this will show up like below: <mock-chroot> sh-5.3# ./umoci -v umoci version 0.5.0-1.fc44 This appears to be somewhat similar to how the Open Suse package is built: > export VERSION="$(cat ./VERSION)" > if [ "$VERSION" != "%{version}" ]; then > # Append "_suse" if the version is not an upstream one. > VERSION="%{version}_suse" > fi
(In reply to Neal Gompa from comment #7) > Also, isn't the variable GO_LDFLAGS? You're right. I double-checked the go-rpm-macros and LDFLAGS is deprecated in favor of GO_LDFLAGS. I have updated the spec with these changes. Updated SPEC: https://rcallicotte.fedorapeople.org/umoci.spec Updated SRPM: https://rcallicotte.fedorapeople.org/umoci-0.5.0-1.fc44.src.rpm
Created attachment 2105541 [details] The .spec file difference from Copr build 9510007 to 9513993
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
When processing this ticket, the Fedora Review Service failed with a traceback instead of commenting. I reported an issue for that: https://github.com/FrostyX/fedora-review-service/issues/70 It built in Copr successfully though https://copr.fedorainfracloud.org/coprs/g/fedora-review/fedora-review-2391155-umoci/build/9820409/
Review notes: * Package follows Fedora Packaging Guidelines * Package correctly identifies licensing and declares bundled dependencies - You might want to check with the Go SIG on how to do this in a more automatic fashion, I think they have a dependency generator for this stuff now * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/umoci
FEDORA-2025-123d72b639 (umoci-0.5.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-123d72b639
FEDORA-2025-123d72b639 (umoci-0.5.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.