Red Hat Bugzilla – Bug 239154
Review Request: referencer - A document organiser and bibliography manager for Gnome
Last modified: 2007-11-30 17:12:03 EST
Spec URL: ftp://czar.eas.yorku.ca/pub/referencer/referencer.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/referencer/ Description: Referencer is a Gnome application to organise documents or references, and ultimately generate a BibTeX bibliography file. Its features include automatic metadata retrieval, smart web links, ability to import from BibTeX, Reference Manager and EndNote, and tagging.
Created attachment 154382 [details] mock-referencer-build.log I am not yet a package-maintainer. This is my "pre-review" to exercise reviewing. I checked this package as follows. rpmlint is silent on both of this SRPM and the generated binary package. package name: reference: OK. spec file name: reference.spec: OK. license: GPL: %license field matches the actual license, COPYING is listed in %doc, OK. spec file: written in English, legible: OK. upstream source: http://icculus.org/referencer/downloads/referencer-1.0.3.tar.gz: md5sum:1179e0eafc17ef130b8d669255bef0b3 source: referencer-1.0.3.tar.gz: md5sum:1179e0eafc17ef130b8d669255bef0b3, matches to the upstream source, OK. build: mock successfully built this package on fc-6/i386, see the attached build.log, OK. BuildRequires: poppler-devel libgnomeuimm26-devel boost-devel gcc-c++ gettext perl(XML::Parser) desktop-file-utils: all required packages are listed, so mock builds successfully, OK. locale handling: by %find_lang %{name}, not by %{_datadir}/locale/*: OK. %prefix: not used: OK. shared library problem: not installed: OK. ownership of directories and files: all listed under %doc, ${_bindir} and ${_datadir}: OK. owning directories created by other packages: none: OK. duplicate listing in %file: none: OK. %defattr: (-,root,root,-): OK. at the beginning of %install: rm -rf %{buildroot}: OK. %clean: rm -rf %{buildroot} OK. usage of macros: consistent: OK. desktop file: %{name}.desktop is installed with desktop-file-install in %install: OK. %post, %postun: update desktop database, mime database and icon cache: OK. This packaging seems to be complete!
typos in #1 comment: package name: referencer, not reference spec file: referencer.spec, not reference.spec
Almost okay. One issue: * Timestamps - This package installs some files which were not built or modified during rebuilding (such as .png, .svg, .glade..) and keeping timestamps on these files is recommended. (actually for this package only 3 files are built or modified) For this package, please use the following: ----------------------------------------------------------- make DESTDIR=%{buildroot} INSTALL="%{__install} -p" install ----------------------------------------------------------- Other things are okay.
With the timestamp changes, Spec URL: ftp://czar.eas.yorku.ca/pub/referencer/referencer.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/referencer/referencer-1.0.3-2.fc7.src.rpm
Okay. --------------------------------------------------- This package (referencer) is APPROVED by me. --------------------------------------------------- NOTE: Deep freeze for Fedora 7 is set as Thursday (on American time, perhaps). If you want to make this packaged included into initial Fedora 7 release, you have to * rebuild this on koji * send a main to rel-eng to make the build on koji tagged with f7-final
New Package CVS Request ======================= Package Name: referencer Short Description: A document organiser and bibliography manager for Gnome Owners: dakingun@gmail.com Branches: FC-6 InitialCC:
Package built for devel and FC-6, thanks to Kiyoshi Matsui and Mamoru Tasaka for the reviews.