Created attachment 2105891 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-moka.spec SRPM URL: https://music.fedorapeople.org/rust-moka-0.12.10-1.fc42.src.rpm Description: A fast and concurrent cache library inspired by Java Caffeine. Fedora Account System Username: music
Copr build: https://copr.fedorainfracloud.org/coprs/build/9533167 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2393703-rust-moka/fedora-rawhide-x86_64/09533167-rust-moka/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9533168 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2393703-rust-moka/fedora-rawhide-x86_64/09533168-rust-moka/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
*** Bug 2302678 has been marked as a duplicate of this bug. ***
I had my previous review for moka already, in bug #2302678. But yours is more recent a bit more tuned, so let's keep your review and have it tried.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/moka-0.12.10/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "*No copyright* MIT License", "*No copyright* Apache License (v2.0) or MIT license". 89 files have unknown license. Detailed output of licensecheck in /home/pemensik/fedora/rawhide/2393703-rust-moka/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- moka-devel , rust-moka+default-devel , rust-moka+async-lock-devel , rust-moka+event-listener-devel , rust-moka+future-devel , rust- moka+futures-util-devel , rust-moka+log-devel , rust-moka+logging- devel , rust-moka+once_cell-devel , rust-moka+quanta-devel , rust- moka+sync-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-moka-devel-0.12.10-1.fc44.noarch.rpm rust-moka+default-devel-0.12.10-1.fc44.noarch.rpm rust-moka+async-lock-devel-0.12.10-1.fc44.noarch.rpm rust-moka+event-listener-devel-0.12.10-1.fc44.noarch.rpm rust-moka+future-devel-0.12.10-1.fc44.noarch.rpm rust-moka+futures-util-devel-0.12.10-1.fc44.noarch.rpm rust-moka+log-devel-0.12.10-1.fc44.noarch.rpm rust-moka+logging-devel-0.12.10-1.fc44.noarch.rpm rust-moka+once_cell-devel-0.12.10-1.fc44.noarch.rpm rust-moka+quanta-devel-0.12.10-1.fc44.noarch.rpm rust-moka+sync-devel-0.12.10-1.fc44.noarch.rpm rust-moka-0.12.10-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdgjmi3co')] checks: 32, packages: 12 rust-moka+async-lock-devel.noarch: W: no-documentation rust-moka+default-devel.noarch: W: no-documentation rust-moka+event-listener-devel.noarch: W: no-documentation rust-moka+future-devel.noarch: W: no-documentation rust-moka+futures-util-devel.noarch: W: no-documentation rust-moka+log-devel.noarch: W: no-documentation rust-moka+logging-devel.noarch: W: no-documentation rust-moka+once_cell-devel.noarch: W: no-documentation rust-moka+quanta-devel.noarch: W: no-documentation rust-moka+sync-devel.noarch: W: no-documentation 12 packages and 0 specfiles checked; 0 errors, 10 warnings, 57 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 11 11 packages and 0 specfiles checked; 0 errors, 0 warnings, 63 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/moka/0.12.10/download#/moka-0.12.10.crate : CHECKSUM(SHA256) this package : a9321642ca94a4282428e6ea4af8cc2ca4eac48ac7a6a4ea8f33f76d0ce70926 CHECKSUM(SHA256) upstream package : a9321642ca94a4282428e6ea4af8cc2ca4eac48ac7a6a4ea8f33f76d0ce70926 Requires -------- rust-moka-devel (rpmlib, GLIBC filtered): (crate(crossbeam-channel/default) >= 0.5.5 with crate(crossbeam-channel/default) < 0.6.0~) (crate(crossbeam-epoch/default) >= 0.9.9 with crate(crossbeam-epoch/default) < 0.10.0~) (crate(crossbeam-utils/default) >= 0.8.0 with crate(crossbeam-utils/default) < 0.9.0~) (crate(parking_lot/default) >= 0.12.0 with crate(parking_lot/default) < 0.13.0~) (crate(portable-atomic/default) >= 1.6.0 with crate(portable-atomic/default) < 2.0.0~) (crate(smallvec/default) >= 1.8.0 with crate(smallvec/default) < 2.0.0~) (crate(tagptr/default) >= 0.2.0 with crate(tagptr/default) < 0.3.0~) (crate(thiserror/default) >= 1.0.0 with crate(thiserror/default) < 2.0.0~) (crate(uuid/default) >= 1.1.0 with crate(uuid/default) < 2.0.0~) (crate(uuid/v4) >= 1.1.0 with crate(uuid/v4) < 2.0.0~) cargo rust rust-moka+default-devel (rpmlib, GLIBC filtered): cargo crate(moka) rust-moka+async-lock-devel (rpmlib, GLIBC filtered): (crate(async-lock/default) >= 3.3.0 with crate(async-lock/default) < 4.0.0~) cargo crate(moka) rust-moka+event-listener-devel (rpmlib, GLIBC filtered): (crate(event-listener/default) >= 5.3.0 with crate(event-listener/default) < 6.0.0~) cargo crate(moka) rust-moka+future-devel (rpmlib, GLIBC filtered): cargo crate(moka) crate(moka/async-lock) crate(moka/event-listener) crate(moka/futures-util) rust-moka+futures-util-devel (rpmlib, GLIBC filtered): (crate(futures-util/default) >= 0.3.17 with crate(futures-util/default) < 0.4.0~) cargo crate(moka) rust-moka+log-devel (rpmlib, GLIBC filtered): (crate(log/default) >= 0.4.0 with crate(log/default) < 0.5.0~) cargo crate(moka) rust-moka+logging-devel (rpmlib, GLIBC filtered): cargo crate(moka) crate(moka/log) rust-moka+once_cell-devel (rpmlib, GLIBC filtered): (crate(once_cell/default) >= 1.7.0 with crate(once_cell/default) < 2.0.0~) cargo crate(moka) rust-moka+quanta-devel (rpmlib, GLIBC filtered): (crate(quanta/default) >= 0.12.2 with crate(quanta/default) < 0.13.0~) cargo crate(moka) rust-moka+sync-devel (rpmlib, GLIBC filtered): cargo crate(moka) Provides -------- rust-moka-devel: crate(moka) rust-moka-devel rust-moka+default-devel: crate(moka/default) rust-moka+default-devel rust-moka+async-lock-devel: crate(moka/async-lock) rust-moka+async-lock-devel rust-moka+event-listener-devel: crate(moka/event-listener) rust-moka+event-listener-devel rust-moka+future-devel: crate(moka/future) rust-moka+future-devel rust-moka+futures-util-devel: crate(moka/futures-util) rust-moka+futures-util-devel rust-moka+log-devel: crate(moka/log) rust-moka+log-devel rust-moka+logging-devel: crate(moka/logging) rust-moka+logging-devel rust-moka+once_cell-devel: crate(moka/once_cell) rust-moka+once_cell-devel rust-moka+quanta-devel: crate(moka/quanta) rust-moka+quanta-devel rust-moka+sync-devel: crate(moka/sync) rust-moka+sync-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2393703 -L /home/pemensik/upstream/rust/tagptr/results_rust-tagptr/0.2.0/3.fc44/ Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: SugarActivity, fonts, Ocaml, Haskell, Java, R, Python, Perl, PHP, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Built with local dependencies: /home/pemensik/upstream/rust/tagptr/results_rust-tagptr/0.2.0/3.fc44/rust-tagptr-devel-0.2.0-3.fc44.noarch.rpm /home/pemensik/upstream/rust/tagptr/results_rust-tagptr/0.2.0/3.fc44/rust-tagptr+default-devel-0.2.0-3.fc44.noarch.rpm /home/pemensik/upstream/rust/tagptr/results_rust-tagptr/0.2.0/3.fc44/rust-tagptr-0.2.0-3.fc44.src.rpm
I have not found anything to fix or suggest. License matches, changes have references to upstream issues or PR, spec is autogenerated by automated tool. It is a library, no transitive licenses of dependencies are needed. Seem perfect to me, good job Ben!
Thank you for the review! Let me know if you have any particular plans to coordinate this with any other updates into stable branches. I want to proceed with https://src.fedoraproject.org/rpms/rust-brotli/pull-request/2#comment-281957 soon, but I do need to coordinate with Fabio Valentini on getting rust-hickory-{proto,resolver}0.24 compat packages requested. https://release-monitoring.org/project/383600/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-moka
Dependency rust-tagptr is built in rawhide and updates pending for f43 and f42. Would you like to have side-tag builds instead?
FEDORA-2025-2f7bc22214 (rust-moka-0.12.10-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-2f7bc22214
FEDORA-2025-2f7bc22214 (rust-moka-0.12.10-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
(In reply to Petr Menšík from comment #9) > Dependency rust-tagptr is built in rawhide and updates pending for f43 and > f42. Would you like to have side-tag builds instead? Yes, but I should be able to take care of it myself. I will tag the existing rust-tagptr builds for F42 and F43 into new side tags, build everything else I need (https://src.fedoraproject.org/rpms/rust-brotli/pull-request/2#comment-281957), unpush the existing single-build updates, and create new updates from the side tags. When I’m done, I’ll let you know what the side tags are in case you want to add anything before they reach stable. I’ll also make updates for F41, the EPEL10 leading branch, and EPEL9.
FEDORA-2025-62187f3aba (rust-async-compression-0.4.19-3.fc43, rust-brotli-8.0.2-2.fc43, and 14 more) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-62187f3aba
FEDORA-2025-03ccf34621 (rust-async-compression-0.4.19-3.fc42, rust-brotli-8.0.2-2.fc42, and 14 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-03ccf34621
FEDORA-2025-446e48e16b (rust-async-compression-0.4.19-3.fc41, rust-brotli-8.0.2-2.fc41, and 16 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-446e48e16b
FEDORA-EPEL-2025-2ce0610082 (rust-async-compression-0.4.19-3.el9, rust-brotli-8.0.2-2.el9, and 11 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-2ce0610082
FEDORA-2025-03ccf34621 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-03ccf34621` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-03ccf34621 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-446e48e16b has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-446e48e16b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-446e48e16b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-2ce0610082 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-2ce0610082 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-62187f3aba has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-62187f3aba` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-62187f3aba See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-4a044a54df (rust-async-compression-0.4.19-3.el10_2, rust-brotli-8.0.2-2.el10_2, and 11 more) has been submitted as an update to Fedora EPEL 10.2. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-4a044a54df
FEDORA-EPEL-2025-4a044a54df has been pushed to the Fedora EPEL 10.2 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-4a044a54df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-62187f3aba (rust-async-compression-0.4.19-3.fc43, rust-brotli-8.0.2-2.fc43, and 14 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-03ccf34621 (rust-async-compression-0.4.19-3.fc42, rust-brotli-8.0.2-2.fc42, and 14 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-2ce0610082 (rust-async-compression-0.4.19-3.el9, rust-brotli-8.0.2-2.el9, and 11 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-446e48e16b (rust-async-compression-0.4.19-3.fc41, rust-brotli-8.0.2-2.fc41, and 16 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-4a044a54df (rust-async-compression-0.4.19-3.el10_2, rust-brotli-8.0.2-2.el10_2, and 11 more) has been pushed to the Fedora EPEL 10.2 stable repository. If problem still persists, please make note of it in this bug report.