Spec URL: https://music.fedorapeople.org/python-cucumber-tag-expressions.spec SRPM URL: https://music.fedorapeople.org/python-cucumber-tag-expressions-6.2.0-1.fc42.src.rpm Description: Cucumber tag-expressions provide readable boolean expressions to select features and scenarios marked with tags in Gherkin files in an easy way. Fedora Account System Username: music
Copr build: https://copr.fedorainfracloud.org/coprs/build/9550651 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394789-python-cucumber-tag-expressions/fedora-rawhide-x86_64/09550651-python-cucumber-tag-expressions/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 133 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-cucumber- tag-expressions/2394789-python-cucumber-tag- expressions/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/python-cucumber-tag- expressions/general, /usr/share/doc/python-cucumber-tag-expressions [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14, /usr/share/doc/python-cucumber-tag- expressions, /usr/share/doc/python-cucumber-tag-expressions/general [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 17697 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-cucumber-tag-expressions-6.2.0-1.fc44.noarch.rpm python-cucumber-tag-expressions-6.2.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpx3mxjvg0')] checks: 32, packages: 2 python-cucumber-tag-expressions.spec: W: patch-not-applied Patch0: 0001-Downstream-only-omit-pytest-options-for-pytest-html.patch 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 7 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/cucumber/tag-expressions/archive/v6.2.0/tag-expressions-6.2.0.tar.gz : CHECKSUM(SHA256) this package : 05f0fcb1bdbaad21d8645eb99205b8481716afa8a76e778e90b192e6118298b9 CHECKSUM(SHA256) upstream package : 05f0fcb1bdbaad21d8645eb99205b8481716afa8a76e778e90b192e6118298b9 Requires -------- python3-cucumber-tag-expressions (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-cucumber-tag-expressions: python-cucumber-tag-expressions python3-cucumber-tag-expressions python3.14-cucumber-tag-expressions python3.14dist(cucumber-tag-expressions) python3dist(cucumber-tag-expressions) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2394789 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: PHP, Haskell, C/C++, fonts, R, Perl, Ocaml, Java, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Applying the patch: https://github.com/cucumber/tag-expressions/pull/211 would allow license metadata to be pulled in b) Please ensure documentation directories are owned. c) BR on python3-devel is not needed with the used packaging macros d) Approved. Please fix at least (b) before import. e) Review of https://bugzilla.redhat.com/show_bug.cgi?id=2397149 would be appreciated if time allows.
Thank you for the review! https://release-monitoring.org/project/54456/ > a) Applying the patch: > https://github.com/cucumber/tag-expressions/pull/211 > would allow license metadata to be pulled in Thank you for the contribution! Since the patch isn’t urgent, I’ll wait for upstream review. > b) Please ensure documentation directories are owned Oops! Thank you. I’ll fix that on import. > c) BR on python3-devel is not needed with the used packaging macros > d) Approved. Please fix at least (b) before import. > e) Review of > https://bugzilla.redhat.com/show_bug.cgi?id=2397149 > would be appreciated if time allows. Reviewed.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cucumber-tag-expressions
FEDORA-2025-72018fc85b (python-cucumber-tag-expressions-6.2.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-72018fc85b
FEDORA-2025-72018fc85b (python-cucumber-tag-expressions-6.2.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-c0b39cbd53 (python-cucumber-tag-expressions-6.2.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c0b39cbd53
FEDORA-2025-7f2dbc127e (python-cucumber-tag-expressions-6.2.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-7f2dbc127e
FEDORA-2025-7f2dbc127e has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7f2dbc127e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7f2dbc127e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-c0b39cbd53 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c0b39cbd53 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c0b39cbd53 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-77d44a610a (python-cucumber-tag-expressions-6.2.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-77d44a610a
FEDORA-EPEL-2025-64b3a8b2ed (python-cucumber-tag-expressions-6.2.0-2.el10_2) has been submitted as an update to Fedora EPEL 10.2. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-64b3a8b2ed
FEDORA-EPEL-2025-64b3a8b2ed has been pushed to the Fedora EPEL 10.2 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-64b3a8b2ed See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-77d44a610a has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-77d44a610a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-77d44a610a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-e9db3b5e27 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e9db3b5e27 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e9db3b5e27 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-c073849a27 has been pushed to the Fedora EPEL 10.2 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c073849a27 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-f66a0f21c6 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f66a0f21c6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f66a0f21c6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-2dcff1fdb8 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2dcff1fdb8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2dcff1fdb8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-c073849a27 (python-cucumber-tag-expressions-7.0.0-1.el10_2) has been pushed to the Fedora EPEL 10.2 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-e9db3b5e27 (python-cucumber-tag-expressions-7.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-2dcff1fdb8 (python-cucumber-tag-expressions-7.0.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-f66a0f21c6 (python-cucumber-tag-expressions-7.0.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.