Bug 2395004 - Review Request: python-cupy-rocm - NumPy & SciPy for GPU
Summary: Review Request: python-cupy-rocm - NumPy & SciPy for GPU
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://cupy.dev/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-09-14 00:00 UTC by Tom.Rix
Modified: 2025-10-25 23:53 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
Tom.Rix: fedora-review?


Attachments (Terms of Use)
The .spec file difference from Copr build 9553806 to 9554961 (3.31 KB, patch)
2025-09-14 17:39 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 9571391 to 9732897 (1.21 KB, patch)
2025-10-25 23:53 UTC, Fedora Review Service
no flags Details | Diff

Description Tom.Rix 2025-09-14 00:00:45 UTC
Spec URL: https://trix.fedorapeople.org/python-cupy.spec
SRPM URL: https://trix.fedorapeople.org/python-cupy-13.6.0-1.fc44.src.rpm

CuPy is a NumPy/SciPy-compatible array library for GPU-accelerated
computing with Python. CuPy acts as a drop-in replacement to run
existing NumPy/SciPy code on AMD ROCm platforms

Reproducible: Always

Comment 1 Fedora Review Service 2025-09-14 01:09:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9553806
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395004-python-cupy/fedora-rawhide-x86_64/09553806-python-cupy/fedora-review/review.txt

Found issues:

- python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_dlpack/dlpack.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/arithmetic.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrig.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrigf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccosh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccoshf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexp.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexpf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clog.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clogf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex_inl.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cpow.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cproj.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinhf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrt.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrtf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanhf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/math_private.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/namespace.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuComplex_bridge.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuda_workaround.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/math_constants.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufft.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufftXt.h python3-cupy : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_2d.h python3-cupy : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_3d.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jonathan Steffan 2025-09-14 14:32:26 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: python3-cupy : /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/_dlpack/dlpack.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/arithmetic.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/catrig.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/catrigf.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/ccosh.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/ccoshf.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/cexp.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/cexpf.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/clog.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/clogf.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/complex.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/complex_inl.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/cpow.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/cproj.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/csinh.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/csinhf.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/csqrt.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/csqrtf.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/ctanh.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/ctanhf.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/math_private.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/complex/namespace.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/cuComplex_bridge.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/cuda_workaround.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupy/_core/include/cupy/math_constants.h python3-cupy :
  /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufft.h python3-cupy :
  /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufftXt.h python3-cupy
  : /usr/lib64/python3.14/site-
  packages/cupyx/scipy/ndimage/cuda/pba_kernels_2d.h python3-cupy :
  /usr/lib64/python3.14/site-
  packages/cupyx/scipy/ndimage/cuda/pba_kernels_3d.h
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[!]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "*No copyright* Apache License 2.0", "BSD
     3-Clause License", "BSD 3-Clause License and/or MIT License", "Unknown
     or generated", "Boost Software License 1.0", "Apache License 2.0",
     "Apache License 2.0 and/or BSD 2-Clause License". 840 files have
     unknown license. Detailed output of licensecheck in
     /home/jon/Reviews/python-cupy/licensecheck.txt
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/python3.14,
     /usr/lib64/python3.14/site-packages
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[!]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: python3-cupy-13.6.0-1.fc44.x86_64.rpm
          python-cupy-13.6.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpywyyt7oe')]
checks: 32, packages: 2

python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi
python3-cupy.x86_64: W: no-soname /usr/lib64/python3.14/site-packages/cupy/lib/_polynomial.cpython-314-x86_64-linux-gnu.so
python3-cupy.x86_64: W: no-documentation
python-cupy.spec:108: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 108)
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_dlpack/dlpack.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_jitify/jitify.hpp
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/arithmetic.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrig.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrigf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccosh.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccoshf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexp.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexpf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clog.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clogf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex_inl.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cpow.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cproj.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinh.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinhf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrt.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrtf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanh.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanhf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/math_private.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/namespace.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuComplex_bridge.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuda_workaround.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/math_constants.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufft.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufftXt.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_2d.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_3d.h
python3-cupy.x86_64: E: devel-dependency hipblas-devel
 2 packages and 0 specfiles checked; 2 errors, 33 warnings, 18 filtered, 2 badness; has taken 7.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi
python3-cupy.x86_64: W: no-soname /usr/lib64/python3.14/site-packages/cupy/lib/_polynomial.cpython-314-x86_64-linux-gnu.so
python3-cupy.x86_64: W: no-documentation
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_dlpack/dlpack.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_jitify/jitify.hpp
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/arithmetic.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrig.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrigf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccosh.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccoshf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexp.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexpf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clog.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clogf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex_inl.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cpow.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cproj.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinh.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinhf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrt.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrtf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanh.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanhf.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/math_private.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/namespace.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuComplex_bridge.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuda_workaround.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/math_constants.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufft.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufftXt.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_2d.h
python3-cupy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_3d.h
python3-cupy.x86_64: E: devel-dependency hipblas-devel
 1 packages and 0 specfiles checked; 2 errors, 32 warnings, 14 filtered, 2 badness; has taken 3.4 s 



Unversioned so-files
--------------------
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_accelerator.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_carray.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_cub_reduction.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_dtype.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_fusion_kernel.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_fusion_thread_local.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_fusion_trace.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_fusion_variable.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_kernel.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_memory_range.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_optimize_config.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_reduction.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_binary.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_indexing.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_linalg.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_logic.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_manipulation.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_math.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_sorting.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_routines_statistics.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/_scalar.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/core.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/dlpack.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/flags.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/fusion.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/internal.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/new_fusion.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/numpy_allocator.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_core/raw.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/_util.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/common.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/cub.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/cufft.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/device.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/function.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/graph.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/memory.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/memory_hook.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/pinned_memory.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/stream.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/texture.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/cuda/thrust.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/fft/_cache.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/fft/_callback.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/lib/_polynomial.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/random/_bit_generator.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy/random/_generator_api.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/_softlink.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/api/_driver_enum.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/api/_runtime_enum.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/api/driver.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/api/runtime.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/libs/cublas.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/libs/curand.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/libs/cusolver.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/libs/cusparse.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/libs/nccl.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/libs/nvrtc.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/libs/nvtx.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupy_backends/cuda/stream.cpython-314-x86_64-linux-gnu.so
python3-cupy: /usr/lib64/python3.14/site-packages/cupyx/cusolver.cpython-314-x86_64-linux-gnu.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/c/cupy/cupy-13.6.0.tar.gz :
  CHECKSUM(SHA256) this package     : 3cba30ae3dd32b5d5c6536e710cb98015227cd4ba83c46b3f1825a7ae55b6667
  CHECKSUM(SHA256) upstream package : 3cba30ae3dd32b5d5c6536e710cb98015227cd4ba83c46b3f1825a7ae55b6667


Requires
--------
python3-cupy (rpmlib, GLIBC filtered):
    (python3.14dist(numpy) < 2.6~~ with python3.14dist(numpy) >= 1.22)
    hipblas-devel
    hipcub-devel
    hipfft-devel
    hiprand-devel
    hipsolver-devel
    hipsparse-devel
    libamdhip64.so.6()(64bit)
    libamdhip64.so.6(hip_4.2)(64bit)
    libamdhip64.so.6(hip_4.3)(64bit)
    libamdhip64.so.6(hip_6.0)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhipblas.so.2()(64bit)
    libhipfft.so.0()(64bit)
    libhiprand.so.1()(64bit)
    libhipsparse.so.1()(64bit)
    libm.so.6()(64bit)
    librccl.so.1()(64bit)
    librocblas.so.4()(64bit)
    librocsolver.so.0()(64bit)
    libroctx64.so.4()(64bit)
    libroctx64.so.4(ROCTX_4.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    python(abi)
    python3.14dist(fastrlock)
    rccl-devel
    rocblas-devel
    rocfft-devel
    rocm-comgr-devel
    rocm-hip-devel
    rocm-runtime-devel
    rocrand-devel
    rocsolver-devel
    rocsparse-devel
    rocthrust-devel
    roctracer-devel
    rtld(GNU_HASH)



Provides
--------
python3-cupy:
    python-cupy
    python3-cupy
    python3-cupy(x86-64)
    python3.14-cupy
    python3.14dist(cupy)
    python3dist(cupy)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -r -n python-cupy-13.6.0-1.fc44.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Python, Shell-api
Disabled plugins: SugarActivity, Haskell, PHP, Ocaml, fonts, Perl, Java, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 3 Jonathan Steffan 2025-09-14 14:38:45 UTC
[!]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

This appears to be fine.

[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.

Add some additional explanation of which license covers which paths.

[!]: Development files must be in a -devel package

This appears to be fine.

[!]: Package is not known to require an ExcludeArch tag.

Noting this does require x86_64 only.

[x]: Package meets the Packaging Guidelines::Python

Missed this. Good to go.

[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.

Link to bugs resolving the missing license files.

[!]: Package does not include license text files separate from upstream.

Should be included in the project upstream.

[!]: Packages should try to preserve timestamps of original installed
     files.

Add -p to your cp.

python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi

Does this need to be deleted?

python-cupy.spec:108: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 108)

Please resolve.

python3-cupy.x86_64: E: devel-dependency hipblas-devel

I think the note in the spec is good to cover this.

Comment 4 Tom.Rix 2025-09-14 16:18:38 UTC
Spec URL: https://trix.fedorapeople.org/python-cupy.spec
SRPM URL: https://trix.fedorapeople.org/python-cupy-13.6.0-1.fc44.src.rpm

For the update
The changes


>> [!]: If the package is under multiple licenses, the licensing breakdown
>>     must be documented in the spec.
>>
>> Add some additional explanation of which license covers which paths.

The license tag is more explict now, I believe all the files in the license check are covered
License:        MIT AND BSD-3-Clause AND Apache-2.0 AND BSL-1.0 AND BSD-2-Clause
# LICENSE : MIT
# Is the main license for the project
#
# docs/source/license.rst
# Is a attribution breakdown of where parts of the cupy project came from
#   NumPy - BSD-3-Clause
#   SciPy - BSD-3-Clause
#     cupyx/scipy/*
#   cuSignal - MIT
#     cupyx/signal/*
#
# LICENSE.thrust : Apache-2.0 AND BSL-1.0 AND BSD-2-Clause
# Covers these files
# cupy/_core/include/cupy/complex/*
#
# LICENSE.jitify : BSD-3-Clause
# Covers this file
# cupy/_core/include/cupy/_jitify/jitify.hpp
#
# LICENSE.random : BSD-3-Clause AND MIT
# covers this file cupy/random/_kernels.py
#
# LICENSE.ndimage : MIT
# covers cupyx/scipy/ndimage/cuda/*.h
#
# Misc file not covered by the LICENSE.* files
# cupyx/scipy/special/_digamma.py BSL-1.0
#

>> [!]: If the source package does not include license text(s) as a separate
>>     file from upstream, the packager SHOULD query upstream to include it.
>>
>> Link to bugs resolving the missing license files.

The devel project does cover these license files, they are only missing from pypi.
I improved the original comments and opened an issue upstream

# Upstream for both of these license files
# https://github.com/cupy/cupy/issues/9387
#
# Files in _core/include/cupy/complex come from thrust
# Here is its location in the devel project where thrust is a submodule
# https://github.com/NVIDIA/cccl/blob/3a388b7b01512d48474b98389a3e776c8d8f817a/thrust/LICENSE
Source1:        LICENSE.thrust
# The license listed from
# cupy/random/_kernels.py
# Here is its location in the devel project
# https://github.com/cupy/cupy/blob/main/cupy/random/LICENSE
Source2:        LICENSE.random

>> [!]: Packages should try to preserve timestamps of original installed
>>     files.
>>
>> Add -p to your cp.

# Apache-2.0 AND BSL-1.0 AND BSD-2-Clause
cp -p %{SOURCE1}                           LICENSE.thrust
# BSD-3-Clause AND MIT
cp -p %{SOURCE2}                           LICENSE.random

>> python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi
>>
>> Does this need to be deleted?

# python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi
%exclude %{python3_sitearch}/cupy/_util.pyi

>> python-cupy.spec:108: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 108)
>>
>> Please resolve.

Done

Comment 5 Fedora Review Service 2025-09-14 17:39:00 UTC
Created attachment 2106619 [details]
The .spec file difference from Copr build 9553806 to 9554961

Comment 6 Fedora Review Service 2025-09-14 17:39:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9554961
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395004-python-cupy/fedora-rawhide-x86_64/09554961-python-cupy/fedora-review/review.txt

Found issues:

- python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_dlpack/dlpack.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/arithmetic.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrig.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrigf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccosh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccoshf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexp.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexpf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clog.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clogf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex_inl.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cpow.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cproj.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinhf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrt.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrtf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanhf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/math_private.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/namespace.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuComplex_bridge.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuda_workaround.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/math_constants.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufft.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufftXt.h python3-cupy : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_2d.h python3-cupy : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_3d.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 kmaehashi 2025-09-17 08:35:25 UTC
Hello, and thank you for packaging CuPy for EPEL and Fedora. I'm a project lead for the CuPy project.

As you may already know, CuPy supports both NVIDIA CUDA and AMD ROCm GPUs, with the backend selected at build time. Based on this bug, it appears you plan to build CuPy for AMD and publish it as the `python-cupy` package. I believe this could be strongly confusing for users, as the backend is not indicated in the name.

I would like to suggest renaming this package to `python-cupy-rocm`. This is clearer and leaves room for a future package built for NVIDIA CUDA. This also aligns with our PyPI naming convention, which appends the GPU platform to the package name: https://github.com/cupy/cupy/?tab=readme-ov-file#pip

Thanks again, and I'm happy to help with any details.

Comment 8 Jonathan Steffan 2025-09-17 12:31:59 UTC
I tend to agree.

Maybe we need:

* python-cupy - common
* python-cupy-libs - shared libs
* python-cupy-rocm - current rocm support (matches whatever is in Fedora)
* python-cupy-cudaX - future reserved :)

Or something like that?

Comment 9 kmaehashi 2025-09-17 14:59:11 UTC
I'd rather suggest just packaging into single RPM package. Most of shared libraries and files in CuPy are built specifically for each GPU platform.

Comment 10 Tom.Rix 2025-09-17 17:43:43 UTC
There are no cuda libraries in fedora atm.
Is that going to change in the next 6 months ?

Comment 11 kmaehashi 2025-09-18 04:36:28 UTC
I am not affiliated with NVIDIA and cannot comment on CUDA packaging.

From the CuPy project's perspective, we would prefer the package names `python-cupy-rocm` and `python-cupy-cuda` (once CUDA libraries are available for Fedora) to provide the best user experience. At least as of now, CuPy is used primarily with CUDA, so I believe it is surprising to users that running `dnf install python-cupy` installs the ROCm build.

Comment 12 Jonathan Steffan 2025-09-18 12:19:16 UTC
(In reply to kmaehashi from comment #9)
> I'd rather suggest just packaging into single RPM package. Most of shared
> libraries and files in CuPy are built specifically for each GPU platform.

My comment was discussing possible rpm package layout using subpackages. It would all build from the same source.

I agree that it would be confusing to users to install "cupy" and not have the support that was expected.

Does the import syntax change based on what hardware you are utilizing?

Comment 13 Tom.Rix 2025-09-18 14:14:56 UTC
My comment gets to a fundamental problem with building fedora packages with cuda on fedora. Because the cuda libraries are not available on fedora, we can not build packages that depend on them.  The build must be self contained to use what is available in fedora. So no user would expect cuda to be used, or at least have the same disappointment as with any other package that could be built with cuda.

since there going to be no cuda backend, there is no need to split the package.

Comment 14 kmaehashi 2025-09-18 15:49:49 UTC
Regardless of whether packaging for CUDA is feasible, as the upstream project we ask that you avoid naming the ROCm build of CuPy `python3-cupy`. This naming is confusing, and we are the ones who ultimately bear the support burden.

(In reply to Jonathan Steffan from comment #12)
> Does the import syntax change based on what hardware you are utilizing?

No, APIs are fully consistent between CUDA/ROCm builds.

Comment 15 Tom.Rix 2025-09-18 21:19:00 UTC
Spec URL: https://trix.fedorapeople.org/python-cupy-rocm.spec
SRPM URL: https://trix.fedorapeople.org/python-cupy-rocm-13.6.0-1.fc44.src.rpm

Changing the package name to python-cupy-rocm as suggested.

Comment 16 Fedora Review Service 2025-09-18 22:45:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9571391
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395004-python-cupy-rocm/fedora-rawhide-x86_64/09571391-python-cupy-rocm/fedora-review/review.txt

Found issues:

- python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_dlpack/dlpack.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/arithmetic.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrig.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrigf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccosh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccoshf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexp.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexpf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clog.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clogf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex_inl.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cpow.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cproj.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinhf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrt.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrtf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanh.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanhf.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/math_private.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/namespace.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuComplex_bridge.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuda_workaround.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/math_constants.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufft.h python3-cupy : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufftXt.h python3-cupy : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_2d.h python3-cupy : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_3d.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 18 Fedora Review Service 2025-10-25 23:53:06 UTC
Created attachment 2110831 [details]
The .spec file difference from Copr build 9571391 to 9732897

Comment 19 Fedora Review Service 2025-10-25 23:53:09 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9732897
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395004-python-cupy-rocm/fedora-rawhide-x86_64/09732897-python-cupy-rocm/fedora-review/review.txt

Found issues:

- python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/_dlpack/dlpack.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/arithmetic.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrig.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/catrigf.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccosh.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ccoshf.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexp.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cexpf.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clog.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/clogf.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/complex_inl.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cpow.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/cproj.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinh.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csinhf.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrt.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/csqrtf.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanh.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/ctanhf.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/math_private.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/complex/namespace.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuComplex_bridge.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/cuda_workaround.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/_core/include/cupy/math_constants.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufft.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupy/cuda/cupy_cufftXt.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_2d.h python3-cupy-rocm : /usr/lib64/python3.14/site-packages/cupyx/scipy/ndimage/cuda/pba_kernels_3d.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.