I propose a package for Cpdf, the command line tool for processing PDF files. It is based on the recently-approved CamlPDF package discussed here: https://bugzilla.redhat.com/show_bug.cgi?id=2363088 The bug is structured as the usual two subpackages for the library (ocaml-cpdf and ocaml-cpdf-devel) plus a separate subpackage for the Cpdf command line tool itself. Spec URL: https://coherentpdf.com/fedora/ocaml-cpdf.spec Patch file: https://coherentpdf.com/fedora/patch.patch Build log: https://coherentpdf.com/fedora/build.log SRPM URL: https://coherentpdf.com/fedora/ocaml-cpdf-2.8.1-1.fc41.src.rpm Fedora Account System Username: johnwhitington Description: PDF command line tools Lint output: ocaml-cpdf-devel.x86_64: E: static-library-without-debuginfo/usr/Lib64/ocaml/cpdf/cpdf.a ocaml-cpdf-devel.x86_64: W: no-documentation cpdf.x86_64: W: description-shorter-than-summary ocaml-cpdf.src: W: description-shorter-than-summary ocaml-cpdf.x86_64: W: description-shorter-than-summary There is no Koji build because it depends on CamlPDF which Koji can't access yet. Here's how I built it here: 1. Ran rpmbuild on the CamlPDF SRPM to build the binary RPMS 2. Used --extra-pkgs when running the mockbuild for this package: $ fedokg -release f41 mockbuild --extra-pkgs /home/osboxes/rpmbuild/RPMS/x86_64/ocaml-camlpdf-2.8.1-1.fc41.x86 /home/osboxes/rombuild/RPMS/x8664/ocaml-camlodf-devel-2.8.1-1.fc41.x86 It succeeds in building the new Cpdf SRPM but then seems to starts again and complains at the end that it has failed. Anyway, this is where I've got to after a few sessions working on this, so I thought it was time for someone more informed to take a look at it.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9556841 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2395215-ocaml-cpdf/fedora-rawhide-x86_64/09556841-ocaml-cpdf/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I will take this review. Could you possibly review bug 2391039 for me in exchange?
It appears that you haven't built ocaml-camlpdf yet. It was approved. Are you waiting for something? Having it in the repository would make this review easier.
Indeed not. I didn't know it was within my power... Perhaps I misunderstood your reference to RMWJ's list of packages. Can you point me in the right direction?
Oh, you're not in the packager group. From the exchange between you and RMWJ on the ocaml-camlpdf bug, I assumed that you were. You need a sponsor, who will tell you stuff like this. :-) If you haven't found it already, https://docs.fedoraproject.org/en-US/package-maintainers/ is a treasure trove of resources for packagers, and includes a link to the guide for becoming a packager: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/. I'm happy to be your sponsor. Will you go through the list of things to do to join the packager group and make sure you've addressed each one? That includes introducing yourself on fedora-devel-list, if you haven't already. We should probably move the rest of this conversation to email. Please reach out to me at loganjerry once you've worked your way through that list (or if any item on the list gives you trouble) and we'll discuss next steps.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - The files cpdfunicodedata* seem to be under the Unicode-DFS-2015 license. That does not appear in the License tag (nor in README.md, I might add, where the other licenses are listed). - Please replace all occurrences of /usr/bin with %{_bindir}, and all occurrences of /usr/share/man with %{_mandir}. See https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation - In %files for cpdf, do not specify the .gz suffix for the man page. Fedora currently uses gzip to compress man pages, but may change that at some future date. Use a glob there instead: %{_mandir}/man1/cpdf.1* See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages - Do I understand correctly that cpdfyojson.* is a bundled version of ocaml-yojson, and cpdfxmlm.* is a bundled version of ocaml-xmlm? If so, can they be unbundled? If not, then appropriate "Provided: bundled(foo)" lines must be added to the spec file, and I personally would prefer to see a comment in the spec file explaining why they can't be unbundled. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling - Note the description-shorter-than-summary warnings below from rpmlint. The Summary should be a short description of the package; %description should be a full description. If %summary is longer than %description, something is wrong. - %check is empty. Is there anything that could be done there, some manipulation of one of the includes PDF files perhaps, just to verify that it runs at all? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Affero General Public License v3.0", "GNU Affero General Public License", "*No copyright* GNU Affero General Public License v3.0", "Unicode License Agreement - Data Files and Software (2015)", "ISC License", "BSD 3-Clause License". 351 files have unknown license. License Unicode-DFS-2015 is missing. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. Both ocaml-yojson and ocaml-xmlm appear to be bundled. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). Hardcoded uses of /usr/bin and /usr/share/man appear in the spec file. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. Although note that cpdfyojson.ml does not appear in ocaml-cpdf-debugsource! Was it compiled without debuginfo somewhere? [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 474668 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: %check is present and all tests pass. %check is present but empty [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ocaml-cpdf-2.8.1-1.fc44.x86_64.rpm ocaml-cpdf-devel-2.8.1-1.fc44.x86_64.rpm cpdf-2.8.1-1.fc44.x86_64.rpm ocaml-cpdf-2.8.1-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpye03db77')] checks: 32, packages: 4 ocaml-cpdf-devel.x86_64: W: no-documentation cpdf.x86_64: W: description-shorter-than-summary ocaml-cpdf.src: W: description-shorter-than-summary ocaml-cpdf.x86_64: W: description-shorter-than-summary 4 packages and 0 specfiles checked; 0 errors, 4 warnings, 14 filtered, 0 badness; has taken 1.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 ocaml-cpdf-devel.x86_64: W: no-documentation ocaml-cpdf.x86_64: W: description-shorter-than-summary cpdf.x86_64: W: description-shorter-than-summary 3 packages and 0 specfiles checked; 0 errors, 3 warnings, 10 filtered, 0 badness; has taken 0.6 s Source checksums ---------------- https://github.com/johnwhitington/cpdf-source/archive/v2.8.1/cpdf-source-2.8.1.tar.gz : CHECKSUM(SHA256) this package : f890a887fa6858667428293075b301bdee57faa143d39bd89520dc8e8c806b8b CHECKSUM(SHA256) upstream package : bdd7caf1e5e55e65e4ece96eeeb3e5894c195ca5a9a274ddc27ac50a321d5c75 However, diff -r shows no differences Requires -------- ocaml-cpdf (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Cpdfaddtext) ocaml(Cpdfannot) ocaml(Cpdfattach) ocaml(Cpdfbookmarks) ocaml(Cpdfchop) ocaml(Cpdfcolours) ocaml(Cpdfcommand) ocaml(Cpdfcomposition) ocaml(Cpdfcoord) ocaml(Cpdfcreate) ocaml(Cpdfdraft) ocaml(Cpdfdraw) ocaml(Cpdfdrawcontrol) ocaml(Cpdfembed) ocaml(Cpdferror) ocaml(Cpdfextracttext) ocaml(Cpdffont) ocaml(Cpdfimage) ocaml(Cpdfimpose) ocaml(Cpdfjpeg) ocaml(Cpdfjpeg2000) ocaml(Cpdfjson) ocaml(Cpdfmetadata) ocaml(Cpdfocg) ocaml(Cpdfpad) ocaml(Cpdfpage) ocaml(Cpdfpagelabels) ocaml(Cpdfpagespec) ocaml(Cpdfpng) ocaml(Cpdfposition) ocaml(Cpdfpresent) ocaml(Cpdfprinttree) ocaml(Cpdfremovetext) ocaml(Cpdfshape) ocaml(Cpdfspot) ocaml(Cpdfsqueeze) ocaml(Cpdfstrftime) ocaml(Cpdftexttopdf) ocaml(Cpdftoc) ocaml(Cpdftruetype) ocaml(Cpdftweak) ocaml(Cpdftype) ocaml(Cpdfua) ocaml(Cpdfunicodedata) ocaml(Cpdfutil) ocaml(Cpdfxmlm) ocaml(Cpdfxobject) ocaml(Cpdfyojson) ocaml(Pdf) ocaml(Pdfannot) ocaml(Pdfcmap) ocaml(Pdfcodec) ocaml(Pdfcrypt) ocaml(Pdfcryptprimitives) ocaml(Pdfdest) ocaml(Pdfe) ocaml(Pdffun) ocaml(Pdfgenlex) ocaml(Pdfglyphlist) ocaml(Pdfimage) ocaml(Pdfio) ocaml(Pdfmarks) ocaml(Pdfmerge) ocaml(Pdfops) ocaml(Pdfpage) ocaml(Pdfpagelabels) ocaml(Pdfpaper) ocaml(Pdfread) ocaml(Pdfspace) ocaml(Pdfst) ocaml(Pdfstandard14) ocaml(Pdftext) ocaml(Pdftransform) ocaml(Pdftree) ocaml(Pdfunits) ocaml(Pdfutil) ocaml(Pdfwrite) ocaml(Stdlib) ocaml(Stdlib__Arg) ocaml(Stdlib__Array) ocaml(Stdlib__Bigarray) ocaml(Stdlib__Buffer) ocaml(Stdlib__Bytes) ocaml(Stdlib__Char) ocaml(Stdlib__Complex) ocaml(Stdlib__Digest) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Filename) ocaml(Stdlib__Float) ocaml(Stdlib__Format) ocaml(Stdlib__Fun) ocaml(Stdlib__Gc) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__Nativeint) ocaml(Stdlib__Obj) ocaml(Stdlib__Printexc) ocaml(Stdlib__Printf) ocaml(Stdlib__Random) ocaml(Stdlib__Seq) ocaml(Stdlib__String) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) ocaml-cpdf-devel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Cpdfaddtext) ocaml(Cpdfannot) ocaml(Cpdfattach) ocaml(Cpdfbookmarks) ocaml(Cpdfchop) ocaml(Cpdfcolours) ocaml(Cpdfcommand) ocaml(Cpdfcomposition) ocaml(Cpdfcoord) ocaml(Cpdfcreate) ocaml(Cpdfdraft) ocaml(Cpdfdraw) ocaml(Cpdfdrawcontrol) ocaml(Cpdfembed) ocaml(Cpdferror) ocaml(Cpdfextracttext) ocaml(Cpdffont) ocaml(Cpdfimage) ocaml(Cpdfimpose) ocaml(Cpdfjpeg) ocaml(Cpdfjpeg2000) ocaml(Cpdfjson) ocaml(Cpdfmetadata) ocaml(Cpdfocg) ocaml(Cpdfpad) ocaml(Cpdfpage) ocaml(Cpdfpagelabels) ocaml(Cpdfpagespec) ocaml(Cpdfpng) ocaml(Cpdfposition) ocaml(Cpdfpresent) ocaml(Cpdfprinttree) ocaml(Cpdfremovetext) ocaml(Cpdfshape) ocaml(Cpdfspot) ocaml(Cpdfsqueeze) ocaml(Cpdfstrftime) ocaml(Cpdftexttopdf) ocaml(Cpdftoc) ocaml(Cpdftruetype) ocaml(Cpdftweak) ocaml(Cpdftype) ocaml(Cpdfua) ocaml(Cpdfunicodedata) ocaml(Cpdfutil) ocaml(Cpdfxmlm) ocaml(Cpdfxobject) ocaml(Cpdfyojson) ocaml(Pdf) ocaml(Pdfannot) ocaml(Pdfcmap) ocaml(Pdfcodec) ocaml(Pdfcrypt) ocaml(Pdfcryptprimitives) ocaml(Pdfdest) ocaml(Pdfe) ocaml(Pdffun) ocaml(Pdfgenlex) ocaml(Pdfglyphlist) ocaml(Pdfimage) ocaml(Pdfio) ocaml(Pdfmarks) ocaml(Pdfmerge) ocaml(Pdfops) ocaml(Pdfpage) ocaml(Pdfpagelabels) ocaml(Pdfpaper) ocaml(Pdfread) ocaml(Pdfspace) ocaml(Pdfst) ocaml(Pdfstandard14) ocaml(Pdftext) ocaml(Pdftransform) ocaml(Pdftree) ocaml(Pdfunits) ocaml(Pdfutil) ocaml(Pdfwrite) ocaml(Stdlib) ocaml(Stdlib__Arg) ocaml(Stdlib__Array) ocaml(Stdlib__Bigarray) ocaml(Stdlib__Buffer) ocaml(Stdlib__Bytes) ocaml(Stdlib__Char) ocaml(Stdlib__Complex) ocaml(Stdlib__Digest) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Filename) ocaml(Stdlib__Float) ocaml(Stdlib__Format) ocaml(Stdlib__Fun) ocaml(Stdlib__Gc) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__Nativeint) ocaml(Stdlib__Obj) ocaml(Stdlib__Printexc) ocaml(Stdlib__Printf) ocaml(Stdlib__Random) ocaml(Stdlib__Seq) ocaml(Stdlib__String) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) ocaml-cpdf(x86-64) ocamlx(CamlinternalFormat) ocamlx(Cpdfaddtext) ocamlx(Cpdfannot) ocamlx(Cpdfattach) ocamlx(Cpdfbookmarks) ocamlx(Cpdfchop) ocamlx(Cpdfcolours) ocamlx(Cpdfcommand) ocamlx(Cpdfcomposition) ocamlx(Cpdfcoord) ocamlx(Cpdfcreate) ocamlx(Cpdfdraft) ocamlx(Cpdfdraw) ocamlx(Cpdfdrawcontrol) ocamlx(Cpdfembed) ocamlx(Cpdferror) ocamlx(Cpdfextracttext) ocamlx(Cpdffont) ocamlx(Cpdfimage) ocamlx(Cpdfimpose) ocamlx(Cpdfjpeg) ocamlx(Cpdfjpeg2000) ocamlx(Cpdfjson) ocamlx(Cpdfmetadata) ocamlx(Cpdfocg) ocamlx(Cpdfpad) ocamlx(Cpdfpage) ocamlx(Cpdfpagelabels) ocamlx(Cpdfpagespec) ocamlx(Cpdfpng) ocamlx(Cpdfposition) ocamlx(Cpdfpresent) ocamlx(Cpdfprinttree) ocamlx(Cpdfremovetext) ocamlx(Cpdfshape) ocamlx(Cpdfspot) ocamlx(Cpdfsqueeze) ocamlx(Cpdfstrftime) ocamlx(Cpdftexttopdf) ocamlx(Cpdftoc) ocamlx(Cpdftruetype) ocamlx(Cpdftweak) ocamlx(Cpdftype) ocamlx(Cpdfua) ocamlx(Cpdfunicodedata) ocamlx(Cpdfutil) ocamlx(Cpdfxmlm) ocamlx(Cpdfxobject) ocamlx(Cpdfyojson) ocamlx(Pdf) ocamlx(Pdfannot) ocamlx(Pdfcmap) ocamlx(Pdfcodec) ocamlx(Pdfcrypt) ocamlx(Pdfdest) ocamlx(Pdfe) ocamlx(Pdfgenlex) ocamlx(Pdfglyphlist) ocamlx(Pdfimage) ocamlx(Pdfio) ocamlx(Pdfmarks) ocamlx(Pdfmerge) ocamlx(Pdfops) ocamlx(Pdfpage) ocamlx(Pdfpagelabels) ocamlx(Pdfpaper) ocamlx(Pdfread) ocamlx(Pdfspace) ocamlx(Pdfst) ocamlx(Pdfstandard14) ocamlx(Pdftext) ocamlx(Pdftransform) ocamlx(Pdftree) ocamlx(Pdfunits) ocamlx(Pdfutil) ocamlx(Pdfwrite) ocamlx(Stdlib) ocamlx(Stdlib__Arg) ocamlx(Stdlib__Array) ocamlx(Stdlib__Buffer) ocamlx(Stdlib__Bytes) ocamlx(Stdlib__Char) ocamlx(Stdlib__Digest) ocamlx(Stdlib__Domain) ocamlx(Stdlib__Filename) ocamlx(Stdlib__Float) ocamlx(Stdlib__Format) ocamlx(Stdlib__Gc) ocamlx(Stdlib__Hashtbl) ocamlx(Stdlib__Int32) ocamlx(Stdlib__Int64) ocamlx(Stdlib__Lexing) ocamlx(Stdlib__List) ocamlx(Stdlib__Printexc) ocamlx(Stdlib__Printf) ocamlx(Stdlib__Random) ocamlx(Stdlib__Seq) ocamlx(Stdlib__String) ocamlx(Stdlib__Sys) cpdf (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) Provides -------- ocaml-cpdf: ocaml(Cpdfaddtext) ocaml(Cpdfannot) ocaml(Cpdfattach) ocaml(Cpdfbookmarks) ocaml(Cpdfchop) ocaml(Cpdfcolours) ocaml(Cpdfcommand) ocaml(Cpdfcommandrun) ocaml(Cpdfcomposition) ocaml(Cpdfcoord) ocaml(Cpdfcreate) ocaml(Cpdfdebug) ocaml(Cpdfdraft) ocaml(Cpdfdraw) ocaml(Cpdfdrawcontrol) ocaml(Cpdfembed) ocaml(Cpdferror) ocaml(Cpdfextracttext) ocaml(Cpdffont) ocaml(Cpdfimage) ocaml(Cpdfimpose) ocaml(Cpdfjpeg) ocaml(Cpdfjpeg2000) ocaml(Cpdfjson) ocaml(Cpdfmetadata) ocaml(Cpdfocg) ocaml(Cpdfpad) ocaml(Cpdfpage) ocaml(Cpdfpagelabels) ocaml(Cpdfpagespec) ocaml(Cpdfpng) ocaml(Cpdfposition) ocaml(Cpdfpresent) ocaml(Cpdfprinttree) ocaml(Cpdfremovetext) ocaml(Cpdfshape) ocaml(Cpdfspot) ocaml(Cpdfsqueeze) ocaml(Cpdfstrftime) ocaml(Cpdftexttopdf) ocaml(Cpdftoc) ocaml(Cpdftruetype) ocaml(Cpdftweak) ocaml(Cpdftype) ocaml(Cpdfua) ocaml(Cpdfunicodedata) ocaml(Cpdfutil) ocaml(Cpdfxmlm) ocaml(Cpdfxobject) ocaml(Cpdfyojson) ocaml-cpdf ocaml-cpdf(x86-64) ocaml-cpdf-devel: ocaml(Cpdfaddtext) ocaml(Cpdfannot) ocaml(Cpdfattach) ocaml(Cpdfbookmarks) ocaml(Cpdfchop) ocaml(Cpdfcolours) ocaml(Cpdfcommand) ocaml(Cpdfcommandrun) ocaml(Cpdfcomposition) ocaml(Cpdfcoord) ocaml(Cpdfcreate) ocaml(Cpdfdebug) ocaml(Cpdfdraft) ocaml(Cpdfdraw) ocaml(Cpdfdrawcontrol) ocaml(Cpdfembed) ocaml(Cpdferror) ocaml(Cpdfextracttext) ocaml(Cpdffont) ocaml(Cpdfimage) ocaml(Cpdfimpose) ocaml(Cpdfjpeg) ocaml(Cpdfjpeg2000) ocaml(Cpdfjson) ocaml(Cpdfmetadata) ocaml(Cpdfocg) ocaml(Cpdfpad) ocaml(Cpdfpage) ocaml(Cpdfpagelabels) ocaml(Cpdfpagespec) ocaml(Cpdfpng) ocaml(Cpdfposition) ocaml(Cpdfpresent) ocaml(Cpdfprinttree) ocaml(Cpdfremovetext) ocaml(Cpdfshape) ocaml(Cpdfspot) ocaml(Cpdfsqueeze) ocaml(Cpdfstrftime) ocaml(Cpdftexttopdf) ocaml(Cpdftoc) ocaml(Cpdftruetype) ocaml(Cpdftweak) ocaml(Cpdftype) ocaml(Cpdfua) ocaml(Cpdfunicodedata) ocaml(Cpdfutil) ocaml(Cpdfxmlm) ocaml(Cpdfxobject) ocaml(Cpdfyojson) ocaml-cpdf-devel ocaml-cpdf-devel(x86-64) ocamlx(Cpdfaddtext) ocamlx(Cpdfannot) ocamlx(Cpdfattach) ocamlx(Cpdfbookmarks) ocamlx(Cpdfchop) ocamlx(Cpdfcolours) ocamlx(Cpdfcommand) ocamlx(Cpdfcommandrun) ocamlx(Cpdfcomposition) ocamlx(Cpdfcoord) ocamlx(Cpdfcreate) ocamlx(Cpdfdebug) ocamlx(Cpdfdraft) ocamlx(Cpdfdraw) ocamlx(Cpdfdrawcontrol) ocamlx(Cpdfembed) ocamlx(Cpdferror) ocamlx(Cpdfextracttext) ocamlx(Cpdffont) ocamlx(Cpdfimage) ocamlx(Cpdfimpose) ocamlx(Cpdfjpeg) ocamlx(Cpdfjpeg2000) ocamlx(Cpdfjson) ocamlx(Cpdfmetadata) ocamlx(Cpdfocg) ocamlx(Cpdfpad) ocamlx(Cpdfpage) ocamlx(Cpdfpagelabels) ocamlx(Cpdfpagespec) ocamlx(Cpdfpng) ocamlx(Cpdfposition) ocamlx(Cpdfpresent) ocamlx(Cpdfprinttree) ocamlx(Cpdfremovetext) ocamlx(Cpdfshape) ocamlx(Cpdfspot) ocamlx(Cpdfsqueeze) ocamlx(Cpdfstrftime) ocamlx(Cpdftexttopdf) ocamlx(Cpdftoc) ocamlx(Cpdftruetype) ocamlx(Cpdftweak) ocamlx(Cpdftype) ocamlx(Cpdfua) ocamlx(Cpdfunicodedata) ocamlx(Cpdfutil) ocamlx(Cpdfxmlm) ocamlx(Cpdfxobject) ocamlx(Cpdfyojson) cpdf: cpdf cpdf(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2395215 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++, Ocaml Disabled plugins: Haskell, Java, Python, Ruby, SugarActivity, PHP, Perl, R, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://coherentpdf.com/fedora2/ocaml-cpdf.spec Patch file: https://coherentpdf.com/fedora2/patch.patch SRPM URL: https://coherentpdf.com/fedora2/ocaml-cpdf-2.8.1-1.fc41.src.rpm Thanks Jerry. ===== Issues ===== - The files cpdfunicodedata* seem to be under the Unicode-DFS-2015 license. That does not appear in the License tag (nor in README.md, I might add, where the other licenses are listed). Done in the spec file, and fixed upstream ready for the next version. - Please replace all occurrences of /usr/bin with %{_bindir}, and all occurrences of /usr/share/man with %{_mandir}. See https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation Done. - In %files for cpdf, do not specify the .gz suffix for the man page. Fedora currently uses gzip to compress man pages, but may change that at some future date. Use a glob there instead: %{_mandir}/man1/cpdf.1* See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Done. - Do I understand correctly that cpdfyojson.* is a bundled version of ocaml-yojson, and cpdfxmlm.* is a bundled version of ocaml-xmlm? If so, can they be unbundled? If not, then appropriate "Provided: bundled(foo)" lines must be added to the spec file, and I personally would prefer to see a comment in the spec file explaining why they can't be unbundled. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Yes, but they are old versions and have been modified for Cpdf. I have a number of hygiene changes to make for Cpdf 3.0 next year, and I'll try to make sure regularizing this is among them. - Note the description-shorter-than-summary warnings below from rpmlint. The Summary should be a short description of the package; %description should be a full description. If %summary is longer than %description, something is wrong. Thanks for the explanation. Done. - %check is empty. Is there anything that could be done there, some manipulation of one of the includes PDF files perhaps, just to verify that it runs at all? Done.
Further question, for the future. Cpdf always requires a CamlPDF of exactly the same version (they are released in sync). How is it best to encode this requirement?
Okay, that looks fine. This package is APPROVED. (In reply to John Whitington from comment #8) > Cpdf always requires a CamlPDF of exactly the same version (they are > released in sync). How is it best to encode this requirement? I think you can change the BuildRequires like so: BuildRequires: ocaml-camlpdf-devel = %{version} That will make sure you have an identical version at build time. There is no runtime requirement here, because ocaml-camlpdf only contains static archives, right?
The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-cpdf
FEDORA-2025-d8b5c15523 (ocaml-cpdf-2.8.1-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d8b5c15523
FEDORA-2025-d8b5c15523 (ocaml-cpdf-2.8.1-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-7d9c7f15ad (ocaml-cpdf-2.8.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-7d9c7f15ad
FEDORA-2025-22f0d0366c (ocaml-cpdf-2.8.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-22f0d0366c
FEDORA-2025-0956602f41 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-0956602f41 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-0956602f41 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.