Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/mdsplib/mdsplib.spec SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/mdsplib/mdsplib-0.11-2.src.rpm Description: METAR is a French acronym for Aviation Routine Weather Report. It is the standard format for reporting meteorological conditions. As a free service, the National Weather Service continually updates a server with METARs from all over the world. The MDSP Library provides a programmer with two functions, the major one being DcdMETAR, which decodes a METAR into structures provided by the library. Also prtDMETR, which prints out a decoded METAR structure. -- Packager note : It would be best to have this package patched to generate a shared library instead of only the default static library. It's not trivial since it doesn't use libtool, but would make sense since this version has been the latest for over 5 years now.
starting review...
Well, OK - Mock : Built on FC6 en F-7 (i386 and x86_64) OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License field in spec matches OK - License is LGPL OK - License match extras packaging policy licenses allowed OK - License file is included in package OK - Spec in American English OK - Spec is legible. OK - Sources SHOULD match upstream md5sum: c529c07675431f50c517921db6fdd122 mdsplib-0.11.tar.gz OK - Package has correct buildroot. OK - extras BuildRequires not required for this package. OK - %build and %install stages is correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Changelog section is correct. OK - Should function as described. OK - Should package latest version ------------------------------------------------ Rpmlint output: ------------------------------------------------ OK - silent on both srpm and rpm. ----------------------------- sub-package: ---------------------------- just a comment: Why don't create directly the -devel package instead. Does this package plan to contains more than headers files in future release ?
ping!
> Why don't create directly the -devel package instead. > Does this package plan to contains more than headers files in future release ? What do you mean by this? I'm already creating only the the -devel package, and yes, in the future I'd like to patch the sources in order to get a shared library, since this library hasn't changed in literally years it shouldn't be a problem, quite the contrary. See my initial "Packager note" :-)
nice catch ! ============== ** APPROVED ** ==============
New Package CVS Request ======================= Package Name: mdsplib Short Description: METAR Decoder Software Package Library Owners: matthias Branches: devel F-7 FC-6 FC-5 EL-4 EL-5 (all current) InitialCC:
There are some issues with static libs that should be figured before this is imported into cvs... "- MUST: Static libraries must be in a -static package" Also see: http://fedoraproject.org/wiki/PackagingDrafts/StaticLinkage I think short term you could just move the static libs to a -static package, but fixing it to use dynamic would be better.
Sigh. Here is the page I was looking for earlier and couldn't find: http://fedoraproject.org/wiki/Packaging/Guidelines#head-82d97fc4a3421310f4e2971180e4165965b65662 So, you could also add a: %package devel Provides: foo-static = %{version}-%{release}
Yeah, well, I'd really prefer having it as a shared lib, especially since the code itself hasn't changed at all in years. Hans : Could you maybe have a look and see if it would be easy to switch the build to produce a shared library?
Created attachment 156558 [details] Patch: make a shared lib instead of a static one Making a shared lib is simple with this package (no autohell, phew) this patch changes the makefile to make a shared lib instead of a static one. Modified spec will be attached next.
Created attachment 156559 [details] Modified spec
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/mdsplib/mdsplib.spec SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/mdsplib/mdsplib-0.11-3.src.rpm * Fri Jun 8 2007 Matthias Saou <http://freshrpms.net/> 0.11-3 - Include patch from Hans de Goede to build the lib as shared. That was fast Hans, thanks a lot!!!
Awesome work Hans! Xavier: Could you look this over and if it looks ok, (re) approve it? Sorry for the trouble here, but static libs are just to be avoided if possible, and it looks very possible here. ;)
okay ;-) >> Sorry for the trouble here, but static libs are just to be avoided if possible, >> and it looks very possible here. ;) I do agree with that.
Well, Taking in account first part of full review above which doesn't change, OK - Removed Static lib from package OK - Sahred lib correctly generated/included in package. OK - Sub-packages are proper Ok - No sub-package -lib are required Ok - Scriptlets for shared lib are properly applied. -------------- rpmlint ouputs -------------- Silent from both rpm (main pakcage) and srpm. From -devel package: W: mdsplib-devel no-documentation Harmless, this can be ignored. ============== ** APPROVED ** ==============
cvs done.
All branches built fine, and the F-7 package is pending for updates-testing. Thanks for the review and for the CVS operations!
mdsplib-0.11-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report.
mdsplib-0.11-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.