Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/sgtsnookums/fedora_specs/refs/heads/feat/rainbow-delimiters/emacs-rainbow-delimiters.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/msnook/emacs_addons/srpm-builds/09563698/emacs-rainbow-delimiters-2.1.520230830git.f40ece5-1.fc41.src.rpm Description: Minor mode for Emacs to add color-coded highlighting for parenthesis/bracket pairs Fedora Account System Username: msnook Koji scratch build since the onboarding docs suggested it: https://koji.fedoraproject.org/koji/taskinfo?taskID=137211289 Also looking for sponsorship since this is my first package. (At least publicly. I've got a bit of packaging experience through my job).
Copr build: https://copr.fedorainfracloud.org/coprs/build/9564125 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2396285-emacs-rainbow-delimiters/fedora-rawhide-x86_64/09564125-emacs-rainbow-delimiters/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "GNU General Public License v3.0 or later". 5 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging-local/reviews/emacs- rainbow-delimiters/rebuild/review-emacs-rainbow-delimiters/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/emacs/site- lisp/site-start.d, /usr/share/emacs/site-lisp, /usr/share/emacs These are owned by emacs-filesystem [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3051 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: emacs-rainbow-delimiters-2.1.5^20230830git.f40ece5-1.fc46.noarch.rpm emacs-rainbow-delimiters-2.1.5^20230830git.f40ece5-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptliri696')] checks: 32, packages: 2 emacs-rainbow-delimiters.src: W: strange-permission emacs-rainbow-delimiters-f40ece5.tar.gz 666 emacs-rainbow-delimiters.src: W: strange-permission rainbow-delimiters-init.el 666 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/Fanael/rainbow-delimiters/archive/f40ece58df8b2f0fb6c8576b527755a552a5e763/emacs-rainbow-delimiters-f40ece5.tar.gz : CHECKSUM(SHA256) this package : 355789cb776dcf14ab90f06b11dceebdab0799a0caafd1af2260547c5dbb2730 CHECKSUM(SHA256) upstream package : 355789cb776dcf14ab90f06b11dceebdab0799a0caafd1af2260547c5dbb2730 Using local file /home/benson/Projects/fedora-packaging-local/reviews/emacs-rainbow-delimiters/rebuild/rainbow-delimiters-init.el as upstream file:///home/benson/Projects/fedora-packaging-local/reviews/emacs-rainbow-delimiters/rebuild/rainbow-delimiters-init.el : CHECKSUM(SHA256) this package : af67cc0caf6f2e81a7d255fef257d3e168bef122cf6338155697774995c15585 CHECKSUM(SHA256) upstream package : af67cc0caf6f2e81a7d255fef257d3e168bef122cf6338155697774995c15585 Requires -------- emacs-rainbow-delimiters (rpmlib, GLIBC filtered): emacs(bin) Provides -------- emacs-rainbow-delimiters: emacs-rainbow-delimiters Diff spec file in url and in SRPM --------------------------------- --- /home/fedora-packaging-local/reviews/emacs-rainbow-delimiters/rebuild/emacs-rainbow-delimiters.spec 2026-09-19 11:42:20.971897978 +0300 +++ /home/fedora-packaging-local/reviews/emacs-rainbow-delimiters/rebuild/review-emacs-rainbow-delimiters/srpm-unpacked/emacs-rainbow-delimiters.spec 2026-09-19 03:00:00.000000000 +0300 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global pkg rainbow-delimiters %global commit f40ece58df8b2f0fb6c8576b527755a552a5e763 @@ -47,3 +57,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sat Sep 19 2026 John Doe <packager> - 2.1.5^20230830git.f40ece5-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -n emacs-rainbow-delimiters Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, Perl, SugarActivity, Java, Ocaml, PHP, Python, fonts, R, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Thanks for bringing this to Fedora. Some suggestions for minor changes. b) To ensure correct permissions, consider changing the install section to: install -dm 0755 %{buildroot}/%{_emacs_sitelispdir}/%{pkg} install -pm 0644 %{pkg}.el* -t %{buildroot}/%{_emacs_sitelispdir}/%{pkg} install -Dpm 0644 %{SOURCE1} %{buildroot}%{_emacs_sitestartdir}/%{pkg}-init.el c) $ rpmlint -e strange-permission strange-permission: A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions.
Sounds good. I've updated the %install section to use install everywhere to set sane perms, and have the changes building in copr now to verify.
Can you update the links to the spec and srpm files?