Spec URL: https://pagure.io/dotnet-sig/dotnet10.0/blob/7aab984d9e7592b5f71b81859f725aaa7b801341/f/dotnet10.0.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@dotnet-sig/dotnet-preview/fedora-rawhide-x86_64/09584046-dotnet10.0/dotnet10.0-10.0.100~rc.1.25451.107-0.7.fc44~bootstrap.src.rpm Description: .NET is a fast, lightweight and modular platform for creating cross platform applications that work on Linux, macOS and Windows. It particularly focuses on creating console applications, web applications and micro-services. .NET contains a runtime conforming to .NET Standards a set of framework libraries, an SDK containing compilers and a 'dotnet' application to drive everything. Fedora Account System Username: omajid
Copr build: https://copr.fedorainfracloud.org/coprs/build/9584620 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397031-dotnet10.0/fedora-rawhide-x86_64/09584620-dotnet10.0/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The RPM builds actually worked in copr, but things failed here: > Finish: rpmbuild dotnet10.0-10.0.100~rc.1.25451.107-0.7.fc44~bootstrap.src.rpm > Finish: build phase for dotnet10.0-10.0.100~rc.1.25451.107-0.7.fc44~bootstrap.src.rpm > INFO: chroot_scan: 1 files copied to /var/lib/copr-rpmbuild/results/chroot_scan > INFO: /var/lib/mock/fedora-rawhide-x86_64-1758319299.327404/root/var/log/dnf5.log > INFO: chroot_scan: creating tarball /var/lib/copr-rpmbuild/results/chroot_scan.tar.gz > /bin/tar: Removing leading `/' from member names > INFO: Done(/var/lib/copr-rpmbuild/results/dotnet10.0-10.0.100~rc.1.25451.107-0.7.fc44~bootstrap.src.rpm) Config(child) 71 minutes 38 seconds > INFO: Results and/or logs in: /var/lib/copr-rpmbuild/results > INFO: Cleaning up build root ('cleanup_on_success=True') > Start: clean chroot > INFO: unmounting tmpfs. > Finish: clean chroot > Finish: run > Running FedoraReview tool > Running: fedora-review --no-colors --prebuilt --rpm-spec --name dotnet10.0 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg > > cmd: ['fedora-review', '--no-colors', '--prebuilt', '--rpm-spec', '--name', 'dotnet10.0', '--mock-config', '/var/lib/copr-rpmbuild/results/configs/child.cfg']cwd: /var/lib/copr-rpmbuild/results > rc: 1 > stdout: > stderr: INFO: Processing local files: dotnet10.0 > INFO: Getting .spec and .srpm Urls from : Local files in /var/lib/copr-rpmbuild/results > INFO: --> SRPM url: file:///var/lib/copr-rpmbuild/results/dotnet10.0-10.0.100~rc.1.25451.107-0.7.fc44~bootstrap.src.rpm > INFO: Using review directory: /var/lib/copr-rpmbuild/results/dotnet10.0 > cpio: write error: No space left on device > WARNING: Cannot unpack /var/lib/copr-rpmbuild/results/dotnet10.0/srpm/dotnet10.0-10.0.100~rc.1.25451.107-0.7.fc44~bootstrap.src.rpm into /var/lib/copr-rpmbuild/results/dotnet10.0/srpm-unpacked > cpio: write error: No space left on device
This spec is very much aligned with dotnet9.0 so nothing there's no huge issues here, just a bit of cruft that's accumulated: - in the "%if ( 0%{?fedora} && 0%{?fedora} < 38 ) || ( 0%{?rhel} && 0%{?rhel} < 9 )" macro you could drop the Fedora bit since f38 is very dead at this point. I'm not sure if you plan to build this for EPEL/RHEL9, but if not it'd be nice to clean up that whole block. - The bundled brotli version is v1.1.0 and the "Provides: bundled(libbrotli) = 1.0.9" statement should be updated accordingly - the bundled libunwind version is now v1.8.0 and its version file is at src/runtime/src/native/external/libunwind-version.txt - inside the check section there's a "%if 0%{?fedora} > 35" block which could be cleaned up now that Fedora 35 is no more. There's a similar check for less than 38 just below it that could be dropped - I see there's options to bundle rapidjson, llvm-libunwind, and zlib-ng but no corresponding provides for the bundled versions. The only real issue is the last one, and for Fedora it's only an issue with llvm-libunwind since the rest are set to use system libraries. For RHEL there's "use_bundled_rapidjson 1" so it'd be good to add all of them to align with the available knobs to bundle (or not) the various libraries.
Thanks for the review! And thank you for the feedback, it was great! I think I have addressed these comments here: https://pagure.io/dotnet-sig/dotnet10.0/c/67b5a198478e0015c84d5cfba18716070cac6877?branch=main Can you take another look? Thanks again!
I built this locally and everything seems good - rpmlint is extremely unhappy but it all looks like normal .NET stuff from my extremely limited experience. Since this very much aligns with prior packages I'm assuming that's all fine. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/dotnet10.0