Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/09586217-cosmic-initial-setup/cosmic-initial-setup.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/09586217-cosmic-initial-setup/cosmic-initial-setup-1.0.0~beta.1-1.fc44.src.rpm Description: The cosmic-initial-setup program is the first thing to run after entering a COSMIC session with a new user. It helps configure things like accessibility, theme, panel configuration, timezone, and more. Fedora Account System Username: ryanabx
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9590160 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397438-cosmic-initial-setup/fedora-rawhide-x86_64/09590160-cosmic-initial-setup/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Note: Directories without known owners: /usr/share/cosmic-layouts, > /usr/share/polkit-1, /usr/share/cosmic, > /usr/share/icons/hicolor/scalable, /usr/share/polkit-1/rules.d, > /usr/share/icons/hicolor/scalable/apps, /usr/share/cosmic/cosmic- > themes, /usr/share/icons/hicolor This needs extra runtime dependencies to ensure everything is owned. At least "hicolor-icon-theme", "polkit", and whatever packages are the primary owners of those cosmic directory paths.
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/09595175-cosmic-initial-setup/cosmic-initial-setup.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/09595175-cosmic-initial-setup/cosmic-initial-setup-1.0.0~beta.1-1.fc44.src.rpm Description: The cosmic-initial-setup program is the first thing to run after entering a COSMIC session with a new user. It helps configure things like accessibility, theme, panel configuration, timezone, and more. Fedora Account System Username: ryanabx
Created attachment 2107381 [details] The .spec file difference from Copr build 9590160 to 9595262
Copr build: https://copr.fedorainfracloud.org/coprs/build/9595262 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2397438-cosmic-initial-setup/fedora-rawhide-x86_64/09595262-cosmic-initial-setup/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines (using vendored crates for now) (nonblocking note: it's probably a good idea to adjust all cosmic packages so that vendor sources have name-version prefix instead of just version) Package APPROVED. === Recommended post-import tasks: - set up package on release-monitoring.org: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - add @cosmic-sig with "admin" access as package co-maintainer - set bugzilla assignee overrides to @cosmic-sig - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-initial-setup