Spec URL: http://zanoni.jcomserv.net/fedora/agistudio/agistudio.spec SRPM URL: http://zanoni.jcomserv.net/fedora/agistudio/agistudio-1.2.3-1.src.rpm Description: AGI (Adventure Game Interpreter) is the adventure game engine used by Sierra On-Line(tm) to create some of their early games. QT AGI Studio is a program which allows you to view, create and edit AGI games. This can use either NAGI or Sarien as a testing interpreter. I will be submitting NAGI for review also.
nice... i'll check this out
Well, ----------------- %install section ----------------- cp help/* %{buildroot}%{_datadir}/agistudio/help cp -r template/* %{buildroot}%{_datadir}/agistudio/template -------------------------------------------------------------------- You SHOULD keep timstamps on template and help files (included sub-directories) and paste right permission on them, so the use of 'install [option]' is more suitable, just like below: install -p -m 0664 help/* %{buildroot}%{_datadir}/agistudio/help install -p -m 0664 template/* %{buildroot}%{_datadir}/agistudio/template ------------------------------------------------------- install -m 755 -d template %{buildroot}%{_datadir}/agistudio/template install -m 755 -d help %{buildroot}%{_datadir}/agistudio/help Those above can be improved : install -D (or mkdir -p) %{buildroot}%{_datadir}/agistudio/template install -D (or mkdir -p) %{buildroot}%{_datadir}/agistudio/help --------------------------------------------------------------- cp -a src/app_icon.xpm %{buildroot}%{_datadir}/icons/hicolor/32x32/apps/%{name}.xpm Use 'install -p -m 0664' instead of 'cp -a' the use of -a option isn't necessary (is the same as -dpR where not really needded) ------------------- From %files section -------------------- i think that the help files should be installed in /usr/share/doc/[package_name] sub-directory.
Fixed, but the build dies on: install -p -m 0644 template/logdir template/object template/picdir template/snddir template/src template/viewdir template/vol.0 template/words.tok /var/tmp/agistudio-1.2.3-2-root-limb/usr/share/agistudio/template install: omitting directory `template/src' error: Bad exit status from /var/tmp/rpm-tmp.67653 (%install) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.67653 (%install) I'm using install -p -m 0644 template/* %{buildroot}%{_datadir}/agistudio/template Suggestions?
just a typo install -p -Dm 0644 template/* %{buildroot}%{_datadir}/%{name}/template instead.
That didn't help. Here's the current spec. Spec URL: http://zanoni.jcomserv.net/fedora/agistudio/agistudio.spec
alright i on it ;)
<< install -p -Dm 0644 template/* %{buildroot}%{_datadir}/%{name}/template >> cp -pr template/* %{buildroot}%{_datadir}/%{name}/template fixes it. Any problem with this? It's the empty template/src that's the problem, but it needs to be there.
nope but, the use of install from spec file is more appropriate. ------------------------------------ Other things should be fix: ------------------------------------ * From source0 tag you should set %{name}-%{version}.tar.gz instead. to improve future update. * You should add help files in %{_docdir}. this should be included in the package. (juste add help/* in docs field) * You should add relnotes files too in %{_docdir}, it's a ChangeLog-like and should be included. * i can see in package that NEW and README files are included but where did you get them, no see in the tarball.
typo: remove field "from source0" and 2 last SHOULD fix sentence from this review. sorry i mixed up with another review.
Added help/*. Spec URL: http://zanoni.jcomserv.net/fedora/agistudio/agistudio.spec SRPM URL: http://zanoni.jcomserv.net/fedora/agistudio/agistudio-1.2.3-2.src.rpm And, for future reference: 1. Wake up 2. Caffeine 3. Work on Fedora 4. ??? 5. Profit!!! :)
(in reply to comment #10) caffeine, humm.... ^^ Well, OK - Mock : Built on FC6 en F-7 (i386 and x86_64) OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License field in spec matches OK - License is GPL OK - License match extras packaging policy licenses allowed OK - License file is included in package OK - Spec in American English OK - Spec is legible. OK - Sources SHOULD match upstream md5sum: b262d55b1285967923598e53fb93fe62 agistudio-1.2.3.tar.gz OK - Package has correct buildroot. OK - BuildRequires isn't redundant. OK - %build and %install stages is correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Changelog section is correct. OK - Should function as described. OK - Should package latest version ------------------------------------------------ Rpmlint output: ------------------------------------------------ OK - silent on SRPM NO - not silent on RPM package E: agistudio zero-length /usr/share/agistudio/template/snddir this error is harmless but need to be fix as the file is just a template and contains nothing, it can be remove from package.
It actually can't be removed from the package. When you try to create a game from template and snddir isn't there, it fails "Can't read snddir in template directory /usr/share/agistudio/template 1".
Well, Ok - Taking in account the comment from [comment #12] about rpmlint error. this last one can be ignored : snddir is mandatory for the game. ============== ** APPROVED ** ==============
Many thanks! New Package CVS Request ======================= Package Name: agistudio Short Description: AGI integrated development environment Owners: limb Branches: FC-5 FC-6 F-7 InitialCC:
cvs done.
Imported and build. Thanks all.