Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Traceroute.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Traceroute-0.21.1-1.fc8.src.rpm Mock Log: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Traceroute-build.log Description: OS independet wrapper class for executing traceroute calls -- Here is another "oreon" requires (the lastest I think)
I suggest changing the %description to: OS independent wrapper class for executing traceroute calls. to fix a misspelling and add a period. I think this package should have a runtime depdency on traceroute; otherwise I'm not sure what the point is. * source files match upstream: a3a25932b9e81ebbec7f12035859bbd336d0b334d0c8bca5b15386a672c45463 Net_Traceroute-0.21.1.tgz * package meets naming and versioning guidelines. ? specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. ? final provides and requires are sane: php-pear(Net_Traceroute) = 0.21.1 php-pear-Net-Traceroute = 0.21.1-1.fc7 = /bin/sh /usr/bin/pear * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Thanks for the review. Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Traceroute.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Traceroute-0.21.1-2.fc8.src.rpm %changelog * Wed May 16 2007 Remi Collet <Fedora> 0.21.1-2 - From review, change description - add Requires: traceroute About "macros used". Spec file use new macros provided by php-pear since 1.4.9-1.2 (/etc/rpm/macros.pear). Can you detail me what you are not sure about ?
My comment about "otherwise I'm not sure what the point is" was merely noting that if you don't have a traceroute dependency (and the system doesn't happen to have traceroute already installed) then this module is essentially useless. But since you added the dependency, everything's fine. APPROVED
New Package CVS Request ======================= Package Name: php-pear-Net-Traceroute Short Description: Execute traceroute Owners: Fedora Branches: devel FC-6 FC-5 EL-5 (FC-7 ??) InitialCC:
Package Change Request ====================== Package Name: php-pear-Net-Traceroute New Branches: F-7
CVS done.