Red Hat Bugzilla – Bug 239933
Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class
Last modified: 2011-07-15 11:51:38 EDT
Spec URL: http://rubenkerkhof.com/packages/perl-Danga-Socket.spec SRPM URL: http://rubenkerkhof.com/packages/perl-Danga-Socket-1.57-1.src.rpm Description: This is an abstract base class for objects backed by a socket which provides the basic framework for event-driven asynchronous IO, designed to be fast. Danga::Socket is both a base class for objects, and an event loop.
This is failing for me because perl-Sys-Syscall hasn't been pushed. I guess it didn't get tagged for F7. I stuffed it in a local repository and things build fine.
My only suggestion is that you include the examples directory as %doc. I don't think this is a blocker, though. * source files match upstream: 919be5206f5e9dbff4a825a5bea3ed9f223629c2e969360a6228a929c838c7f5 Danga-Socket-1.57.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Danga::Socket) = 1.57 perl(Danga::Socket::Timer) perl-Danga-Socket = 1.57-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Errno) perl(POSIX) perl(Socket) perl(Sys::Syscall) perl(Time::HiRes) perl(bytes) perl(constant) perl(fields) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=4, Tests=59, 8 wallclock secs ( 0.22 cusr + 0.06 csys = 0.28 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED
Thanks again Jason. I've included the examples in %doc. New Package CVS Request ======================= Package Name: perl-Danga-Socket Short Description: Event loop and event-driven async socket base class Owners: ruben@rubenkerkhof.com Branches: FC-5 FC-6
Is there some reason this ticket is still open?
Oops, sorry
Package Change Request ====================== Package Name: perl-Danga-Socket New Branches: EL-4 EL-5
Package Change Request ====================== Package Name: perl-Danga-Socket Branches: f15 f14 New InitialCC: perl-sig Please add `perl-sig' to CC list for all Fedora branches as this is Perl package.
The requested branches already exist. Just what are you requesting here?
(In reply to comment #8) > The requested branches already exist. Just what are you requesting here? Petr requested the addition of perl-sig to the CC list in those branches.
This is now done via pkgdb.
(In reply to comment #10) > This is now done via pkgdb. We can now add other users to our packages? How?
Real users can simply add themselves. Other actions require an administrator.
(In reply to comment #12) > Real users can simply add themselves. Other actions require an administrator. Which is what this request is about -- perl-sig is not a real user.
Hmm, I interpreted Jon's comment as "it's been done" but it seems that I was incorrect. Can you simply mail me a list of all of the packages where you want the CC added and I'll add it? Please note any packages where you don't want it done on all of devel, f15 and f14. I know there are many, and doing one request per ticket is kind of overkill.