Spec URL: https://ngompa.fedorapeople.org/for-review/plasma-setup.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/plasma-setup-0.1.0~20250926giteeeb5a1-1.fc44.src.rpm Description: Initial setup for systems using KDE Plasma. (Note this is a rename of the existing kiss package) Fedora Account System Username: ngompa
Copr build: https://copr.fedorainfracloud.org/coprs/build/9612131 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399913-plasma-setup/fedora-rawhide-x86_64/09612131-plasma-setup/fedora-review/review.txt Found issues: - plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.language/languageutil.h plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.prepare/prepareutil.h plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.time/timeutil.h plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.time/timezonemodel.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file konqi-calling.png.license is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Systemd service file(s) in plasma-setup Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I am taking this, even though I think this package rename sucks (But that's an upstream thing)
Are those header files (and cpp files in the same folders) needed? They should probably either be deleted or packaged as -devel. I suspect upstream build script bugs. The desktop file probably should be validated konqi-calling.png.license should probably be tagged %license systemd-rpm-macros BR-ed on but no systemd scriptlet used Issues: ======= - Header files in -devel subpackage, if present. Note: plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.language/languageutil.h plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.prepare/prepareutil.h plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.time/timeutil.h plasma- setup : /usr/share/plasma/packages/org.kde.plasmasetup.time/timezonemodel.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file konqi-calling.png.license is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in plasma-setup See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets
Updated to address feedback: Spec URL: https://ngompa.fedorapeople.org/for-review/plasma-setup.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/plasma-setup-0.1.0~git20251123.180844b-1.fc44.src.rpm
Created attachment 2116119 [details] The .spec file difference from Copr build 9612131 to 9833724
Copr build: https://copr.fedorainfracloud.org/coprs/build/9833724 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399913-plasma-setup/fedora-rawhide-x86_64/09833724-plasma-setup/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
desktop-file-validate still not used Need to depend on two extra packages at installation time for directory ownership Licensing seems wrong - the README is CC0-1.0, and while most of the LGPL files are LGPL-2.0+ or LGPL-2.1+ so combined with GPL-2.0+ the combination is GPL-2.0+, there are some that are specifically LGPL-2.0 OR LGPL-3.0. Please fix. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Creative Commons CC0 1.0", "BSD 2-Clause License", "*No copyright* BSD 2-Clause License", "*No copyright* Creative Commons CC0 1.0", "GNU General Public License, Version 2", "GNU General Public License, Version 3", "GNU Library General Public License, Version 2.0", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 3", "GNU General Public License, Version 3 and/or GNU Library General Public License, Version 2.0", "*No copyright* GNU Library General Public License, Version 2.0", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU Lesser General Public License, Version 2.1". 35 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/plasma- setup/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1, /usr/libexec/kf6/kauth, /usr/share/dbus-1/system-services, /usr/share/dbus-1/system.d => need dbus-common, kf6-kauth [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in plasma-setup [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: plasma-setup-0.1.0~git20251123.180844b-1.fc44.x86_64.rpm plasma-setup-0.1.0~git20251123.180844b-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0ro1a0kv')] checks: 32, packages: 2 plasma-setup.x86_64: E: zero-length /usr/share/licenses/plasma-setup/LicenseRef-KDE-Accepted-LGPL.txt plasma-setup.x86_64: W: tmpfile-not-in-filelist /run/plasma-setup plasma-setup.x86_64: W: tmpfile-not-in-filelist /run/plasma-setup/.config/plasma-welcomerc plasma-setup.x86_64: W: tmpfile-not-in-filelist /run/plasma-setup/.config/kscreenlockerrc plasma-setup.x86_64: W: tmpfile-not-in-filelist /run/plasma-setup/.config/kwalletrc plasma-setup.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory plasma-setup.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/plasma-setup-tmpfiles.conf plasma-setup.x86_64: W: no-documentation plasma-setup.spec: W: no-%check-section plasma-setup.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-setup/GPL-2.0-or-later.txt plasma-setup.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-setup/LGPL-2.0-or-later.txt plasma-setup.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-setup/LGPL-2.1-only.txt plasma-setup.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-setup/LGPL-2.1-or-later.txt plasma-setup.x86_64: W: files-duplicate /usr/share/licenses/plasma-setup/LGPL-2.1-or-later.txt /usr/share/licenses/plasma-setup/LGPL-2.1-only.txt plasma-setup.x86_64: W: empty-%postun plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/finished.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/account/account.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/plasmasetup_keyboard.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/account/account.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/plasmasetup_keyboard.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/finished.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/language/plasmasetup_language.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/account/account.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/language/plasmasetup_language.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/finished.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/language/plasmasetup_language.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/plasmasetup_keyboard.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/plasmasetup_prepare.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/account/account.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/plasmasetup_prepare.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/finished.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/plasmasetup_prepare.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/plasmasetup_keyboard.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/plasmasetup_prepare.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/language/plasmasetup_language.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/plasmasetup_time.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/account/account.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/plasmasetup_time.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/finished.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/plasmasetup_time.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/plasmasetup_keyboard.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/plasmasetup_time.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/language/plasmasetup_language.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/plasmasetup_time.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/plasmasetup_prepare.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/account/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/components/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/language/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/kde-qmlmodule.version /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/kde-qmlmodule.version plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/wifi.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/account/account.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/wifi.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/finished.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/wifi.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/plasmasetup_keyboard.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/wifi.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/language/plasmasetup_language.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/wifi.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/plasmasetup_prepare.qmltypes plasma-setup.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/wifi.qmltypes /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/plasmasetup_time.qmltypes 2 packages and 0 specfiles checked; 5 errors, 86 warnings, 7 filtered, 5 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: plasma-setup-debuginfo-0.1.0~git20251123.180844b-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcc4aijc6')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 36 filtered, 0 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "plasma-setup-debuginfo". ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "plasma-setup". There are no files to process nor additional arguments. Nothing to do, aborting. Unversioned so-files -------------------- plasma-setup: /usr/lib64/qt6/plugins/kf6/packagestructure/plasmasetup.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/account/libaccount.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/finished/libfinished.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/keyboard/libplasmasetup_keyboard.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/language/libplasmasetup_language.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/languageutil/libplasmasetup_languageutil.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/prepare/private/libplasmasetup_prepare.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/prepareutil/libplasmasetup_prepareutil.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/time/private/libplasmasetup_time.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/timeutil/libplasmasetup_timeutil.so plasma-setup: /usr/lib64/qt6/qml/org/kde/plasmasetup/wifi/libwifi.so Source checksums ---------------- https://invent.kde.org/plasma/plasma-setup/-/archive/180844bd28bca8e4c5c6ed99786a2718386ac323/plasma-setup-180844b.tar.bz2 : CHECKSUM(SHA256) this package : a5b26a9e8b2af3256030e6137ef55e95288d97e75bb19670e3a007115af7addb CHECKSUM(SHA256) upstream package : a5b26a9e8b2af3256030e6137ef55e95288d97e75bb19670e3a007115af7addb Requires -------- plasma-setup (rpmlib, GLIBC filtered): /bin/sh kf6-filesystem libKF6AuthCore.so.6()(64bit) libKF6ConfigCore.so.6()(64bit) libKF6ConfigGui.so.6()(64bit) libKF6CoreAddons.so.6()(64bit) libKF6I18n.so.6()(64bit) libKF6I18nQml.so.6()(64bit) libKF6Package.so.6()(64bit) libKF6Screen.so.8()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Qml.so.6()(64bit) libQt6Qml.so.6(Qt_6)(64bit) libQt6Qml.so.6(Qt_6.10_PRIVATE_API)(64bit) libQt6Quick.so.6()(64bit) libQt6Quick.so.6(Qt_6)(64bit) libQt6QuickControls2.so.6()(64bit) libQt6QuickControls2.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libkworkspace6.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt6qml(org.kde.plasma.private.kcm_keyboard) rtld(GNU_HASH) Provides -------- plasma-setup: group(plasma-setup) kiss kiss(x86-64) plasma-setup plasma-setup(x86-64) qt6qml(org.kde.plasmasetup.account) qt6qml(org.kde.plasmasetup.components) qt6qml(org.kde.plasmasetup.finished) qt6qml(org.kde.plasmasetup.keyboard) qt6qml(org.kde.plasmasetup.language) qt6qml(org.kde.plasmasetup.languageutil) qt6qml(org.kde.plasmasetup.prepare.private) qt6qml(org.kde.plasmasetup.prepareutil) qt6qml(org.kde.plasmasetup.time.private) qt6qml(org.kde.plasmasetup.timeutil) qt6qml(org.kde.plasmasetup.wifi) user(plasma-setup) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name plasma-setup --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Ocaml, fonts, Java, Perl, Haskell, SugarActivity, PHP, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Michel Lind from comment #7) > desktop-file-validate still not used > No desktop files are installed in /usr/share/applications, so this is not applicable. > Need to depend on two extra packages at installation time for directory > ownership > Fixed. > Licensing seems wrong - the README is CC0-1.0, and while most of the LGPL > files are LGPL-2.0+ or LGPL-2.1+ so combined with GPL-2.0+ the combination > is GPL-2.0+, there are some that are specifically LGPL-2.0 OR LGPL-3.0. > Please fix. > Sigh. Fixed.
I updated the files in place, FYI. [fedora-review-service-build]
LGTM now, APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-setup