Spec URL: https://eclipseo.fedorapeople.org:/home/fedora/eclipseo/public_html/for-review/python-dissect.cstruct.spec SRPM URL: https://eclipseo.fedorapeople.org:/home/fedora/eclipseo/public_html/for-review/python-dissect.cstruct-4.6-1.fc44.src.rpm Description: A Dissect module implementing a parser for C-like structures. Structure parsing in Python made easy. With cstruct, you can write C-like structures and use them to parse binary data, either as file-like objects or bytestrings. Fedora Account System Username: eclipseo
There seems to be some problem with the following file. SRPM URL: https://eclipseo.fedorapeople.org/home/fedora/eclipseo/public_html/for-review/python-dissect.cstruct-4.6-1.fc44.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Spec URL: https://eclipseo.fedorapeople.org/for-review/python-dissect.cstruct.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-dissect.cstruct-4.6-1.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9624703 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399983-python-dissect.cstruct/fedora-rawhide-x86_64/09624703-python-dissect.cstruct/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9624704 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399983-python-dissect.cstruct/fedora-rawhide-x86_64/09624704-python-dissect.cstruct/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update SPEC to fix: python-dissect.cstruct.src: E: spelling-error ('bytestrings', '%description -l en_US bytestrings -> byte strings, byte-strings, restrings') python3-dissect.cstruct.noarch: E: spelling-error ('bytestrings', '%description -l en_US bytestrings -> byte strings, byte-strings, restrings') python-dissect.cstruct.src: W: invalid-url URL https://https://github.com/fox-it/dissect.cstruct python3-dissect.cstruct.noarch: W: invalid-url URL https://https://github.com/fox-it/dissect.cstruct Spec URL: https://eclipseo.fedorapeople.org/for-review/python-dissect.cstruct.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-dissect.cstruct-4.6-1.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9624919 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399983-python-dissect.cstruct/fedora-rawhide-x86_64/09624919-python-dissect.cstruct/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ==== - I personally think that the %pypi_name / %pypi_name_with_underscore macros just add complexity to the spec file, without meaningfully improving “reusablity” across packages, and it’s better just to write out the names everywhere. However, this is a matter of opinion, and this sort of indirection is certainly permitted, so no change is required. - You should not allow dependencies on coverage-analysis tools (python3-coverage, python3-pytest-cov) to be generated; see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters. Considering how much of the tox.ini configuration is dedicated to these, [testenv] extras = dev deps = pytest pytest-cov coverage commands = pytest --basetemp="{envtmpdir}" {posargs:--color=yes --cov=dissect --cov-report=term-missing -v tests} coverage report coverage xml the easiest approach is probably to add a manual BR on pytest, BuildRequires: %{py3_dist pytest} and either add a manual BR on typing-extensions BuildRequires: %{py3_dist typing_extensions} or generate BR’s from the "dev" extra and keep an eye on it to make sure nothing unwanted creeps in there in future releases: %pyproject_buildrequires -x dev Then, of course, drop the -t from %pyproject_buildrequires, and replace %pytest with %tox. You can always patch tox.ini instead, but it’s a lot more work, and you’re left with tox providing very little value afterwards. - Since you are relying on %pyproject_files to contain a properly-annotated (with %license) license file, change %pyproject_save_files dissect to %pyproject_save_files -l dissect so that the build will fail if the license file ever disappears. - The URL and description differ slightly between the source RPM and the spec file. Make sure both parts of the submission match each other. - In addition to README.md, consider also packaging CHANGELOG.md as documentation. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 70 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2399983-python- dissect.cstruct/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages Spurious diagnostics; python3-libs owns these. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. $ rpm -qL -p results_python-dissect.cstruct/4.6/1.fc44/python3-dissect.cstruct-4.6-1.fc44.noarch.rpm /usr/lib/python3.14/site-packages/dissect_cstruct-4.6.dist-info/licenses/COPYRIGHT /usr/lib/python3.14/site-packages/dissect_cstruct-4.6.dist-info/licenses/LICENSE [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7502 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (Tests pass.) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=137642293 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-dissect.cstruct-4.6-1.fc44.noarch.rpm python-dissect.cstruct-4.6-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpo1qvny7v')] checks: 32, packages: 2 python-dissect.cstruct.src: E: spelling-error ('bytestrings', '%description -l en_US bytestrings -> byte strings, byte-strings, restrings') python3-dissect.cstruct.noarch: E: spelling-error ('bytestrings', '%description -l en_US bytestrings -> byte strings, byte-strings, restrings') python3-dissect.cstruct.noarch: W: no-manual-page-for-binary cstruct-stubgen python-dissect.cstruct.src: W: invalid-url URL https://https://github.com/fox-it/dissect.cstruct python3-dissect.cstruct.noarch: W: invalid-url URL https://https://github.com/fox-it/dissect.cstruct 2 packages and 0 specfiles checked; 2 errors, 3 warnings, 7 filtered, 2 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-dissect.cstruct.noarch: E: spelling-error ('bytestrings', '%description -l en_US bytestrings -> byte strings, byte-strings, restrings') python3-dissect.cstruct.noarch: W: no-manual-page-for-binary cstruct-stubgen python3-dissect.cstruct.noarch: W: invalid-url URL https://https://github.com/fox-it/dissect.cstruct 1 packages and 0 specfiles checked; 1 errors, 2 warnings, 3 filtered, 1 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/d/dissect_cstruct/dissect_cstruct-4.6.tar.gz : CHECKSUM(SHA256) this package : 65a8384192ec51bf0bf93ae3f5a4f2e00f12d5e77a54f3982e4ab9f7e1119b5d CHECKSUM(SHA256) upstream package : 65a8384192ec51bf0bf93ae3f5a4f2e00f12d5e77a54f3982e4ab9f7e1119b5d Requires -------- python3-dissect.cstruct (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python3-dissect.cstruct: python-dissect.cstruct python3-dissect.cstruct python3.14-dissect.cstruct python3.14dist(dissect-cstruct) python3dist(dissect-cstruct) Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2399983-python-dissect.cstruct/srpm/python-dissect.cstruct.spec 2025-09-30 12:33:55.070954949 +0100 +++ /home/ben/fedora/review/2399983-python-dissect.cstruct/srpm-unpacked/python-dissect.cstruct.spec 2025-09-28 01:00:00.000000000 +0100 @@ -8,5 +8,5 @@ License: Apache-2.0 -URL: https://github.com/fox-it/dissect.cstruct +URL: https://https://github.com/fox-it/dissect.cstruct Source: %{pypi_source %{pypi_name_with_underscore}} @@ -17,5 +17,5 @@ A Dissect module implementing a parser for C-like structures. Structure parsing in Python made easy. With cstruct, you can write C-like structures and use them -to parse binary data, either as file-like objects or byte-strings.} +to parse binary data, either as file-like objects or bytestrings.} %description %{common_description} Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2399983 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api, Python Disabled plugins: Java, R, Perl, fonts, Ocaml, Haskell, C/C++, SugarActivity, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH