Spec URL: http://www.auroralinux.org/people/spot/review/winpdb.spec SRPM URL: http://www.auroralinux.org/people/spot/review/winpdb-1.1.2-1.fc7.src.rpm Description: Winpdb is an advanced python debugger, with support for smart breakpoints, multiple threads, namespace modification, embedded debugging, encrypted communication and speed of up to 20 times that of pdb.
first few comments 1) Build is failing. Add desktop-file-utils as BR 2) You don't need any requires Requires(post): desktop-file-utils Requires(postun): desktop-file-utils 3) May I know why update-desktop-database scriptlet is needed? 4) How about adding new directory named winpdb to %{python_sitelib} and install all *.py and *.pyc there? 5) Do we need any License file to be added in this package?
1. Whoops. 2. You're right. 3. It isn't. 4. Can't do it. Then we'd have to patch winpdb to look in a different place, and it seems to be a non-trivial patch. I'd rather not maintain it. 5. Nope. All of the .py files have a full copy of the GPL in their header already. New SPEC: http://www.auroralinux.org/people/spot/review/winpdb.spec New SRPM: http://www.auroralinux.org/people/spot/review/winpdb-1.1.2-2.fc7.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. 69f8e4fc00c31e931d39aeca9da30291 winpdb-1.1.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + no scriptlets are used. + Requires: /usr/bin/env /usr/bin/python python(abi) = 2.5 python-crypto wxPython >= 2.6 + GUI app. APPROVED.
Did my own CVS. Here's the record of it. New Package CVS Request ======================= Package Name: winpdb Short Description: An advanced python debugger Owners: tcallawa Branches: EL-4 EL-5 FC-6 F-7 InitialCC:
Built.