Red Hat Bugzilla – Bug 240180
Review Request: qwt - Qt Widgets for Technical Applications
Last modified: 2010-02-05 11:53:57 EST
Spec URL: http://downloads.sourceforge.net/qsmartcard/qwt.spec?use_mirror=osdn SRPM URL: http://downloads.sourceforge.net/qsmartcard/qwt-5.0.1-1.fc6.src.rpm?use_mirror=osdn Description: The Qwt library contains GUI Components and utility classes which are primarily useful for programs with a technical background. Beside a 2D plot widget it provides scales, sliders, dials, compasses, thermometers, wheels and knobs to control or display values, arrays, or ranges of type double.
Update to 5.0.2 split the docu to reduce space waste on the mirrors. The new files: SPEC: http://downloads.sourceforge.net/qsmartcard/qwt.spec?use_mirror=osdn SRPM: http://downloads.sourceforge.net/qsmartcard/qwt-5.0.2-1.fc6.src.rpm?use_mirror=osdn
Nobody for review??
A brief look at the spec as a start: Run rpmlint on the source and binary rpms. > %package devel > Summary: Development and doc files for {%name} Typo in the summary. > Beside a 2D plot widget it provides scales, sliders, dials, compasses, Besides... > %description devel > Cotains the development files. Contains... > %prep > %setup -q -n %{name}-%{version} -n %{name}-%{version} is the default > %install > make install "rm -rf $RPM_BUILD_ROOT" must be the first command in the %install section. > %files %defattr definition is missing > %files devel same here > %{_includedir}/%{name}/* directory %{_includedir}/%{name} is not included > %changelog > * Mon Jun 11 2007 Frank Büttner <frank-buettner@gmx.net> - 5.0.2-1%{?dist} Don't use %dist in %changelog, as it alters history whenever %dist changes.
So the next try. SRPM: http://downloads.sourceforge.net/qsmartcard/qwt-5.0.2-2.fc7.src.rpm?use_mirror=osdn SPEC: http://downloads.sourceforge.net/qsmartcard/qwt.spec?use_mirror=osdn
Well, no reviewers for almost 3 months, so: Frank, would you still want to have your package reviewed? If so, I will try to check your srpm.
Yes, I will.
For 5.0.2-2: * Source URL - For sourceforge tarball, please follow: http://fedoraproject.org/wiki/Packaging/SourceURL * Group - IMO usually the main package has "System Environment/Libraries" and "Development/Libraries" is for -devel package. * License - License can be fine with 'LGPLv2 with exceptions' * Setup - %setup must be quiet (i.e. use '%setup -q') * parallel make - Support parallel make ('make %{?_smp_mflags}') if possible. Otherwise write as a comment that qwt does not support it. * %defattr - Now we recommend '%defattr(-,root,root,-)' * File entry - Some files are listed twice --------------------------------------------------- %{_includedir}/%{name}/* %{_includedir}/%{name} --------------------------------------------------- ! Note Say "foo" is a directory. Then if we write in %files entry --------------------------------------------------- %files %defattr(-,root,root,-) foo --------------------------------------------------- this means the directory "foo/" itself and all files/directories/etc under the directory foo/. * Documents - The tarball contains some files under doc/html/ and examples/. Would you consider to include some files from these directories (and create -doc subpackage), for example?
(In reply to comment #7) > * Documents > - The tarball contains some files under doc/html/ > and examples/. Would you consider to include some > files from these directories (and create -doc > subpackage), for example? Oh, I noticed that you have also submitted "qwt-doc". Then this can be ignored.
So fixed: Here the next try: SRPM: http://downloads.sourceforge.net/qsmartcard/qwt-5.0.2-3.fc8.src.rpm?use_mirror=osdn SPEC: http://downloads.sourceforge.net/qsmartcard/qwt.spec?use_mirror=osdn
For -3: * Parallel make failed (at least for -j4, i386) http://koji.fedoraproject.org/koji/taskinfo?taskID=178403 Without parallel make the rebuild is successful. http://koji.fedoraproject.org/koji/taskinfo?taskID=178415 Please drop parallel support (and write a comment). = Other things are okay. ---------------------------------------------------------------------- This package (qwt) is APPROVED by me ----------------------------------------------------------------------
Very interesting, because at me, parallel build works. But to prevent for build errors, I will disable it. New Package CVS Request ======================= Package Name: qwt Short Description: Qt Widgets for Technical Applications Owners: frankb Branches: FC-6 F7 EL-4 Cvsextras Commits: No
Please take this one: New Package CVS Request ======================= Package Name: qwt Short Description: Qt Widgets for Technical Applications Owners: frankb Branches: FC-6 F7 EL-5 Cvsextras Commits: No
cvs done.
build done.
New Package CVS Request ======================= Package Name: qwt Short Description: Qt Widgets for Technical Applications Owners: frankb Branches: F11 F12 EL-5 Cvsextras Commits: No
Package Change Request ====================== Package Name: qwt New Branches: F11 F12 Owners: frankb
F-11 and F-12 brahches already exist for this package. Could you clarify what you're asking for?